* Unify resource mapping json schema across cpp and python usage
Signed-off-by: onecent1101 <liug@amazon.com>
* Update based on feedback
Signed-off-by: onecent1101 <liug@amazon.com>
* Add empty line at end of file
Signed-off-by: onecent1101 <liug@amazon.com>
* Add trait to enable/disable the Resource Mapping Tool
Signed-off-by: spham <82231385+spham-amzn@users.noreply.github.com>
* Moving ly_install_directory(DIRECTIORES Tools/ResourceMappingtool) into of the PAL_TRAIT_ENABLE_RESOURCE_MAPPING_TOOL block
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Enable and fix AWS Resource Mapping Tool on Linux
- Enable the trait AWSCORE_EDITOR_RESOURCE_MAPPING_TOOL_ENABLED for Linux
- Add additional traits to handle launching o3de local python on Linux
- Update the resource_mapping_tool.py to support preloading the shared libraries for Pyside (like the QtForPython gem) in order to resolve the local pyside2 libraries
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Update pyside2 to a RUNTIME dependency
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Update special linux preloading comments for clarity
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Add CR at the end of traits files
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* - Remove unnecessary extra argument '--executable-path' and use '--binaries-path' instead
- Add linux only loading of pyside modules to 'setup_qt_environment' instead
- Update README.md
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Updated unit tests for test_environment_utils.py
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Fix indentation for Linux specific logic in environment_utils.py
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Fix (more) indentation for Linux specific logic in environment_utils.py
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Replace exit with return in setup_qt_environment
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
* Final update copyright headers to reference license files at the repo root
Signed-off-by: spham <spham@amazon.com>
* Fix copyright validator unit tests to support the stale O3DE header scenario
Signed-off-by: spham <spham@amazon.com>
* Fixed organization of the AssetProcessor SourceAssetBrowser
Assets within the Engine Root were grouped under a '/' entry.
That has been fixed to use the relative path within the engine root for
those assets
Assets outside of the Engine Root, but on the same drive were using
absolute paths before. Now there are child entries that navigate up the
directory hierarchy to those asset locations
* Added ly_enable_gems call to Atom gems targets that are required
The DefaultLevel.prefab contains several Atom components, that require
the Atom RHI, RPI, Common_Feature, ShaderBuilder and AtomLyIntegration CommonFeatures
gems to be enabled in order to successfully process in the
AssetProcessor.
* Added ly_enable_gems call to make the Camera gem required in Tools,
Builders and Clients.
This is needed as the DefaultLevel.prefab contains an Editor Camera
Component
* Adding the ly_enable_gem call to make the Maestro gem required
CrySystem currently requires Maestro to be enabled in order to
initialize
* Added ly_enable_gems call to the SceneProcessing gem to make it required
The SceneCore and SceneData libraries that are part of the core engine
Code folder requires the SceneProcessing gem to be enabled in order to
invoke the InitializeDynamicModule hooks in DllMain.cpp in order to
initialize those libraries.
* Fixed bad argument in comment for Prefab CMakeLists.txt
* Fixed Assert in Asset Builders due to the Atom RPI Builder
The Atom RPI Builder was enabling the Asset Catalog for the ScriptAsset a second time
The Atom Feature Common EditorSystemCommonComponent.cpp which also loads
in the AssetBuilder is enabling the Asset Catalog for the ScriptAsset
Added BehaviorContext reflection to the OutputDeviceTransformType enum
to fix the BehaviorContext errors about reflecting a method that returns
such an enum
* Added TypeId output to the JsonDeserializer report message about missing
ClassData
Previously the report callback would indicate that the target type was
missing Serialization class data, but didn't indicate the TypeId of the
target type
* Added support to the ly_enable_gems function to be able to support
0 gems being enabled.
Updated the Install step for CMake to propagate any ly_enable_gems
within a CMakeLists.txt for a target into the generated CMakeLists.txt
that is made for each installed IMPORTED target
* Adding newline to the end of the Camera Gem CMakeLists.txt
* Fixing target TYPE parameter for actual Gem Modules to use the GEM_MODULE tag instead of MODULE
* Reverting change to the DESTINATION directory for the installed CMakeLists.txt to use the relative path to the installed directory
* Adding the Atom_Bootstrap gem as a required gem
The Client and GameLaunchers required the Atom_Bootstrap gem in order to create the NativeWindow
Added Atom_Feature_Common client module as a runtime dependency of the AtomLyIntegration CommonsFeature client module
* Fixed register.py --all-projects-path and --all-gems-path arguments to
NOT register projects or gems that are within a template folder
Fixed reading of old pre-1.0 o3de_manifest.json files where the
"engines" key was a json array
* Changed how the relative target source directory is calculated when that source directroy resides outside of the engine root.
The final dirname component is used with a unique SHA256 has to form a <dirname>-<8 char SHA256> folder for installing files into
* Adding newline to the end of Atom_Bootstrap CMakeLists.txt
* Moving ly_enable_gems variants for Tools and Builders inside of PAL_TRAIT_BUILD_HOST_TOOLS block
* Adding a comment to AWSCore.ResourceMappingTool target to indicate that it is not a GEM_MODULE.
Furthermore it cannot be loaded with the Gem system because the library is in a different directory the executable
* LYN-3601: Provide skeleton classes for AWS Attribution (#31)
Provide skeleton classes for AWS Attribution, along with some basic unit tests
* Add AWS Attribution UI and settings (#56)
* Adding AWS Attributions UX and corresponding editor preference s setting
* Fix serialized field description
* Fixed update frequency to be a day
* Handling editor startup with default values for AWSAttribution
* Add missing header and remove AWSCoreSystemComponentMock fron test
* Generate and post AWSAttribution metric (#69)
* Adding AWS Attribution Api service job
* Adding support for config endpoint override
* Update Api endpoint formatting, fix default region
* Remove extra header
* Fixes for link issues
* Fix Unittest namespace
* Instantiating AWSAttributionSystemComponent in AWS.Editor module
* Update AttributionMetric with engine version and AWS enabled gems (#77)
* Update AttributionMetric with engine version and AWS enabled gems
* Fix warnings
* Undoing accidental change
* Saving level PrefabLevel_OpensLevelWithEntities
* Remove overriding editorprefrences.setreg
* Revert "Saving level PrefabLevel_OpensLevelWithEntities"
This reverts commit 529af70c55ece70fc6bc29ceb83bef60413713a3.
* Move AWS preferences to its own temp settings file
* Undo accidental file add
* Add missing string params in warning messages
Co-authored-by: Pip Potter <61438964+lmbr-pip@users.noreply.github.com>
## Details
After migrating to engine python environment, there is no extra step required to launch resource mapping tool in editor.
1. This change is to migrate the editor tool launching process to engine python environment.
2. Add messagebox to show errors while using the tool
3. Note - as Qt binaries are not well organized in build directory, so separate out *AWSCore.ResourceMappintTool* target to group Qt binaries into independent build sub folder to solve the issue (temporarily, fix can be tracked by https://jira.agscollab.com/browse/LYN-2669, once fix is done, we can just remove this individual target)
## Testing
Runs AWSCore.Editor.Tests
```
[----------] Global test environment tear-down
[==========] 8 tests from 4 test cases ran. (161 ms total)
[ PASSED ] 8 tests.
```
1. Add support to use engine python runtime environment. Ideally we should use project executable directory which contains required qt binaries after build. But currently Qt plugins are not put under proper subdirectory which causes huge overhead of loading plugin binaries (see details in this jira https://jira.agscollab.com/browse/LYN-2669 ). The temporary solution is to use AWSCore.Editor target to create a subdirectory for our use case.
2. **Minor Fix** After migrating to engine python environment, see boto3 warning while using debug mode, seems like a existing issue for a long time https://github.com/boto/boto3/issues/454. Register a after call event to close connection
3. **Minor Fix** After migrating to engine python environment, see Qt multithread warning while using debug mode, change direct setter function call to qt signal
Vincent Liu
Junbo Liang
Steve Pham
Esteban Papp
amzn-hdoke
lumberyard-employee-dm
Nicholas Lawson
alexpete