Commit Graph

235 Commits

Author SHA1 Message Date
amzn-mgwynn 63bb8aa8a9 Merge pull request #1286 from aws-lumberyard-dev/Prism/gem-db
updating missed variable name change in logging call
2021-06-11 17:09:42 -07:00
mgwynn a5cead4414 updating missed variable name change in logging call 2021-06-11 19:05:51 -04:00
amzn-mgwynn 5992c1404b Merge pull request #1259 from aws-lumberyard-dev/Prism/gem-db
Adding unit test for project properties cli
2021-06-11 15:56:14 -07:00
lumberyard-employee-dm fe441b01a0 Split the new_tags and delete_tags paramaters if they are strings on spaces. 2021-06-11 15:04:51 -05:00
lumberyard-employee-dm 3127bf7477 Making sure the expected tag set exactly matches the "user_tags" in the project_json 2021-06-11 15:02:15 -05:00
mgwynn 0b3a56d031 Incorporating review comments. Adding checks for json contents. Added class. Minor reformatting. 2021-06-11 15:01:33 -04:00
hultonha 2d41a701af Merge branch 'stabilization/2106' into tomhh_stabilization-to-development 2021-06-11 09:43:11 +01:00
mgwynn e80ba41bdd Adding project properties test to cmakeLists 2021-06-10 22:08:05 -04:00
mgwynn d029ba894e Added failure condition for fail case test 2021-06-10 21:24:27 -04:00
mgwynn 9a61557932 Adding unit test for project properties cli 2021-06-10 21:17:24 -04:00
Mike Chang 01847ef6dd Changed mac and ios node label
This changes the Mac and iOS job AMI that we're using to Big Sur (OSX 11.4 update). This includes the following based on https://github.com/aws-lumberyard/o3de/tree/development/scripts/build/build_node/Platform/Mac:

- XCode 12.4
- CMake 3.20.3

Note: As of 86136dd, these builds still fail with the same errors as the nightly build under Catalina. See SPEC-7273 and LYN-4071 for details
2021-06-10 17:24:14 -07:00
amzn-sj 607f32fae6 No need to check if the first character is a number. This is already validated before. 2021-06-10 13:34:16 -07:00
amzn-sj 2ee4d8ff6b Sanitize identifier names before substituting them in C++ template files 2021-06-10 11:01:23 -07:00
lumberyard-employee-dm 88d16b23d4 Fixing the enable_gem.py and disable_gem.py commands (#1207) (#1220)
* Fixing the enable_gem.py and disable_gem.py commands (#1207)

* Fixing the enable_gem.py and disable_gem.py commands
The project path wasn't taking into account when querying for gems,
templates and restricted directories registered with the project

Fixing the cmake.py add_gem_dependency and remove_gem_dependency methods
to properly detect a gem within a `set(ENABLED_GEM ...)` cmake variable
Also updated the add_gem_dependency to add the gem right before the end
marker of ')'
Updated the remove_gem_dependency to remove each instance of a gem with
a content that is in between in the `set(ENABLED_GEM ...)` cmake
variable

* Correct Typo in manifest.get_registered doc string

* Removing second get_all_restricted() method
2021-06-09 18:50:28 -05:00
amzn-sj 6c056ad566 Remove duplicate definition of function 2021-06-09 15:29:39 -07:00
daimini d6d2cbae7e Merge branch 'stabilization/2106' into gitflow_210609 2021-06-09 14:26:29 -07:00
lumberyard-employee-dm 217eddc8bd Fixing the enable_gem.py and disable_gem.py commands (#1207)
* Fixing the enable_gem.py and disable_gem.py commands
The project path wasn't taking into account when querying for gems,
templates and restricted directories registered with the project

Fixing the cmake.py add_gem_dependency and remove_gem_dependency methods
to properly detect a gem within a `set(ENABLED_GEM ...)` cmake variable
Also updated the add_gem_dependency to add the gem right before the end
marker of ')'
Updated the remove_gem_dependency to remove each instance of a gem with
a content that is in between in the `set(ENABLED_GEM ...)` cmake
variable

* Correct Typo in manifest.get_registered doc string
2021-06-09 14:14:01 -05:00
Steve Pham 965fced771 SPEC-4524: Script updates to support iOS Unit Test Jobs (#1180) 2021-06-08 15:01:44 -07:00
Esteban Papp b1fca488bf LYN-4332 Metric jobs not passing JOB_NAME, BUILD_NUMBER, NODE_NAME, CHANGE_ID (#1190)
* Fix quotes

* Revert "Fix quotes"

This reverts commit 29ace5ef2bf1c78991a8cfeb840bfb30c4ce5d8d.

* evaluating the parameters

* Revert "Revert "Fix quotes""

This reverts commit 4f7008e9ccbd5fdc0b33853a4fb1f50285233da9.

* just one eval

* double escaping

* another attempt to happiness

* changing NODE_NAME to LABEL_NAME since that one is more stable and doesnt have spaces
2021-06-08 14:24:22 -07:00
Esteban Papp 4b3d0d1054 LYN-4327 [SDK] External Gem's aren't added to the project solution when using SDK (#1191)
* should pickup the external directories registered by the project

* Add support for AzTest and AzTestRunner in the SDK

* missing IMPORT_LIB

* Moved where .Assets targets get generated so they are visible in the SDK

* generate the Directory.Build.props in the right path

* excluding target on platforms that dont support it
2021-06-08 14:01:50 -07:00
Scott Romero 3eb612b652 [main] option for installer upload to s3 (#1173)
Fixed issue with quoted regex when invoking upload_to_s3.py via script
Improved error handling in online install bootstrapper generation commands
2021-06-08 09:30:20 -07:00
evanchia b2a6616a31 fixed cwd error 2021-06-07 18:50:21 -07:00
evanchia 9afe5225e6 removing wildcard from rmdir, not windows compatible 2021-06-07 18:39:03 -07:00
evanchia 9373c5fd0d Fixing xml directory race condition on incremental runs 2021-06-07 18:31:57 -07:00
scottr 57faa2d377 [cpack_installer] installer upload to s3 2021-06-07 15:15:14 -07:00
amzn-mgwynn 38865c95e2 Merge pull request #1162 from aws-lumberyard-dev/Prism/gem-db
Adding python bindings for modifying project properties
2021-06-07 16:59:10 -04:00
mgwynn b0826c5f9c added tag managerment arguments for CLI to mutually exclusive group 2021-06-07 15:08:18 -04:00
mgwynn 6d6f8413c8 Incorporating review comments. Some parameter modifications. Some cli edge case handling. Remove remove_tag member from project info 2021-06-07 14:14:32 -04:00
Ibtehaj Nadeem 1ffcfa07e6 Remove Jenkins failure notifications (#958)
Remove Jenkins failure notifications
2021-06-07 12:53:07 +01:00
Alex Peterson aeaf1bcdbe Fix engine settings not populating or saving
* Allow multiple settings to be registered at once
* Old manifests versions may not have default_third_party_folder
2021-06-04 21:29:36 -07:00
amzn-mgwynn ffdce2ef7f Merge branch 'main' into Prism/gem-db 2021-06-04 23:19:47 -04:00
mgwynn 7984f82e48 Bing project_properties CLI to updateProject method. Update project info struct.
Update project properties cli to support lists for tags. Minor adjustments to support
changes.
2021-06-04 23:03:17 -04:00
Esteban Papp 1396110f6d Preventing builds from cleaning on each step (#1151) 2021-06-04 15:46:19 -07:00
Esteban Papp cf35585bc0 Making incremental linking off by default (#1154) 2021-06-04 15:25:57 -07:00
scottr 0d1b217b24 Merge branch 'main' into cpack_installer 2021-06-04 06:45:43 -07:00
Scott Romero 64872e024e [main] add 3rd party to engine registration
Merge pull request #1131 from aws-lumberyard-dev/default_3rdparty
2021-06-03 19:32:59 -07:00
scottr 4405c2275f [default_3rdparty] changed CLI argument type to pathlib.Path and removed optional str type from usage 2021-06-03 18:23:01 -07:00
Esteban Papp 29ac17a090 SPEC-7135 Provide a method to re-trigger compiler detection for changes that require it (#1092)
* SPEC-7135 Provide a method to re-trigger compiler detection for changes that require it

* removing check (is wrong and is not necessary)

* Invert existance check

* add empty lines at the end

* Clean is triggering on each build

* clearing if the variable is false

* test code to understand what is going on...

* yeap, looks good

* handling "false" in linux/mac

* fix for linux/mac

* Fixing typos
2021-06-03 18:05:05 -07:00
scottr d30fd8b1dd Merge branch 'main' into default_3rdparty 2021-06-03 16:24:55 -07:00
lumberyard-employee-dm 816d05ef2d Updating manifest.py template query functions (#1113)
* Updating manifest.py template query functions
The get_project_templates, get_gem_templates and get_generic_templates
methods have been renamed to indicate that the methods return the
templates that can be used in a create-project, create-gem and
create-from-template command of the engine_template.py

Updated the print_registration.py script to support outputing project
specific gems and templates.
Add a unit test script for the manifest.py script.
Added unit test to validate the new functions:
`get_templates_for_project_creation`
`get_templates_for_gem_creation`
`get_templates_for_generic_creation`

* Implementing the project print registration methods

Added implementations of the project print registration methods and tested them locally
Removed implementations of the download print registration methods, since they have not went through app-sec review.

* Renaming get_restricted_data to get_restricted_json_data

Fixed the get_registered method in manifest.py when looking up projects

* Updated the print_manifest_json_data calls to return the result
2021-06-03 18:16:22 -05:00
scottr 85e6d06c2c [default_3rdparty] add 3rd party to engine registration + specific path registration fixes 2021-06-03 16:09:10 -07:00
amzn-mgwynn 77d861c124 Merge pull request #1108 from aws-lumberyard-dev/Prism/gem-db
Prism/gem db to main. Adding ability to modify project settings (display name, origin, icon, summary, user tags) through the o3de CLI with edit-project-properties using a project path or registered project name.
2021-06-03 16:10:56 -04:00
lumberyard-employee-dm dce87534c7 Removing the Pyside implementation of the project manager python scripts (#1112)
* Removing the Pyside implementation of the project manager python scripts

* Removing reference to the scripts/project_manager directory 

The Install_common.cmake script reference to the project_manager directory has been removed.
2021-06-03 14:37:16 -05:00
mgwynn e99a95d909 Added copyright header for validation 2021-06-03 15:02:18 -04:00
mgwynn 7bba5ed2fc Incorporated suggestion to use setdefault to handle missing tag property rather than explicitly checking for and creating it. 2021-06-03 14:43:13 -04:00
mgwynn 6681a53768 Add the ability to remove tags. Updated some descriptions, and updated some log messages to include parameters. 2021-06-03 14:13:44 -04:00
scottr bcef8856ff [cpack_installer] minor wording fixes 2021-06-03 10:51:13 -07:00
mgwynn 5838975d62 Incorporating review comments. Minor formatting changes and changes to parameter descriptions.
Removed try-catch for property modification and added creation of user_tags element if it does not exist
but is modified through CLI
2021-06-03 13:29:51 -04:00
scottr 8214706ff9 [cpack_installer] reworked how packaging is enabled for windows 2021-06-03 08:24:01 -07:00
scottr 5695681ed3 [cpack_installer] fifth attempt to fix cpack selection 2021-06-02 21:03:41 -07:00