Commit Graph

2895 Commits (0b718d435c63e5f3f5f16f5d64be7be559b18c55)

Author SHA1 Message Date
rgba16f [Amazon] e1c49e436d
convert atom to task graph (#4230)
* Intial attempt to convert the Atom/RHI/FrameScheduler to use the new TaskGraph api

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Avoid enqueuing work on the active task thread if the submitted task
graph is waitable

When submitting a task graph, supplying a wait event implies that
dependent jobs must occur on threads that do not wait on the event (in
the absence of work stealing). This change prevents this by adding a
notion of a task thread enable/disable state, and prohibiting dependent
jobs from being enqueued on waiting threads.

Signed-off-by: Jeremy Ong <jcong@amazon.com>

* Convert RPI/Scene to use TaskGraph pass 1, Culling jobs remain on the old system

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* RemoveTask Graph changes from the FrameScheduler::ExecuteGroups, use old job system instead

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Per review, removing commented out code

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Cleanup debug code, & build fix

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Add a cvar & interface to query whether to use jobs or task graph

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Make TaskGraph assert if you try to wait inside a job

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Fix TaskTest SpawnSubgraph to account for the new TaskGraphEvent assert on wait in a running task

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* 3 minor cleanups. 1) Events always store a ptr to their executor 2) Fix clang compile error 3) remove an early out.

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Fix double group end that was causing assert/crash plus misc minor diff's with development

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Fix deallocation failure on deactivation of the TaskGraphSystemComponent. Also make the system component account for multiple creation in Unit Tests.

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Update with PR feedback
1) Rename UseTaskGraph to IsTaskGraphActive & update related code
2) prefer TaskExecutor::SetInstance
3) add comments and remove commented out code

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Fix incorrect RTTI name for TaskGraphActiveInterface

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

* Move TaskGraphSystemComponent CRC calculation to a shared variable

Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>

Co-authored-by: Jeremy Ong <jcong@amazon.com>
4 years ago
carlitosan 8a1af282c4
Merge pull request #4419 from aws-lumberyard-dev/carlitosan/bugfix
Fix unused variables in property list, and set ed_useNewAssetBrowserTableView  to false by default
4 years ago
chcurran 5fe4d8043d set ed_useNewAssetBrowserTableView to false by default
Signed-off-by: chcurran <82187351+carlitosan@users.noreply.github.com>
4 years ago
Chris Galvan 8581b30260
Merge pull request #4274 from aws-lumberyard-dev/daimini/FocusMode/breadcrumbs
LYN-5303 | Focus Mode - Add breadcrumb of the prefab hierarchy path when entering into the prefab editing mode
4 years ago
Chris Burel aa8594b491
Add a unit test for `XcbInputDeviceKeyboard` (#4393)
* Use XcbUniquePtr to manage xcb resources

Signed-off-by: Chris Burel <burelc@amazon.com>

* Add a unit test for XcbInputDeviceKeyboard

Signed-off-by: Chris Burel <burelc@amazon.com>
4 years ago
Danilo Aimini 225d9d3b3c Fixes to unit tests after merge
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
Danilo Aimini d3bc7d8f12 Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

# Conflicts:
#	Code/Framework/AzToolsFramework/Tests/FocusMode/EditorFocusModeTests.cpp
#	Code/Framework/AzToolsFramework/Tests/Prefab/PrefabFocus/PrefabFocusTests.cpp
4 years ago
bosnichd 3635e5ed35
Put the ShaderMetrics.json in the @user@ folder, plus an unrelated #include path fix. (#4402)
Signed-off-by: bosnichd <bosnichd@amazon.com>
4 years ago
Danilo Aimini 8d67f184c8
LYN-7008 | Focus Mode - Selection unit tests (#4357)
* Refactor existing tests and fixtures, split them up in more granular tests, and add more comments.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Refactor test fixture for FocusMode to make it more reusable

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Fixture rename, draft of selection test

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Split SetFocus and ClearFocus tests for Editor Focus Mode

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Move BoundsTestComponent to its own file so that it can be reused in Focus Mode Selection tests

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Making progress on selection test. Test compiles now, but selection doesn't seem to be working.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Removed commented out code from previous iteration.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Move BoundsTestComponent under the UnitTest namespace

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Viewport selection tests + minor fixes.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

* Minor fixes

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
puvvadar bee4346df8
Merge pull request #4401 from aws-lumberyard-dev/mp_unit_test_pass1
Quick updates to AzNetworking unit tests
4 years ago
lumberyard-employee-dm b1c82fc045
Updated references to Engine.pak to be lowercase engine.pak (#4397)
* Updated references to Engine.pak to be lowercase engine.pak

This makes the engine.pak file consistent with naming scheme of other pak files such as assets.pak.

It will also help avoid issues with mounting the file on Linux.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Engine.pak now loads correctly in release builds. The check for the file existing was failing in release builds because it was only checking inside packs. OpenPack first checks if the file exists, anyways, so it was safe to remove.

Signed-off-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

Co-authored-by: stankowi <4838196+AMZN-stankowi@users.noreply.github.com>
4 years ago
srikappa-amzn ffbc3f1c80
Fix a bug in recursion of prefab links when checking for dirty prefabs (#4392)
* Fix a bug in recursion of prefab links when checking for dirty prefabs

Signed-off-by: srikappa-amzn <srikappa@amazon.com>

* Added a missing EntityId header

Signed-off-by: srikappa-amzn <srikappa@amazon.com>
4 years ago
Danilo Aimini 4d368fe329 Fix to capitalization in include via the UI
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
Danilo Aimini 7b1d98535d Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs 4 years ago
jonawals fa47b35580
Call sites for activating/deactivating viewport editor modes. (#4265)
* Provisional impl and testing of central state tracker.

Signed-off-by: John <jonawals@amazon.com>

* Add missing namespace comment.

Signed-off-by: John <jonawals@amazon.com>

* ViewportEditorModeState -> ViewportEditorModes

Signed-off-by: John <jonawals@amazon.com>

* ViewportEditorModesTracker -> ViewportEditorModeTracker

Signed-off-by: John <jonawals@amazon.com>

* GetEditorModeState ->GetViewportEditorModes

Signed-off-by: John <jonawals@amazon.com>

* GetNumTrackedViewports -> GetTrackedViewportCount

Signed-off-by: John <jonawals@amazon.com>

* IsViewportStateBeingTracked -> IsViewportModeTracked

Signed-off-by: John <jonawals@amazon.com>

* Fix API comments.

Signed-off-by: John <jonawals@amazon.com>

* Delete hangover file.

Signed-off-by: John <jonawals@amazon.com>

* Delete more hangover files.

Signed-off-by: John <jonawals@amazon.com>

* Minor member name refactor.

Signed-off-by: John <jonawals@amazon.com>

* Refactor nonclemanture.

Signed-off-by: John <jonawals@amazon.com>

* Rename Enter/ExitMode to Register/UnregisterMode.

Signed-off-by: John <jonawals@amazon.com>

* Error and warning msgs now return AZ::Outcomes.

Signed-off-by: John <jonawals@amazon.com>

* Change all nomenclature to Activate/Deactivate for consistency.

Signed-off-by: John <jonawals@amazon.com>

* Change tense of notification bus methods.

Signed-off-by: John <jonawals@amazon.com>

* Fix malformed string format.

Signed-off-by: John <jonawals@amazon.com>

* Fix malformed string format (again).

Signed-off-by: John <jonawals@amazon.com>

* Fix Linux warning.

Signed-off-by: John <jonawals@amazon.com>

* Call sites for editor mode activate/deactivate.

Signed-off-by: John <jonawals@amazon.com>

* Move Component editor mode logic to ComponentModeCollection.

Signed-off-by: John <jonawals@amazon.com>

* Delete non-source data.

Signed-off-by: John <jonawals@amazon.com>

* Remove line breaks and forward declare class.

Signed-off-by: John <jonawals@amazon.com>

* Remove constructors without ViewportEditorModeTrackerInterface ptr.

Signed-off-by: John <jonawals@amazon.com>

* Add integration tests for viewport editor modes.

Signed-off-by: John <jonawals@amazon.com>

* Address PR comments.

Signed-off-by: John <jonawals@amazon.com>
4 years ago
SergeyAMZN 08e020f2b1
Merge pull request #4251 from aws-lumberyard-dev/nvsickle/RevertFrameTimer
Revert "Refresh rate driven rendering tick logic (#3375)"
4 years ago
amzn-sean 43748c37fd
update joints to use cluster viewport ui. (#4352)
also some joints Component mode cleanup.

Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com>
4 years ago
AMZN-Igarri 9eb9a13d99
Flipped CVar to activate the AssetBrowser Search View (#4370)
Signed-off-by: igarri <igarri@amazon.com>
4 years ago
hultonha ab0aa4973f
Remove camera LookAtAfterInterpolation (#4391)
Signed-off-by: hultonha <hultonha@amazon.co.uk>
4 years ago
Danilo Aimini 742a84f587 Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs 4 years ago
Danilo Aimini 27c7e2dcb0 Add correct include in FocusModeInterface to fix non-Unity builds.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
Danilo Aimini ea3435a9bb Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs 4 years ago
Steve Pham 19bd934a43 Fix missing include for AZStd::unordered_set in AssetEditorBus.h
Signed-off-by: Steve Pham <spham@amazon.com>
4 years ago
lumberyard-employee-dm 090aa8f053
Removed ununeeded includes from EBus EBus.h and Policies.h (#4256)
* Removed ununeeded includes from EBus EBus.h and Policies.h

Updated the locations which needed those includes

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Adding missing include for <memory> to AWsClientAuthBus.h

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove the while true loop in the EBusQueuePolicy Execute() function

The while true loop in Execute was for allowing additional functions to be queued in the middle of execution of current list of functions.
That functionality was dangerous, because if a queued function added itself during execution unconditionally, then it would result in an infinite loop

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the AssetManager::DispatchEvents function to pump the AssetBus event queue until empty

Queued Events on the AssetBus is able to queue additional events on that Bus during execution of those events.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Changed the AssetManager::DispatchEvents function to only execute the
AssetBus queued events once

Changed the AssetJobsFloodTest.AssetWithNoLoadReference_LoadDependencies_BehaviorObeyed test to dispatch events until the OnAssetContainerReady callback is signaled.

This happens after every asset load to make sure that the
expiring AssetContainer instances are removed from `AssetManager::m_ownedAssetContainer` container before retrying to load the same asset.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added a MaxTimeoutSeconds constant for the maximum amount of the time to run a single DispatchEvents loop

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
lumberyard-employee-dm 816a623c97
Added missing EntityId.h include to FocusModeInterface.h (#4396)
* Added missing EntityId.h include to FocusModeInterface.h

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Non-unity build fix

Adding missing BehaviorContext.h includes to Multiplayer Gem

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added missing BehaviorContext.h include to NetworkCharacterComponent

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
puvvadar 325294aef8 Remove magic number in AZN unit
Signed-off-by: puvvadar <puvvadar@amazon.com>
4 years ago
puvvadar c9ea34d45f Quick updates to AzNetworking unit tests
Signed-off-by: puvvadar <puvvadar@amazon.com>
4 years ago
Danilo Aimini a7f6bfbb50 Fix tests to work with new interface APIs using EditorEntityContextId
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
AMZN-Phil 103dc6cfcf
Merge pull request #4351 from aws-lumberyard-dev/Prism/AddRepoDialog
Add Add Gem Repo Dialog
4 years ago
Tommy Walton b79c2f385d
Adding a temporary Orphan function to the InstanceDatabase (#4297)
* Adding a temporary Orphan function to the InstanceDatabase, which will remove an instance from the database so it will not be found using Find or FindOrCreate. The instance will still persist until its use-count drops to 0, at which point it will be deleted. This is to enable the model asset to remove existing buffer/modellod/model instances and replace them with new instances that have the up to date data. Added unit tests for testing.

Signed-off-by: amzn-tommy <waltont@amazon.com>

* Fix an incorrect ceil and update ParallelInstance test cases for readability

Signed-off-by: amzn-tommy <waltont@amazon.com>
4 years ago
Danilo Aimini 94bd95cee3 Solve merge issue
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
Danilo Aimini 3b9c3f832a Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>

# Conflicts:
#	Code/Editor/ViewportTitleDlg.cpp
4 years ago
nggieber 02987d9010 Fixed another non-unity build error
Signed-off-by: nggieber <nggieber@amazon.com>
4 years ago
Artur K f44169f7fa
Cleanup SerializeContext.h pt.1 (#4264)
* Remove AssetSerializer inclusion from SerializeContext header

Moved a few Reflect methods to new cpp files.

In addition, some preparations for further header dependency reductions.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Fix smoke test lua failures.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Windows build fixes.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Missing license headers

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Fix white-space issues.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Code review fix for AzToolsFramework/AssetEditor/AssetEditorBus.h

Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Fix inheritance list wrapping broken by older clang-format

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
nggieber 6b75c3b9d7 Fixed non-unity compile error
Signed-off-by: nggieber <nggieber@amazon.com>
4 years ago
hultonha c34b6ffe3b
Overhaul of how camera orbit/pivot behavior works (#4345)
* overhaul to how camera orbit/pivot behavior works

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* update naming from orbit to pivot

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* fix camera unit tests

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* add additional tests for new camera pivot behavior

Signed-off-by: hultonha <hultonha@amazon.co.uk>

* fix comment and add additional info for tests

Signed-off-by: hultonha <hultonha@amazon.co.uk>
4 years ago
Danilo Aimini b28f871b20 Fix casing of BreadCrumbs include in PrefabViewportFocusPathHandler.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
Danilo Aimini 34def643a2 In Slice mode, don't instantiate the handler, and also hide and disable the breadcrumbs widgets.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
Danilo Aimini 9a325c657d Add EntityContextId argument to focus interface functions that don't deal with entityIds.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
nggieber 16e66cfa71 Addressed review feedback
Signed-off-by: nggieber <nggieber@amazon.com>
4 years ago
Danilo Aimini c204aa1abe Change notification buses to be addressed on EntityContextId, and connect the handlers to the default id. Request interfaces should not need that id as they can retrieve it from the entityId.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
Danilo Aimini ce334f9443 Correctly set focused entity in case the root prefab instance is focused.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
Danilo Aimini 1f32076ca5 Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs 4 years ago
Nicholas Van Sickle a692ae1567
Restore event listening behavior in EntityOutlinerListModel (#4254)
Disables a problematic child reparenting code path in EditorEntityModel that led to the series of remove -> add -> remove notifications for reparented entities that led to unnecessary updates and a sporadic QSortFilterProxyModel crash

Signed-off-by: nvsickle <nvsickle@amazon.com>
4 years ago
Alex Peterson 9f1a308177
Fix transparency issue on MacOS (#4358)
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
4 years ago
Chris Galvan 6f8afd69d4
Merge pull request #4372 from aws-lumberyard-dev/daimini/4364/restore-layout-fix
Editor crashes after changing the layout when the Prefab system is enabled
4 years ago
Mikhail Naumov e958b0e09c
No longer can instantiate prefabs in an empty level (#4277)
* No longer can instantiate prefabs in an empty level

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* PR feedback from Ram

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* removing tab

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* PR feedback

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Implement Project Manager 'build' button for Mac and Linux(#4248)

Signed-off-by: Steve Pham <spham@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Remove the PrefabEditManager. Introduce the FocusMode system on the Editor side, and a PrefabFocusHandler on the Prefab side to handle focus.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Changed FocusOnOwningPrefab to return Outcome. Added comments and error checking.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Remove assert for edge case that can actually happen in normal circumstances, simply return false in those cases.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Remove nested FocusModeFramework namespace

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Minor fixes to variable names and comments.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* ClearFocusRoot implementation

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Remove pragma once from cpp file

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Fix header formatting to pass validation

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Do not assert if m_focusModeInterface can't be initialized

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Initialization changes to pass unit tests. Some interfaces are now retrieved on demand and there's clearer failure paths that don't involve asserts to better handle test/headless initializations.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* LYN-6793 [iOS] [asset_profile] 4 assets fail to process for iOS (#4268)

* LYN-6793 [iOS] [asset_profile] 4 assets fail to process for iOS
The issue was because the compression of ETC formats took too long.
Replaced all ETC and PVRTC formats with ASTC formats.
Update all pixel operation for formats with single R channel to align the change with R8.

Signed-off-by: Qing Tao <qingtao@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Use resize_no_construct when creating a buffer asset, since the initial data is going to be memcopy'd anyways. (#4249)

Signed-off-by: amzn-tommy <waltont@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Fix a minor spelling mistake (#4247)

Signed-off-by: amzn-tommy <waltont@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* 1. Update iOS deployment target to 14 (#4266)

2. Set MacOS default deployment target to 11.

Signed-off-by: amzn-sj <srikkant@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Debug build clang fixes

Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Fix failed 'server' platform assets on Linux related to Shaders (#4275)

* Add missing 'server' platform identifier for the ShaderBuilder
* Use the current host platform as the fallback platform identifier (and not 'pc')

Signed-off-by: Steve Pham <spham@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* [development] Atom CPU profiler include cleanup (#4272)

 - Removed all unnecessary includes to Atom CpuProfiler.h
 - Added includes to AzCore Profiler.h where necessary

Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Add guard against edge case.

Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Expose Transform::CreateLookAt to behavior context to use with hydra tests

Signed-off-by: amzn-tommy <waltont@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Cached BLAS objects at the sub-mesh level

Signed-off-by: dmcdiar <dmcdiar@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* EMotion FX: Asset Processor generates an Actor for every FBX (#4284)

Fixing the actor behavior to ignore actor asset generation for files that only contain nodes/bones. We're only checking for blend shapes and skins now. In case neither is present in an FBX, we don't export the actor asset.

This makes a plain skeleton a special case where users manually need to add the actor group for the fbx. The most common use case for these are animation files anyway, where we don't want to export actor assets.

Also increased the version number of the actor group so that they are all getting reprocessed and the unneeded actor assets get removed.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* EMotion FX: Crash in the actor builder when fbx meta data contains node groups (#4283)

Fixing a crash related to the small array conversion that made multiple assets crash the actor builder.

Signed-off-by: Benjamin Jillich <jillich@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Project Manager Gem Dependencies (#4132)

* Fix engine API change and add gem dependencies

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Add GemCatalog dependency test

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Clarify display name and fix missing const

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Moving a couple helper functions into private scope

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Update gem count when unselecting a gem #4074

This addresses the following issue https://github.com/o3de/o3de/issues/4074

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Active/Inactive filter and dependency tooltips

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Accessors for previously added and dependencies

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Cart displays gem dependency changes

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Shorten titles to fit in summary popup

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Remove QString::number

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Remove extra space

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Consolidate source model accesor helpers

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Addressing minor feedback

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* Remove unused local variable

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Fix AutoGen of RPCs with no params

Signed-off-by: puvvadar <puvvadar@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Adds Inspector to Gem Repo Screen (#4242)

* Adds the gem repo screen with the UI built but with mocked data and not connected to the o3de scripts

Signed-off-by: nggieber <nggieber@amazon.com>

* Changed name of added to enabled, disabled define, removed unused functions

Signed-off-by: nggieber <nggieber@amazon.com>

* Added Repo Screen Inspector UI

Signed-off-by: nggieber <nggieber@amazon.com>

* Addressed minor PR feedback

Signed-off-by: nggieber <nggieber@amazon.com>

* Add some more minor PR changes

Signed-off-by: nggieber <nggieber@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Updated NetworkSpawnableHolderComponent to use TransformBus instead of FindComponent. Added dependency on TransformService

Signed-off-by: pereslav <pereslav@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Fixed Entity::GetTransform to work for the components of an activating entity. Made the cached transform lazy evaluated.

Signed-off-by: pereslav <pereslav@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Changed NetworkSpawnableHolderComponent to use Entity::GetTransform instead of an ebus call

Signed-off-by: pereslav <pereslav@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Moved local variable to a smaller scope

Signed-off-by: pereslav <pereslav@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Signed-off-by: LesaelR <LesaelR@amazon.com> (#4278)

* Signed-off-by: LesaelR <LesaelR@amazon.com>

* Removing the un-needed sandbox marks.

Signed-off-by: LesaelR <LesaelR@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Small fix for color node tooltip to ask for values 0-1 instead of 0-255

Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Exposing NetworkCharacterComponent::TryMoveWithVelocity to script. Updating Multiplayer AutoComponent baseclass behavior context to Reflect itself instead of its derived (human made) component. This is so the derived class can also create behaviorcontext classes of its own if needed. Misc copyright header edit.

Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Make sure Multiplayer AutoComponents dont generate property OnChange script events if GenerateEventBindings is disabled

Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Adding parameter names to NetworkCharacterComponent script events so people know what the parameters are used for in scriptcanvas

Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Small fix to use AZ_CRC_CE

Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Disabling some tests when prefab mode is enabled

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Revert "Disabling some tests when prefab mode is enabled"

This reverts commit 3fe9358d42ec9d7fa5ffaee458e4c6ca3ecbed6e.

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Revert "PR feedback"

This reverts commit a5b86d1954974b950b7719d1bc7dd56bc2a2a21b.

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Revert "removing tab"

This reverts commit ff6ef4bfb514d82a1b668baa95901ad363e648d0.

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Revert "PR feedback from Ram"

This reverts commit cba7f9c2a114d3bb51c9b64f38a7e1fef7bb8fe8.

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Renaming level->rootInstance

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
Co-authored-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Co-authored-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com>
Co-authored-by: Tommy Walton <82672795+amzn-tommy@users.noreply.github.com>
Co-authored-by: SJ <srikkant@amazon.com>
Co-authored-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
Co-authored-by: Scott Romero <24445312+AMZN-ScottR@users.noreply.github.com>
Co-authored-by: amzn-tommy <waltont@amazon.com>
Co-authored-by: dmcdiar <dmcdiar@amazon.com>
Co-authored-by: Benjamin Jillich <43751992+amzn-jillich@users.noreply.github.com>
Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Co-authored-by: puvvadar <puvvadar@amazon.com>
Co-authored-by: AMZN-nggieber <52797929+AMZN-nggieber@users.noreply.github.com>
Co-authored-by: pereslav <pereslav@amazon.com>
Co-authored-by: LesaelR <89800757+LesaelR@users.noreply.github.com>
Co-authored-by: Gene Walters <genewalt@amazon.com>
4 years ago
Danilo Aimini a641586df2 Move FocusModeInterface retrieval to EntityOutlinerListModel constructor to prevent crash on widget refresh. Also force expansion of root on construction for the same reason.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
4 years ago
srikappa-amzn 27e93e3af7 Merge branch 'development' into Prefab/DestroyGameEntitySupport
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
4 years ago
srikappa-amzn 9078d1925a Mock newly added methods to SpawnableEntitiesInterface
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
4 years ago