diff --git a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactClientFailureReport.h b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactClientFailureReport.h index e5cadcbbd2..d2ab863d86 100644 --- a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactClientFailureReport.h +++ b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactClientFailureReport.h @@ -116,7 +116,7 @@ namespace TestImpact SequenceFailure( AZStd::vector&& executionFailures, AZStd::vector&& launcherFailures, - AZStd::vector&& unexecutionTests); + AZStd::vector&& unexecutedTests); //! Returns the test targets in this sequence that failed to execute. const AZStd::vector& GetExecutionFailures() const; @@ -130,7 +130,7 @@ namespace TestImpact private: AZStd::vector m_executionFailures; AZStd::vector m_launcherFailures; - AZStd::vector m_unexecutionTests; + AZStd::vector m_unexecutedTestsTests; }; //! Represents the report for a failed regular test sequence run without test impact analysis. @@ -142,7 +142,7 @@ namespace TestImpact AZStd::vector&& executionFailures, AZStd::vector&& launcherFailures, AZStd::vector&& testRunFailures, - AZStd::vector&& unexecutionTests); + AZStd::vector&& unexecutedTests); //! Returns the test targets that contain failing tests. const AZStd::vector& GetTestRunFailures() const; @@ -161,7 +161,7 @@ namespace TestImpact AZStd::vector&& launcherFailures, AZStd::vector&& selectedTestRunFailures, AZStd::vector&& discardedTestRunFailures, - AZStd::vector&& unexecutionTests); + AZStd::vector&& unexecutedTests); //! Returns the test targets that were selected to run but contain failing tests. const AZStd::vector GetSelectedTestRunFailures() const; diff --git a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactConfiguration.h b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactConfiguration.h index 1327ddbdff..3406789c9e 100644 --- a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactConfiguration.h +++ b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactConfiguration.h @@ -48,7 +48,8 @@ namespace TestImpact RelativePaths m_relativePaths; }; - struct Persistent + //! Active persistent data workspace configuration. + struct Active { //! Paths relative to root. struct RelativePaths @@ -62,7 +63,7 @@ namespace TestImpact }; Temp m_temp; - Persistent m_persistent; + Active m_active; }; //! Build target descriptor configuration. diff --git a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactRepoPath.h b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactRepoPath.h index e7e0ba685f..ccba3f677d 100644 --- a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactRepoPath.h +++ b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactRepoPath.h @@ -26,7 +26,7 @@ namespace TestImpact public: constexpr RepoPath() = default; constexpr RepoPath(const RepoPath&) = default; - constexpr RepoPath(RepoPath&&) = default; + constexpr RepoPath(RepoPath&&) noexcept = default; constexpr RepoPath(const string_type&) noexcept; constexpr RepoPath(const value_type*) noexcept; constexpr RepoPath(const AZ::IO::PathView&); diff --git a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactRuntime.h b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactRuntime.h index a42da8dc38..8221eba834 100644 --- a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactRuntime.h +++ b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactRuntime.h @@ -73,7 +73,7 @@ namespace TestImpact //! @param duration The total duration of this test sequence. using ImpactAnalysisTestSequenceCompleteCallback = AZStd::function; - //! Callback for test runs that have completed for any reason + //! Callback for test runs that have completed for any reason. //! test The test that has completed. using TestCompleteCallback = AZStd::function; @@ -106,7 +106,7 @@ namespace TestImpact //! @param testTargetTimeout The maximum duration the entire test sequence may run for (infinite if empty). //! @param testSequenceStartCallback The client function to be called after the test targets have been selected but prior to running the tests. //! @param testSequenceCompleteCallback The client function to be called after the test sequence has completed. - //! @param testRunCompleteCallback The client function to be called after an individual test run has compelted. + //! @param testRunCompleteCallback The client function to be called after an individual test run has completed. TestSequenceResult RegularTestSequence( const AZStd::unordered_set suitesFilter, AZStd::optional testTargetTimeout, @@ -122,7 +122,7 @@ namespace TestImpact //! @param testTargetTimeout The maximum duration the entire test sequence may run for (infinite if empty). //! @param testSequenceStartCallback The client function to be called after the test targets have been selected but prior to running the tests. //! @param testSequenceCompleteCallback The client function to be called after the test sequence has completed. - //! @param testRunCompleteCallback The client function to be called after an individual test run has compelted. + //! @param testRunCompleteCallback The client function to be called after an individual test run has completed. TestSequenceResult ImpactAnalysisTestSequence( const ChangeList& changeList, Policy::TestPrioritization testPrioritizationPolicy, @@ -140,7 +140,7 @@ namespace TestImpact //! @param testTargetTimeout The maximum duration the entire test sequence may run for (infinite if empty). //! @param testSequenceStartCallback The client function to be called after the test targets have been selected but prior to running the tests. //! @param testSequenceCompleteCallback The client function to be called after the test sequence has completed. - //! @param testRunCompleteCallback The client function to be called after an individual test run has compelted. + //! @param testRunCompleteCallback The client function to be called after an individual test run has completed. TestSequenceResult SafeImpactAnalysisTestSequence( const ChangeList& changeList, const AZStd::unordered_set suitesFilter, @@ -155,7 +155,7 @@ namespace TestImpact //! @param testTargetTimeout The maximum duration the entire test sequence may run for (infinite if empty). //! @param testSequenceStartCallback The client function to be called after the test targets have been selected but prior to running the tests. //! @param testSequenceCompleteCallback The client function to be called after the test sequence has completed. - //! @param testRunCompleteCallback The client function to be called after an individual test run has compelted. + //! @param testRunCompleteCallback The client function to be called after an individual test run has completed. TestSequenceResult SeededTestSequence( AZStd::optional globalTimeout, AZStd::optional testSequenceStartCallback, @@ -173,7 +173,7 @@ namespace TestImpact Policy::IntegrityFailure m_integrationFailurePolicy; Policy::TestSharding m_testShardingPolicy; TargetOutputCapture m_targetOutputCapture; - size_t m_maxConcurrency; + size_t m_maxConcurrency = 0; AZStd::unique_ptr m_dynamicDependencyMap; AZStd::unique_ptr m_testEngine; AZStd::unordered_set m_testTargetExcludeList; diff --git a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactTestSequence.h b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactTestSequence.h index 8b1b54e7f4..751db43987 100644 --- a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactTestSequence.h +++ b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactTestSequence.h @@ -85,8 +85,8 @@ namespace TestImpact //! Result of a test sequence that was run. enum class TestSequenceResult { - Success, //! All tests ran with no failures. - Failure, //! One or more tests failed and/or timed out and/or failed to launch (if execution failure policy is not Ignore) and/or an integrity failure was encountered. - Timeout //! The global timeout for the sequence was exceeded. + Success, //!< All tests ran with no failures. + Failure, //!< One or more tests failed and/or timed out and/or failed to launch and/or an integrity failure was encountered. + Timeout //!< The global timeout for the sequence was exceeded. }; } // namespace TestImpact diff --git a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactUtils.h b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactUtils.h index 8580582a12..d734d7a70e 100644 --- a/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactUtils.h +++ b/Code/Tools/TestImpactFramework/Runtime/Code/Include/TestImpactFramework/TestImpactUtils.h @@ -56,8 +56,7 @@ namespace TestImpact ExceptionType, AZStd::string::format("Couldn't open file %s for writing", path.c_str())); - AZ_TestImpact_Eval(file.Write(bytes.data(), bytes.size()), ExceptionType, AZStd::string::format("Couldn't write contents for file %s", path.c_str())); - - return; + AZ_TestImpact_Eval( + file.Write(bytes.data(), bytes.size()), ExceptionType, AZStd::string::format("Couldn't write contents for file %s", path.c_str())); } } // namespace TestImpact