Modifying a copy to not overrun if the target is smaller than the size of the default value array (#5186)

Signed-off-by: Tommy Walton <waltont@amazon.com>
2021-11-02 13:42:20 -07:00
parent fab0326188
commit f8aa265253
1 changed files with 6 additions and 3 deletions
@@ -85,10 +85,13 @@ namespace EMotionFX

            if (numLODs != m_lodSampleRates.size())
            {
-                // Generate the default LOD Sample Rate to 140, 60, 45, 25, 15, 10
+                // Generate the default LOD Sample Rate to 140, 60, 45, 25, 15, 10, 10, 10, ...
                constexpr AZStd::array defaultSampleRate {140.0f, 60.0f, 45.0f, 25.0f, 15.0f, 10.0f};
-                m_lodSampleRates.resize(numLODs);
-                AZStd::copy(begin(defaultSampleRate), end(defaultSampleRate), begin(m_lodSampleRates));
+                m_lodSampleRates.resize(numLODs, 10.0f);
+
+                // Do not copy more than what fits in defaultSampleRates or numLODs. 
+                size_t copyCount = std::min(defaultSampleRate.size(), numLODs);
+                AZStd::copy(begin(defaultSampleRate), begin(defaultSampleRate) + copyCount, begin(m_lodSampleRates));
            }
        }