From f61c37786f0733e31f722e1655cfcbb1d036b498 Mon Sep 17 00:00:00 2001 From: evanchia Date: Thu, 21 Oct 2021 16:40:48 -0700 Subject: [PATCH] fixing unit test with local time issue Signed-off-by: evanchia --- .../tests/unit/test_editor_test_utils.py | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/Tools/LyTestTools/tests/unit/test_editor_test_utils.py b/Tools/LyTestTools/tests/unit/test_editor_test_utils.py index b096f6d6b0..56000364d1 100644 --- a/Tools/LyTestTools/tests/unit/test_editor_test_utils.py +++ b/Tools/LyTestTools/tests/unit/test_editor_test_utils.py @@ -78,6 +78,22 @@ class TestEditorTestUtils(unittest.TestCase): assert expected == editor_test_utils.retrieve_crash_output(0, mock_workspace, 0) + @mock.patch('os.path.getmtime', mock.MagicMock()) + @mock.patch('os.rename') + @mock.patch('time.strftime') + @mock.patch('ly_test_tools.o3de.editor_test_utils.retrieve_log_path') + @mock.patch('os.path.exists') + def test_CycleCrashReport_DmpExists_NamedCorrectly(self, mock_exists, mock_retrieve_log_path, mock_strftime, + mock_rename): + mock_exists.side_effect = [False, True] + mock_retrieve_log_path.return_value = 'mock_log_path' + mock_workspace = mock.MagicMock() + mock_strftime.return_value = 'mock_strftime' + + editor_test_utils.cycle_crash_report(0, mock_workspace) + mock_rename.assert_called_once_with(os.path.join('mock_log_path', 'error.dmp'), + os.path.join('mock_log_path', 'error_mock_strftime.dmp')) + @mock.patch('os.rename') @mock.patch('os.path.getmtime') @mock.patch('ly_test_tools.o3de.editor_test_utils.retrieve_log_path') @@ -93,21 +109,6 @@ class TestEditorTestUtils(unittest.TestCase): mock_rename.assert_called_once_with(os.path.join('mock_log_path', 'error.log'), os.path.join('mock_log_path', 'error_1969_12_31_16_00_01.log')) - @mock.patch('os.rename') - @mock.patch('os.path.getmtime') - @mock.patch('ly_test_tools.o3de.editor_test_utils.retrieve_log_path') - @mock.patch('os.path.exists') - def test_CycleCrashReport_DmpExists_NamedCorrectly(self, mock_exists, mock_retrieve_log_path, mock_getmtime, - mock_rename): - mock_exists.side_effect = [False, True] - mock_retrieve_log_path.return_value = 'mock_log_path' - mock_workspace = mock.MagicMock() - mock_getmtime.return_value = 1 - - editor_test_utils.cycle_crash_report(0, mock_workspace) - mock_rename.assert_called_once_with(os.path.join('mock_log_path', 'error.dmp'), - os.path.join('mock_log_path', 'error_1969_12_31_16_00_01.dmp')) - @mock.patch('ly_test_tools.o3de.editor_test_utils.retrieve_log_path') @mock.patch('ly_test_tools.environment.waiter.wait_for', mock.MagicMock()) def test_RetrieveEditorLogContent_CrashLogExists_ReturnsLogInfo(self, mock_retrieve_log_path):