birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PR comments/observations

Browse Source 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
This commit is contained in:
Esteban Papp
2021-08-16 16:46:48 -07:00
parent f22d2d736b
commit f0fa62bde3
2 changed files with 1 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Code/Framework/AzFramework/AzFramework/Physics/Common/PhysicsTypes.h
+1 -1
View File
@@ -56,7 +56,7 @@ namespace AzPhysics
//! A handle to a Scene within the physics simulation.
//! A SceneHandle is a tuple of a Crc of the scenes name and the index in the Scene list.
using SceneHandle = AZStd::tuple<AZ::Crc32, SceneIndex>;
static constexpr SceneHandle InvalidSceneHandle = { AZ::Crc32(), AZ::s8(-1) };
static constexpr SceneHandle InvalidSceneHandle = { AZ::Crc32(), SceneIndex(-1) };
//! Ease of use type for referencing a List of SceneHandle objects.
using SceneHandleList = AZStd::vector<SceneHandle>;
Gems/LyShine/Code/Editor/Animation/UiAnimViewNodes.cpp
-72
View File
@@ -99,84 +99,12 @@ protected:
{
// For now we do not support any drag and drop in the Nodes pane
return;
//CUiAnimViewNodesCtrl::CRecord* pRecord = (CUiAnimViewNodesCtrl::CRecord*) itemAt(event->pos());
//if (!pRecord)
//{
// return;
//}
//CUiAnimViewNode* pTargetNode = pRecord->GetNode();
//
//QTreeWidget::dragMoveEvent(event);
//if (!event->isAccepted())
//{
// return;
//}
//
//if (pTargetNode && pTargetNode->IsGroupNode() /*&& !m_draggedNodes.DoesContain(pTargetNode)*/)
//{
// CUiAnimViewAnimNode* pDragTarget = static_cast<CUiAnimViewAnimNode*>(pTargetNode);
// bool bAllValidReparenting = true;
// QList<CUiAnimViewAnimNode*> nodes = draggedNodes(event);
// Q_FOREACH(CUiAnimViewAnimNode * pDraggedNode, nodes)
// {
// if (!pDraggedNode->IsValidReparentingTo(pDragTarget))
// {
// bAllValidReparenting = false;
// break;
// }
// }
//
// if (!bAllValidReparenting)
// {
// event->ignore();
// }
//
// return;
//}
}
void dropEvent([[maybe_unused]] QDropEvent* event)
{
// For now we do not support any drag and drop in the Nodes pane
return;
//CUiAnimViewNodesCtrl::CRecord* pRecord = (CUiAnimViewNodesCtrl::CRecord*) itemAt(event->pos());
//if (!pRecord)
//{
// return;
//}
//CUiAnimViewNode* pTargetNode = pRecord->GetNode();
//
//QTreeWidget::dropEvent(event);
//if (!event->isAccepted())
//{
// return;
//}
//
//if (pTargetNode && pTargetNode->IsGroupNode() /*&& !m_draggedNodes.DoesContain(pTargetNode)*/)
//{
// CUiAnimViewAnimNode* pDragTarget = static_cast<CUiAnimViewAnimNode*>(pTargetNode);
// bool bAllValidReparenting = true;
// QList<CUiAnimViewAnimNode*> nodes = draggedNodes(event);
// Q_FOREACH(CUiAnimViewAnimNode * pDraggedNode, nodes)
// {
// if (!pDraggedNode->IsValidReparentingTo(pDragTarget))
// {
// bAllValidReparenting = false;
// break;
// }
// }
//
// if (bAllValidReparenting)
// {
// UiAnimUndo undo("Drag and Drop UiAnimView Nodes");
// Q_FOREACH(CUiAnimViewAnimNode * pDraggedNode, nodes)
// {
// pDraggedNode->SetNewParent(pDragTarget);
// }
// }
//}
}
void keyPressEvent(QKeyEvent* event)