From ed053180590eb59895b110b85bfc7506b49844b7 Mon Sep 17 00:00:00 2001 From: lsemp3d <58790905+lsemp3d@users.noreply.github.com> Date: Mon, 15 Nov 2021 10:29:45 -0800 Subject: [PATCH] Fixed fallback name for EBus methods, improved more names Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com> --- .../EBus/Handlers/CameraNotificationBus.names | 9 +++++---- .../EBus/Senders/BlastFamilyComponentRequestBus.names | 2 +- Gems/ScriptCanvas/Code/Editor/Nodes/NodeDisplayUtils.cpp | 4 +++- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Handlers/CameraNotificationBus.names b/Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Handlers/CameraNotificationBus.names index 033836c2cb..aeecd598c3 100644 --- a/Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Handlers/CameraNotificationBus.names +++ b/Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Handlers/CameraNotificationBus.names @@ -5,13 +5,14 @@ "context": "EBusHandler", "variant": "", "details": { - "name": "CameraNotificationBus" + "name": "Camera", + "category": "Camera" }, "methods": [ { "key": "OnCameraAdded", "details": { - "name": "OnCameraAdded" + "name": "On Camera Added" }, "params": [ { @@ -26,7 +27,7 @@ { "key": "OnCameraRemoved", "details": { - "name": "OnCameraRemoved" + "name": "On Camera Removed" }, "params": [ { @@ -41,7 +42,7 @@ { "key": "OnActiveViewChanged", "details": { - "name": "OnActiveViewChanged" + "name": "On Active View Changed" }, "params": [ { diff --git a/Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Senders/BlastFamilyComponentRequestBus.names b/Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Senders/BlastFamilyComponentRequestBus.names index 3b5aecdb16..f4c2192375 100644 --- a/Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Senders/BlastFamilyComponentRequestBus.names +++ b/Gems/ScriptCanvas/Assets/TranslationAssets/EBus/Senders/BlastFamilyComponentRequestBus.names @@ -9,7 +9,7 @@ }, "methods": [ { - "key": "GetActorsData", + "key": "Get Actors Data", "entry": { "name": "In", "tooltip": "When signaled, this will invoke Get Actors Data" diff --git a/Gems/ScriptCanvas/Code/Editor/Nodes/NodeDisplayUtils.cpp b/Gems/ScriptCanvas/Code/Editor/Nodes/NodeDisplayUtils.cpp index c8122711eb..de7dc02530 100644 --- a/Gems/ScriptCanvas/Code/Editor/Nodes/NodeDisplayUtils.cpp +++ b/Gems/ScriptCanvas/Code/Editor/Nodes/NodeDisplayUtils.cpp @@ -330,9 +330,11 @@ namespace ScriptCanvasEditor::Nodes // Get the method's text data GraphCanvas::TranslationRequests::Details methodDetails; + methodDetails.m_name = details.m_name; // fallback key << "methods" << methodName; GraphCanvas::TranslationRequestBus::BroadcastResult(methodDetails, &GraphCanvas::TranslationRequests::GetDetails, key + ".details", methodDetails); + if (methodDetails.m_subtitle.empty()) { methodDetails.m_subtitle = details.m_name; @@ -390,7 +392,7 @@ namespace ScriptCanvasEditor::Nodes } if (slot.IsData()) - { + { index++; } }