Fixed the other call to CreateVariable (#5561)

in favor of CreateVariableEx Signed-off-by: galibzon <66021303+galibzon@users.noreply.github.com>
2021-11-11 16:04:22 -06:00
parent 0b211d3743
commit e0d736dd84
1 changed files with 6 additions and 1 deletions
@@ -32,7 +32,12 @@ namespace AZ

        if (!s_instance)
        {
-            s_instance = AZ::Environment::CreateVariable<NameDictionary>(NameDictionaryInstanceName);
+            // Because the NameDictionary allocates memory using the AZ::Allocator and it is created
+            // in the executable memory space, it's ownership cannot be transferred to other module memory spaces
+            // Otherwise this could cause the the NameDictionary to be destroyed in static de-init
+            // after the AZ::Allocators have been destroyed
+            // Therefore we supply the isTransferOwnership value of false using CreateVariableEx
+            s_instance = AZ::Environment::CreateVariableEx<NameDictionary>(NameDictionaryInstanceName, true, false);
        }
    }