Atom

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

Gems/Atom/Asset/ImageProcessingAtom/Code/Source/Processing/PixelFormatInfo.h

@@ -82,7 +82,7 @@ namespace ImageProcessingAtom
             }
             else                        // The value is zero
             {
-                Exponent = -112;
+                Exponent = static_cast<AZ::u32>(-112);
             }
 
             Result = ((h & 0x8000) << 16) | // Sign

Gems/Atom/Asset/Shader/Code/Source/Editor/CommonFiles/CommonTypes.h

@@ -278,7 +278,7 @@ namespace AZ
         {
             AZ::Name        m_nameId;
             uint32_t        m_sizeInBytes = 0;
-            uint32_t        m_space = -1;
+            uint32_t        m_space = std::numeric_limits<uint32_t>::max();
             uint32_t        m_registerId = RHI::UndefinedRegisterSlot;
         };
     } // ShaderBuilder

Gems/Atom/Feature/Common/Code/Include/Atom/Feature/CoreLights/DiskLightFeatureProcessorInterface.h

@@ -38,7 +38,7 @@ namespace AZ
             float m_cosInnerConeAngle = 0.0f; // cosine of inner cone angle
             float m_cosOuterConeAngle = 0.0f; // cosine of outer cone angle
             float m_bulbPositionOffset = 0.0f; // Distance from the light disk surface to the tip of the cone of the light. m_bulbRadius * tanf(pi/2 - m_outerConeAngle).
-            uint16_t m_shadowIndex = -1; // index for ProjectedShadowData. A value of 0xFFFF indicates an illegal index.
+            uint16_t m_shadowIndex = std::numeric_limits<uint16_t>::max(); // index for ProjectedShadowData. A value of 0xFFFF indicates an illegal index.
             uint16_t m_padding; // Explicit padding.
         };
 

Gems/Atom/Feature/Common/Code/Include/Atom/Feature/Material/MaterialAssignmentId.h

@@ -64,7 +64,7 @@ namespace AZ
             bool operator==(const MaterialAssignmentId& rhs) const;
             bool operator!=(const MaterialAssignmentId& rhs) const;
 
-            static constexpr MaterialAssignmentLodIndex NonLodIndex = -1;
+            static constexpr MaterialAssignmentLodIndex NonLodIndex = std::numeric_limits<MaterialAssignmentLodIndex>::max();
 
             MaterialAssignmentLodIndex m_lodIndex = NonLodIndex;
             RPI::ModelMaterialSlot::StableId m_materialSlotStableId = RPI::ModelMaterialSlot::InvalidStableId;

Gems/Atom/Feature/Common/Code/Include/Atom/Feature/TransformService/TransformServiceFeatureProcessor.h

@@ -61,7 +61,7 @@ namespace AZ
             };
 
             // Flag value for when the buffers have no empty spaces.
-            static const uint32_t NoAvailableTransformIndices = -1;
+            static const uint32_t NoAvailableTransformIndices = std::numeric_limits<uint32_t>::max();
 
             TransformServiceFeatureProcessor(const TransformServiceFeatureProcessor&) = delete;
 

Gems/Atom/Feature/Common/Code/Include/Atom/Feature/Utils/MultiSparseVector.h

@@ -49,7 +49,7 @@ namespace AZ::Render
 
     private:
 
-        static constexpr size_t NoFreeSlot = -1;
+        static constexpr size_t NoFreeSlot = std::numeric_limits<size_t>::max();
         static constexpr size_t InitialReservedCount = 128;
         
         using Fn = void(&)(AZStd::vector<Ts>& ...);
@@ -103,7 +103,7 @@ namespace AZ::Render
     template<typename ... Ts>
     inline size_t MultiSparseVector<Ts...>::Reserve()
     {
-        size_t slotToReturn = -1;
+        size_t slotToReturn = std::numeric_limits<size_t>::max();
         if (m_nextFreeSlot != NoFreeSlot)
         {
             // If there's a free slot, then use that space and update the linked list of free slots.

Gems/Atom/Feature/Common/Code/Include/Atom/Feature/Utils/SparseVector.h

@@ -49,7 +49,7 @@ namespace AZ::Render
 
     private:
 
-        static constexpr size_t NoFreeSlot = -1;
+        static constexpr size_t NoFreeSlot = std::numeric_limits<size_t>::max();
         static constexpr size_t InitialReservedCount = 128;
 
         size_t m_nextFreeSlot = NoFreeSlot;
@@ -66,7 +66,7 @@ namespace AZ::Render
     template<typename T>
     inline size_t SparseVector<T>::Reserve()
     {
-        size_t slotToReturn = -1;
+        size_t slotToReturn = std::numeric_limits<size_t>::max();
         if (m_nextFreeSlot != NoFreeSlot)
         {
             // If there's a free slot, then use that space and update the linked list of free slots.

Gems/Atom/Feature/Common/Code/Source/CoreLights/LightCullingPass.cpp

@@ -159,7 +159,7 @@ namespace AZ
 
         void LightCullingPass::ResetInternal()
         {
-            m_tileDataIndex = -1;
+            m_tileDataIndex = std::numeric_limits<uint32_t>::max();
             m_constantDataIndex.Reset();
 
             for (auto& elem : m_lightdata)
@@ -234,7 +234,7 @@ namespace AZ
                     return i;
                 }
             }
-            return -1;
+            return std::numeric_limits<uint32_t>::max();
         }
 
         AZ::RHI::Size LightCullingPass::GetTileDataBufferResolution()

Gems/Atom/Feature/Common/Code/Source/CoreLights/LightCullingPass.h

@@ -94,7 +94,7 @@ namespace AZ
 
             Data::Instance<RPI::Buffer> m_lightList;
 
-            uint32_t m_tileDataIndex = -1;
+            uint32_t m_tileDataIndex = std::numeric_limits<uint32_t>::max();
         };
     }   // namespace Render
 }   // namespace AZ

Gems/Atom/Feature/Common/Code/Source/CoreLights/LightCullingRemap.cpp

@@ -101,7 +101,7 @@ namespace AZ
                     return i;
                 }
             }
-            return -1;
+            return std::numeric_limits<uint32_t>::max();
         }
 
         void LightCullingRemap::BuildInternal()

Gems/Atom/Feature/Common/Code/Source/CoreLights/ProjectedShadowmapsPass.h

@@ -30,7 +30,7 @@ namespace AZ
             AZ_CLASS_ALLOCATOR(ProjectedShadowmapsPass, SystemAllocator, 0);
             AZ_RTTI(ProjectedShadowmapsPass, "00024B13-1095-40FA-BEC3-B0F68110BEA2", Base);
 
-            static constexpr uint16_t InvalidIndex = ~0;
+            static constexpr uint16_t InvalidIndex = std::numeric_limits<uint16_t>::max();
             struct ShadowmapSizeWithIndices
             {
                 ShadowmapSize m_size = ShadowmapSize::None;

Gems/Atom/Feature/Common/Code/Source/CoreLights/ShadowmapAtlas.h

@@ -52,7 +52,7 @@ namespace AZ
                 // then m_nextTableOffset == 0, which works as the terminator for seaching
                 // a shadowmap index in a compute shader.
                 uint32_t m_nextTableOffset = 0;
-                uint32_t m_shadowmapIndex = ~0; // invalid index
+                uint32_t m_shadowmapIndex = std::numeric_limits<uint32_t>::max(); // invalid index
             };
 
             //! This initializes the packing of shadowmap sizes.
@@ -156,7 +156,7 @@ namespace AZ
             //!  [2,2,2] indicates (0, 1024+512)-(0+511, 1024+512+511) of slice:2 (width 512).
             using Location = AZStd::vector<uint8_t>;
             static constexpr uint8_t LocationIndexNum = 4;
-            static constexpr size_t InvalidIndex = ~0;
+            static constexpr size_t InvalidIndex = std::numeric_limits<size_t>::max();
 
             struct LocationHasher
             {

Gems/Atom/RHI/Code/Include/Atom/RHI.Edit/ShaderPlatformInterface.h

@@ -81,7 +81,7 @@ namespace AZ
             struct ByProducts
             {
                 AZStd::set<AZStd::string> m_intermediatePaths;  //!< intermediate file paths (like dxil text form)
-                static constexpr uint32_t UnknownDynamicBranchCount = -1;
+                static constexpr uint32_t UnknownDynamicBranchCount = std::numeric_limits<uint32_t>::max();
                 uint32_t m_dynamicBranchCount = UnknownDynamicBranchCount;
             };
 

Gems/Atom/RHI/Code/Include/Atom/RHI/AliasedAttachmentAllocator.h

@@ -248,7 +248,7 @@ namespace AZ
             // The no allocation heap is used when doing a 2 pass strategy.
             Internal::NoAllocationAliasedHeap::Descriptor heapAllocator;
             heapAllocator.m_alignment = descriptor.m_alignment;
-            heapAllocator.m_budgetInBytes = ~0;
+            heapAllocator.m_budgetInBytes = std::numeric_limits<AZ::u64>::max();
             m_noAllocationHeap.Init(device, heapAllocator);
 
             typename decltype(m_garbageCollector)::Descriptor collectorDescriptor;

Gems/Atom/RHI/DX12/Code/Source/RHI/Conversions.cpp

@@ -353,7 +353,7 @@ namespace AZ
 
                 if (imageViewDescriptor.m_depthSliceMax == RHI::ImageViewDescriptor::HighestSliceIndex)
                 {
-                    renderTargetView.Texture3D.WSize = -1;
+                    renderTargetView.Texture3D.WSize = std::numeric_limits<UINT>::max();
                 }
                 else
                 {
@@ -578,7 +578,7 @@ namespace AZ
 
                 if (imageViewDescriptor.m_depthSliceMax == RHI::ImageViewDescriptor::HighestSliceIndex)
                 {
-                    unorderedAccessView.Texture3D.WSize = -1;
+                    unorderedAccessView.Texture3D.WSize = std::numeric_limits<UINT>::max();
                 }
                 else
                 {

Gems/Atom/RHI/Vulkan/Code/Source/RHI/CommandQueueContext.cpp

@@ -304,7 +304,7 @@ namespace AZ
             {
                 uint32_t m_familyIndex = InvalidFamilyIndex;
                 bool m_newQueue = false;
-                uint32_t m_remainingFlags = ~0;
+                uint32_t m_remainingFlags = std::numeric_limits<uint32_t>::max();
 
                 bool operator>(const QueueSelection& other) const
                 {

Gems/Atom/RHI/Vulkan/Code/Source/RHI/Device.cpp

@@ -69,7 +69,7 @@ namespace AZ
 
             BuildDeviceQueueInfo(physicalDevice);
 
-            m_supportedPipelineStageFlagsMask = ~0;
+            m_supportedPipelineStageFlagsMask = std::numeric_limits<VkPipelineStageFlags>::max();
 
             const auto& deviceFeatures = physicalDevice.GetPhysicalDeviceFeatures();
             m_enabledDeviceFeatures.samplerAnisotropy = deviceFeatures.samplerAnisotropy;

Gems/Atom/RHI/Vulkan/Code/Source/RHI/Device.h

@@ -152,7 +152,7 @@ namespace AZ
 
             VkDevice m_nativeDevice = VK_NULL_HANDLE;
             VkPhysicalDeviceFeatures m_enabledDeviceFeatures{};
-            VkPipelineStageFlags m_supportedPipelineStageFlagsMask = ~0;
+            VkPipelineStageFlags m_supportedPipelineStageFlagsMask = std::numeric_limits<VkPipelineStageFlags>::max();
 
             AZStd::vector<VkQueueFamilyProperties> m_queueFamilyProperties;
             RHI::Ptr<AsyncUploadQueue> m_asyncUploadQueue;

Gems/Atom/RHI/Vulkan/Code/Source/RHI/MergedShaderResourceGroup.h

@@ -53,7 +53,7 @@ namespace AZ
             // Helper struct for easy initialization of the frame iteration.
             struct FrameIteration
             {
-                uint64_t m_frameIteration = ~0;
+                uint64_t m_frameIteration = std::numeric_limits<uint64_t>::max();
             };
 
             // Utility function that merges multiple ShaderResoruceGroup data into one.

Gems/Atom/RPI/Code/Include/Atom/RPI.Reflect/Material/MaterialPropertyDescriptor.h

@@ -103,7 +103,7 @@ namespace AZ
             AZ::TypeId GetStorageDataTypeId() const;
 
             //! Returns the value of the enum from its name. If this property is not an enum or the name is undefined, InvalidEnumValue is returned.
-            static constexpr uint32_t InvalidEnumValue = -1;
+            static constexpr uint32_t InvalidEnumValue = std::numeric_limits<uint32_t>::max();
             uint32_t GetEnumValue(const AZ::Name& enumName) const;
 
             //! Returns the unique name ID of this property

Gems/Atom/RPI/Code/Include/Atom/RPI.Reflect/Shader/ShaderVariantTreeAsset.h

@@ -75,7 +75,7 @@ namespace AZ
 
         private:
 
-            static constexpr uint32_t UnspecifiedIndex = -1;
+            static constexpr uint32_t UnspecifiedIndex = std::numeric_limits<uint32_t>::max();
 
             //! Returns the node associated with the provided index.
             const ShaderVariantTreeNode& GetNode(uint32_t index) const;

Gems/Atom/Utils/Code/Include/Atom/Utils/StableDynamicArray.h

@@ -130,7 +130,7 @@ namespace AZ
     template<typename T, size_t ElementsPerPage, class Allocator>
     struct StableDynamicArray<T, ElementsPerPage, Allocator>::Page
     {
-        static constexpr size_t InvalidPage = -1;
+        static constexpr size_t InvalidPage = std::numeric_limits<size_t>::max();
         static constexpr uint64_t FullBits = 0xFFFFFFFFFFFFFFFFull;
         static constexpr size_t NumUint64_t = ElementsPerPage / 64;