birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch stabilization/2110 into development

Browse Source 
Signed-off-by: Chris Burel <burelc@amazon.com>
This commit is contained in:
Chris Burel
2021-11-04 13:44:22 -07:00
parent 5a0b5f9f8b 4721ef8298
commit d942c90c56
118 changed files with 285 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/o3de/o3de/gem_properties.py
+12
View File
@@ -54,6 +54,8 @@ def edit_gem_props(gem_path: pathlib.Path = None,
new_icon: str = None,
new_requirements: str = None,
new_documentation_url: str = None,
new_license: str = None,
new_license_url: str = None,
new_tags: list or str = None,
remove_tags: list or str = None,
replace_tags: list or str = None,
@@ -94,6 +96,10 @@ def edit_gem_props(gem_path: pathlib.Path = None,
update_key_dict['requirements'] = new_requirements
if new_documentation_url:
update_key_dict['documentation_url'] = new_documentation_url
if new_license:
update_key_dict['license'] = new_license
if new_license_url:
update_key_dict['license_url'] = new_license_url
update_key_dict['user_tags'] = update_values_in_key_list(gem_json_data.get('user_tags', []), new_tags,
remove_tags, replace_tags)
@@ -114,6 +120,8 @@ def _edit_gem_props(args: argparse) -> int:
args.gem_icon,
args.gem_requirements,
args.gem_documentation_url,
args.gem_license,
args.gem_license_url,
args.add_tags,
args.remove_tags,
args.replace_tags)
@@ -142,6 +150,10 @@ def add_parser_args(parser):
help='Sets the description of the requirements needed to use the gem.')
group.add_argument('-gdu', '--gem-documentation-url', type=str, required=False,
help='Sets the url for documentation of the gem.')
group.add_argument('-gl', '--gem-license', type=str, required=False,
help='Sets the name for the license of the gem.')
group.add_argument('-glu', '--gem-license-url', type=str, required=False,
help='Sets the url for the license of the gem.')
group = parser.add_mutually_exclusive_group(required=False)
group.add_argument('-at', '--add-tags', type=str, nargs='*', required=False,
help='Adds tag(s) to user_tags property. Can be specified multiple times.')
scripts/o3de/tests/unit_test_gem_properties.py
+19 -9
View File
@@ -18,7 +18,8 @@ TEST_GEM_JSON_PAYLOAD = '''
{
"gem_name": "TestGem",
"display_name": "TestGem",
"license": "What license TestGem uses goes here: i.e. https://opensource.org/licenses/MIT",
"license": "MIT",
"license_url": "https://opensource.org/licenses/MIT",
"origin": "The primary repo for TestGem goes here: i.e. http://www.mydomain.com",
"type": "Code",
"summary": "A short description of TestGem.",
@@ -46,26 +47,30 @@ def init_gem_json_data(request):
class TestEditGemProperties:
@pytest.mark.parametrize("gem_path, gem_name, gem_new_name, gem_display, gem_origin,\
gem_type, gem_summary, gem_icon, gem_requirements, gem_documentation_url,\
add_tags, remove_tags, replace_tags, expected_tags, expected_result", [
gem_license, gem_license_url, add_tags, remove_tags, replace_tags,\
expected_tags, expected_result", [
pytest.param(pathlib.PurePath('D:/TestProject'),
None, 'TestGem2', 'New Gem Name', 'O3DE', 'Code', 'Gem that exercises Default Gem Template',
'new_preview.png', 'Do this extra thing', 'https://o3de.org/docs/user-guide/gems/',
'Apache 2.0', 'https://www.apache.org/licenses/LICENSE-2.0',
['Physics', 'Rendering', 'Scripting'], None, None, ['TestGem', 'Physics', 'Rendering', 'Scripting'],
0),
pytest.param(None,
'TestGem2', None, 'New Gem Name', 'O3DE', 'Asset', 'Gem that exercises Default Gem Template',
'new_preview.png', 'Do this extra thing', 'https://o3de.org/docs/user-guide/gems/', None,
['Physics'], None, ['TestGem', 'Rendering', 'Scripting'], 0),
'new_preview.png', 'Do this extra thing', 'https://o3de.org/docs/user-guide/gems/',
'Apache 2.0', 'https://www.apache.org/licenses/LICENSE-2.0',
None, ['Physics'], None, ['TestGem', 'Rendering', 'Scripting'], 0),
pytest.param(None,
'TestGem2', None, 'New Gem Name', 'O3DE', 'Tool', 'Gem that exercises Default Gem Template',
'new_preview.png', 'Do this extra thing', 'https://o3de.org/docs/user-guide/gems/', None,
None, ['Animation', 'TestGem'], ['Animation', 'TestGem'], 0)
'new_preview.png', 'Do this extra thing', 'https://o3de.org/docs/user-guide/gems/',
'Apache 2.0', 'https://www.apache.org/licenses/LICENSE-2.0',
None, None, ['Animation', 'TestGem'], ['Animation', 'TestGem'], 0)
]
)
def test_edit_gem_properties(self, gem_path, gem_name, gem_new_name, gem_display, gem_origin,
gem_type, gem_summary, gem_icon, gem_requirements,
gem_documentation_url, add_tags, remove_tags, replace_tags,
expected_tags, expected_result):
gem_documentation_url, gem_license, gem_license_url, add_tags, remove_tags,
replace_tags, expected_tags, expected_result):
def get_gem_json_data(gem_path: pathlib.Path) -> dict:
return self.gem_json.data
@@ -82,7 +87,8 @@ class TestEditGemProperties:
patch('o3de.manifest.get_registered', side_effect=get_gem_path) as get_registered_patch:
result = gem_properties.edit_gem_props(gem_path, gem_name, gem_new_name, gem_display, gem_origin,
gem_type, gem_summary, gem_icon, gem_requirements,
gem_documentation_url, add_tags, remove_tags, replace_tags)
gem_documentation_url, gem_license, gem_license_url,
add_tags, remove_tags, replace_tags)
assert result == expected_result
if gem_new_name:
assert self.gem_json.data.get('gem_name', '') == gem_new_name
@@ -100,5 +106,9 @@ class TestEditGemProperties:
assert self.gem_json.data.get('requirements', '') == gem_requirements
if gem_documentation_url:
assert self.gem_json.data.get('documentation_url', '') == gem_documentation_url
if gem_license:
assert self.gem_json.data.get('license', '') == gem_license
if gem_license_url:
assert self.gem_json.data.get('license_url', '') == gem_license_url
assert set(self.gem_json.data.get('user_tags', [])) == set(expected_tags)