LYN-7473: Ensure Requestor background thread is shutdown correctly (#4744)

Signed-off-by: rppotter <rppotter@amazon.com>
This commit is contained in:
Pip Potter
2021-10-18 13:12:20 -07:00
committed by GitHub
parent a534fccc9b
commit d692cde146
3 changed files with 43 additions and 37 deletions
@@ -19,7 +19,7 @@ class HttpTest
{
};
TEST_F(HttpTest, DISABLED_HttpRequesterTest)
TEST_F(HttpTest, HttpRequesterTest)
{
HttpRequestor::Manager httpRequestManager;
@@ -35,17 +35,14 @@ TEST_F(HttpTest, DISABLED_HttpRequesterTest)
requestConditionVar.wait_for(lock, AZStd::chrono::milliseconds(10));
}
httpRequestManager.AddTextRequest(
HttpRequestor::TextParameters("https://httpbin.org/ip",
Aws::Http::HttpMethod::HTTP_GET,
[&resultData, &resultCode, &requestConditionVar](const AZStd::string& data, Aws::Http::HttpResponseCode code)
{
resultData = data;
resultCode = code;
requestConditionVar.notify_all();
}
)
);
httpRequestManager.AddTextRequest(HttpRequestor::TextParameters(
"https://httpbin.org/ip", Aws::Http::HttpMethod::HTTP_GET,
[&resultData, &resultCode, &requestConditionVar](const AZStd::string& data, Aws::Http::HttpResponseCode code)
{
resultData = data;
resultCode = code;
requestConditionVar.notify_all();
}));
{
AZStd::unique_lock<AZStd::mutex> lock(requestMutex);