From 609752b79e6f9a9253fcb23776c73e147c4c7ad5 Mon Sep 17 00:00:00 2001 From: Peng Date: Thu, 17 Jun 2021 14:55:13 -0700 Subject: [PATCH 1/2] ATOM-15808 [RHI][Vulkan] Take out the early memory check exit to let the developers decide what to do if device memory is less than the requirement. JIRA: https://jira.agscollab.com/browse/ATOM-15808 --- Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp b/Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp index e3367b078a..694eac2da4 100644 --- a/Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp +++ b/Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp @@ -64,10 +64,7 @@ namespace AZ physicalDevice->Init(device); size_t gpuMemSize = physicalDevice->GetDescriptor().m_heapSizePerLevel[static_cast(RHI::HeapMemoryLevel::Device)]; AZ_Warning("Vulkan", gpuMemSize >= MinGPUMemSize, "Rejecting GPU %s as it's gpu mem size of %zu bytes is less than min required size of %zu bytes for Vulkan API", physicalDevice->GetDescriptor().m_description.c_str(), gpuMemSize, MinGPUMemSize); - if (gpuMemSize >= MinGPUMemSize) - { - physicalDeviceList.emplace_back(physicalDevice); - } + physicalDeviceList.emplace_back(physicalDevice); } return physicalDeviceList; From 2c7fc4e391f67b1900ca653db554393e494bd182 Mon Sep 17 00:00:00 2001 From: Peng Date: Thu, 17 Jun 2021 17:00:36 -0700 Subject: [PATCH 2/2] take out warning and un-used variable --- Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp b/Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp index 694eac2da4..9fd38aab93 100644 --- a/Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp +++ b/Gems/Atom/RHI/Vulkan/Code/Source/RHI/PhysicalDevice.cpp @@ -62,8 +62,6 @@ namespace AZ { RHI::Ptr physicalDevice = aznew PhysicalDevice; physicalDevice->Init(device); - size_t gpuMemSize = physicalDevice->GetDescriptor().m_heapSizePerLevel[static_cast(RHI::HeapMemoryLevel::Device)]; - AZ_Warning("Vulkan", gpuMemSize >= MinGPUMemSize, "Rejecting GPU %s as it's gpu mem size of %zu bytes is less than min required size of %zu bytes for Vulkan API", physicalDevice->GetDescriptor().m_description.c_str(), gpuMemSize, MinGPUMemSize); physicalDeviceList.emplace_back(physicalDevice); }