fixing material property override lua test script

O3DE vector usage in lua has changed since script was written

Signed-off-by: Guthrie Adams <guthadam@amazon.com>

Gems/Atom/Feature/Common/Assets/Scripts/material_property_overrides_demo.lua

@@ -53,10 +53,9 @@ function PropertyOverrideTest:OnActivate()
     self.originalAssignments = MaterialComponentRequestBus.Event.GetOriginalMaterialAssignments(self.entityId);
     self.assignmentIds = self.originalAssignments:GetKeys()
 
-    for index = 0, self.assignmentIds:Size() do
-        local idOutcome = self.assignmentIds:At(index)
-        if (idOutcome:IsSuccess()) then
-            local id = idOutcome:GetValue()
+    for index = 1, self.assignmentIds:GetSize() do
+        local id = self.assignmentIds[index]
+        if (id ~= nil) then
             self.colors[index] = randomColor()
             self.lerpDirs[index] = randomDir()
         end
@@ -88,10 +87,9 @@ end
 
 function PropertyOverrideTest:UpdateProperties()
     Debug.Log("Overriding properties...")
-    for index = 0, self.assignmentIds:Size() do
-        local idOutcome = self.assignmentIds:At(index)
-        if (idOutcome:IsSuccess()) then
-            local id = idOutcome:GetValue()
+    for index = 1, self.assignmentIds:GetSize() do
+        local id = self.assignmentIds[index]
+        if (id ~= nil) then
             self:UpdateFactor(id)
             self:UpdateTexture(id)
         end
@@ -134,10 +132,9 @@ function lerpColor(color, lerpDir, deltaTime)
 end
 
 function PropertyOverrideTest:lerpColors(deltaTime)
-    for index = 0, self.assignmentIds:Size() do
-        local idOutcome = self.assignmentIds:At(index)
-        if (idOutcome:IsSuccess()) then
-            local id = idOutcome:GetValue()
+    for index = 1, self.assignmentIds:GetSize() do
+        local id = self.assignmentIds[index]
+        if (id ~= nil) then
             lerpColor(self.colors[index], self.lerpDirs[index], deltaTime)
             self:UpdateColor(id, self.colors[index])
         end