Enable warning MSVC 4296: 'operator': expression is always false

Code/Tools/AssetProcessor/native/resourcecompiler/rcjoblistmodel.cpp

@@ -197,11 +197,11 @@ namespace AssetProcessor
 
         m_jobsInFlight.insert(rcJob);
 
-        for(size_t jobIndex = m_jobs.size() - 1; jobIndex >= 0; --jobIndex)
+        for(int jobIndex = static_cast<int>(m_jobs.size()) - 1; jobIndex >= 0; --jobIndex)
         {
             if(m_jobs[jobIndex] == rcJob)
             {
-                Q_EMIT dataChanged(index(aznumeric_caster(jobIndex), 0, QModelIndex()), index(aznumeric_caster(jobIndex), 0, QModelIndex()));
+                Q_EMIT dataChanged(index(jobIndex, 0, QModelIndex()), index(jobIndex, 0, QModelIndex()));
                 return;
             }
         }
@@ -240,7 +240,7 @@ namespace AssetProcessor
             foundInQueue = m_jobsInQueueLookup.erase(foundInQueue);
         }
 
-        for (size_t jobIndex = m_jobs.size() - 1; jobIndex >= 0; --jobIndex)
+        for (int jobIndex = static_cast<int>(m_jobs.size()) - 1; jobIndex >= 0; --jobIndex)
         {
             if(m_jobs[jobIndex] == rcJob)
             {
@@ -251,7 +251,7 @@ namespace AssetProcessor
 #if defined(DEBUG_RCJOB_MODEL)
                     AZ_TracePrintf(AssetProcessor::DebugChannel, "JobTrace =>JobCompleted(%i %s,%s,%s)\n", rcJob, rcJob->GetJobEntry().m_databaseSourceName.toUtf8().constData(), rcJob->GetPlatformInfo().m_identifier.c_str(), rcJob->GetJobKey().toUtf8().constData());
 #endif
-                    beginRemoveRows(QModelIndex(), aznumeric_caster(jobIndex), aznumeric_caster(jobIndex));
+                    beginRemoveRows(QModelIndex(), jobIndex, jobIndex);
                     m_jobs.erase(m_jobs.begin() + jobIndex);
                     endRemoveRows();
 

Code/Tools/AssetProcessor/native/utilities/ByteArrayStream.cpp

@@ -52,7 +52,6 @@ namespace AssetProcessor
         SizeType finalPosition = GenericStream::ComputeSeekPosition(bytes, mode);
 
         AZ_Assert(finalPosition < INT_MAX, "Overflow of SizeType to int in ByteArrayStream.");
-        AZ_Assert(finalPosition >= 0, "underflow in seek in ByteArrayStream");
         AZ_Assert(finalPosition <= m_activeArray->size(), "You cant seek beyond end of file");
 
         // safety clamp!

Code/Tools/AssetProcessor/native/utilities/assetUtils.cpp

@@ -72,11 +72,6 @@ namespace AssetUtilsInternal
 
     bool FileCopyMoveWithTimeout(QString sourceFile, QString outputFile, bool isCopy, unsigned int waitTimeInSeconds)
     {
-        if (waitTimeInSeconds < 0)
-        {
-            AZ_Warning("Asset Processor", waitTimeInSeconds >= 0, "Invalid timeout specified by the user");
-            waitTimeInSeconds = 0;
-        }
         bool failureOccurredOnce = false; // used for logging.
         bool operationSucceeded = false;
         QFile outFile(outputFile);

Code/Tools/Standalone/Source/Driller/AreaChart.cpp

@@ -173,10 +173,7 @@ namespace AreaChart
 
     void AreaChart::ConfigureVerticalAxis(QString label, unsigned int minimumHeight)
     {
-        if (minimumHeight >= 0)
-        {
-            SetMinimumValueRange(minimumHeight);
-        }
+        SetMinimumValueRange(minimumHeight);
 
         if (m_verticalAxis == nullptr)
         {
@@ -323,7 +320,7 @@ namespace AreaChart
                 // Need to handle the areas right at the edge of the polygons
                 for (int i = -1; i <= 1; ++i)
                 {
-                    if ((counter+i) < 0 || (counter + i) >= m_hitAreas.size())
+                    if ((counter + i) >= m_hitAreas.size())
                     {
                         continue;
                     }