From c6d3e7900cdb4971d8927fcf182740c744da870b Mon Sep 17 00:00:00 2001 From: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com> Date: Mon, 25 Oct 2021 15:51:12 -0700 Subject: [PATCH] [profiler_capture_api] updated ProfilerRequests::StartCapture signature as per PR feedback Signed-off-by: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com> --- Code/Framework/AzCore/AzCore/Debug/ProfilerBus.h | 2 +- Gems/Profiler/Code/Source/ProfilerSystemComponent.cpp | 4 ++-- Gems/Profiler/Code/Source/ProfilerSystemComponent.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Code/Framework/AzCore/AzCore/Debug/ProfilerBus.h b/Code/Framework/AzCore/AzCore/Debug/ProfilerBus.h index 31eb0c9160..89c59f01b5 100644 --- a/Code/Framework/AzCore/AzCore/Debug/ProfilerBus.h +++ b/Code/Framework/AzCore/AzCore/Debug/ProfilerBus.h @@ -56,7 +56,7 @@ namespace AZ virtual bool CaptureFrame(const AZStd::string& outputFilePath) = 0; //! Starting/ending a multi-frame capture of profiling data - virtual bool StartCapture(const AZStd::string& outputFilePath) = 0; + virtual bool StartCapture(AZStd::string outputFilePath) = 0; virtual bool EndCapture() = 0; }; using ProfilerRequestBus = AZ::EBus; diff --git a/Gems/Profiler/Code/Source/ProfilerSystemComponent.cpp b/Gems/Profiler/Code/Source/ProfilerSystemComponent.cpp index f37aa702c1..09df0970b8 100644 --- a/Gems/Profiler/Code/Source/ProfilerSystemComponent.cpp +++ b/Gems/Profiler/Code/Source/ProfilerSystemComponent.cpp @@ -195,9 +195,9 @@ namespace Profiler return true; } - bool ProfilerSystemComponent::StartCapture(const AZStd::string& outputFilePath) + bool ProfilerSystemComponent::StartCapture(AZStd::string outputFilePath) { - m_captureFile = outputFilePath; + m_captureFile = AZStd::move(outputFilePath); return m_cpuProfiler.BeginContinuousCapture(); } diff --git a/Gems/Profiler/Code/Source/ProfilerSystemComponent.h b/Gems/Profiler/Code/Source/ProfilerSystemComponent.h index 534e7d8386..000b11cfdf 100644 --- a/Gems/Profiler/Code/Source/ProfilerSystemComponent.h +++ b/Gems/Profiler/Code/Source/ProfilerSystemComponent.h @@ -42,7 +42,7 @@ namespace Profiler bool IsActive() const override; void SetActive(bool active) override; bool CaptureFrame(const AZStd::string& outputFilePath) override; - bool StartCapture(const AZStd::string& outputFilePath) override; + bool StartCapture(AZStd::string outputFilePath) override; bool EndCapture() override;