PR comments

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

cmake/Platform/Common/Clang/Configurations_clang.cmake

@@ -20,7 +20,7 @@ ly_append_configurations_options(
         # Disabled warnings (please do not disable any others without first consulting sig-build)
         ###################
         -Wno-inconsistent-missing-override # unfortunately there is no warning in MSVC to detect missing overrides, 
-            # MSVC's static analyzer can, but that is a different run that most developers are not ware of. A pass
+            # MSVC's static analyzer can, but that is a different run that most developers are not aware of. A pass
             # was done to fix all hits. Leaving this disabled until there is a matching warning in MSVC.
 
         -Wrange-loop-analysis

cmake/Platform/Common/MSVC/Directory.Build.props

@@ -14,7 +14,7 @@ SPDX-License-Identifier: Apache-2.0 OR MIT
 @VCPKG_CONFIGURATION_MAPPING@
         <!-- Disable vcpkg to prevent include and linking paths from being added by the vcpkg integration -->
         <VcpkgEnabled>false</VcpkgEnabled>
-        <CodeAnalysisRuleSet>@LY_ROOT_FOLDER@\cmake\Platform\Common\MSVC\CodeAnalysis.ruleset</CodeAnalysisRuleSet>
+        <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodeAnalysis.ruleset</CodeAnalysisRuleSet>
     </PropertyGroup>
     <ItemDefinitionGroup>
         <ClCompile>

cmake/Platform/Common/MSVC/VisualStudio_common.cmake

@@ -15,4 +15,4 @@ foreach(conf IN LISTS CMAKE_CONFIGURATION_TYPES)
 endforeach()
   
 configure_file("${CMAKE_CURRENT_LIST_DIR}/Directory.Build.props" "${CMAKE_BINARY_DIR}/Directory.Build.props" @ONLY)
-
+file(COPY_FILE "${CMAKE_CURRENT_LIST_DIR}/CodeAnalysis.ruleset" "${CMAKE_BINARY_DIR}/CodeAnalysis.ruleset" ONLY_IF_DIFFERENT)