birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enables override/virtual warnings

Browse Source 
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
This commit is contained in:
Esteban Papp
2021-09-15 14:11:17 -07:00
committed by GitHub
parent c50f3b2638 9cba144e39
commit bbe437819b
501 changed files with 3326 additions and 2777 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Code/Tools/RemoteConsole/Core/RemoteConsoleCore.h
+6 -6
View File
@@ -94,11 +94,11 @@ struct SNoDataEvent
{
SNoDataEvent()
: IRemoteEvent(T) {};
virtual IRemoteEvent* Clone() { return new SNoDataEvent<T>(); }
IRemoteEvent* Clone() override { return new SNoDataEvent<T>(); }
protected:
virtual void WriteToBuffer([[maybe_unused]] char* buffer, int& size, [[maybe_unused]] int maxsize) { size = 0; }
virtual IRemoteEvent* CreateFromBuffer([[maybe_unused]] const char* buffer, [[maybe_unused]] int size) { return Clone(); }
void WriteToBuffer([[maybe_unused]] char* buffer, int& size, [[maybe_unused]] int maxsize) override { size = 0; }
IRemoteEvent* CreateFromBuffer([[maybe_unused]] const char* buffer, [[maybe_unused]] int size) override { return Clone(); }
};
/////////////////////////////////////////////////////////////////////////////////////////////
@@ -109,17 +109,17 @@ struct SStringEvent
SStringEvent(const char* data)
: IRemoteEvent(T)
, m_data(data) {};
virtual IRemoteEvent* Clone() { return new SStringEvent<T>(GetData()); }
IRemoteEvent* Clone() override { return new SStringEvent<T>(GetData()); }
const char* GetData() const { return m_data.c_str(); }
protected:
virtual void WriteToBuffer(char* buffer, int& size, int maxsize)
void WriteToBuffer(char* buffer, int& size, int maxsize) override
{
const char* data = GetData();
size = min((int)strlen(data), maxsize);
memcpy(buffer, data, size);
}
virtual IRemoteEvent* CreateFromBuffer(const char* buffer, [[maybe_unused]] int size) { return new SStringEvent<T>(buffer); }
IRemoteEvent* CreateFromBuffer(const char* buffer, [[maybe_unused]] int size) override { return new SStringEvent<T>(buffer); }
private:
AZStd::string m_data;