Address PR comments
This commit is contained in:
+2
-2
@@ -19,9 +19,9 @@ namespace TestImpact
|
||||
{
|
||||
namespace Client
|
||||
{
|
||||
//! The set of test targets selected to run regardless of whether or not the test targets are to be exclude either for being on the master exclude
|
||||
//! The set of test targets selected to run regardless of whether or not the test targets are to be excluded either for being on the primary exclude
|
||||
//! list and/or being part of a test suite excluded from this run.
|
||||
//! @note Only the included test targets will be run. The excluded test targetss, although selected, will not be run.
|
||||
//! @note Only the included test targets will be run. The excluded test targets, although selected, will not be run.
|
||||
class TestRunSelection
|
||||
{
|
||||
public:
|
||||
|
||||
+5
-6
@@ -85,19 +85,19 @@ namespace TestImpact
|
||||
//! Test target meta configuration.
|
||||
struct TestTargetMetaConfig
|
||||
{
|
||||
RepoPath m_metaFile; //!< Path to the master test target meta file.
|
||||
RepoPath m_metaFile; //!< Path to the test target meta file.
|
||||
};
|
||||
|
||||
//! Test engine configuration.
|
||||
struct TestEngineConfig
|
||||
{
|
||||
//!< Test runner configuration.
|
||||
//! Test runner configuration.
|
||||
struct TestRunner
|
||||
{
|
||||
RepoPath m_binary; //!< Path to the test runner binary.
|
||||
};
|
||||
|
||||
//!< Test instrumentation configuration.
|
||||
//! Test instrumentation configuration.
|
||||
struct Instrumentation
|
||||
{
|
||||
RepoPath m_binary; //!< Path to the test instrumentation binary.
|
||||
@@ -107,10 +107,10 @@ namespace TestImpact
|
||||
Instrumentation m_instrumentation;
|
||||
};
|
||||
|
||||
//!< Build target configuration.
|
||||
//! Build target configuration.
|
||||
struct TargetConfig
|
||||
{
|
||||
//!< Test target sharding configuration.
|
||||
//! Test target sharding configuration.
|
||||
struct ShardedTarget
|
||||
{
|
||||
AZStd::string m_name; //!< Name of test target this sharding configuration applies to.
|
||||
@@ -122,7 +122,6 @@ namespace TestImpact
|
||||
AZStd::vector<ShardedTarget> m_shardedTestTargets; //!< Test target shard configurations (opt-in).
|
||||
};
|
||||
|
||||
//! Runtime configuration.
|
||||
struct RuntimeConfig
|
||||
{
|
||||
ConfigMeta m_meta;
|
||||
|
||||
+1
@@ -72,6 +72,7 @@ namespace TestImpact
|
||||
StdOutAndFile //!< Send captured output to standard output and write to file.
|
||||
};
|
||||
|
||||
//! Configuration for test targets that opt in to test sharding.
|
||||
enum class ShardConfiguration
|
||||
{
|
||||
Never, //!< Never shard this test target.
|
||||
|
||||
+4
-1
@@ -33,7 +33,10 @@ namespace TestImpact
|
||||
|
||||
AZStd::vector<char> buffer(fileSize + 1);
|
||||
buffer[fileSize] = '\0';
|
||||
AZ_TestImpact_Eval(AZ::IO::SystemFile::Read(path.c_str(), buffer.data()), ExceptionType, AZStd::string::format("Could not read contents of file %s", path.c_str()));
|
||||
AZ_TestImpact_Eval(
|
||||
AZ::IO::SystemFile::Read(path.c_str(), buffer.data()),
|
||||
ExceptionType,
|
||||
AZStd::string::format("Could not read contents of file %s", path.c_str()));
|
||||
|
||||
return AZStd::string(buffer.begin(), buffer.end());
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user