From aa025a5e7d1d4e1a7837dd8157006cd3e0d3622b Mon Sep 17 00:00:00 2001 From: Chris Galvan Date: Wed, 26 Jan 2022 10:48:08 -0600 Subject: [PATCH] Updated unit tests per PR feedback Signed-off-by: Chris Galvan --- Gems/Atom/RPI/Code/Tests/Image/StreamingImageTests.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Gems/Atom/RPI/Code/Tests/Image/StreamingImageTests.cpp b/Gems/Atom/RPI/Code/Tests/Image/StreamingImageTests.cpp index f90702d948..28e5dbd9fe 100644 --- a/Gems/Atom/RPI/Code/Tests/Image/StreamingImageTests.cpp +++ b/Gems/Atom/RPI/Code/Tests/Image/StreamingImageTests.cpp @@ -745,7 +745,7 @@ namespace UnitTest auto pixelDataValue = imageAsset->GetSubImagePixelValue(x, y); auto pixelExpectedValue = static_cast(y * size.m_width + x) / static_cast(std::numeric_limits::max()); - EXPECT_TRUE(AZ::IsClose(pixelDataValue, pixelExpectedValue)); + EXPECT_NEAR(pixelDataValue, pixelExpectedValue, Constants::Tolerance); } } @@ -753,14 +753,13 @@ namespace UnitTest AZStd::vector pixelValues(size.m_width * size.m_height); auto topLeft = AZStd::make_pair(0, 0); auto bottomRight = AZStd::make_pair(size.m_width - 1, size.m_height - 1); - AZStd::span valueSpan(pixelValues.begin(), pixelValues.size()); - streamingImageAsset->GetSubImagePixelValues(topLeft, bottomRight, valueSpan); + streamingImageAsset->GetSubImagePixelValues(topLeft, bottomRight, pixelValues); for (uint32_t index = 0; index < pixelValues.size(); ++index) { - auto pixelDataValue = valueSpan[index]; + auto pixelDataValue = pixelValues[index]; auto pixelExpectedValue = static_cast(index) / static_cast(std::numeric_limits::max()); - EXPECT_TRUE(AZ::IsClose(pixelDataValue, pixelExpectedValue)); + EXPECT_NEAR(pixelDataValue, pixelExpectedValue, Constants::Tolerance); } } }