From a8fa7a59d453106d8c10dbb2727a1c96af486441 Mon Sep 17 00:00:00 2001 From: karlberg Date: Fri, 7 May 2021 10:03:07 -0700 Subject: [PATCH] CR feedback --- .../AzCore/AzCore/Console/LoggerSystemComponent.cpp | 5 +++-- .../AzFramework/Visibility/EntityBoundsUnionBus.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Code/Framework/AzCore/AzCore/Console/LoggerSystemComponent.cpp b/Code/Framework/AzCore/AzCore/Console/LoggerSystemComponent.cpp index de29edc3b0..c004e2c406 100644 --- a/Code/Framework/AzCore/AzCore/Console/LoggerSystemComponent.cpp +++ b/Code/Framework/AzCore/AzCore/Console/LoggerSystemComponent.cpp @@ -127,7 +127,10 @@ namespace AZ const AZStd::size_t length = azvsnprintf(buffer, MaxLogBufferSize, format, args); buffer[AZStd::min(length + 1, MaxLogBufferSize - 1)] = '\0'; + m_logEvent.Signal(level, buffer, file, function, line); + // Force a new-line before calling the AZ::Debug::Trace functions, as they assume a newline is present + buffer[AZStd::min(length + 1, MaxLogBufferSize - 2)] = '\n'; switch (level) { case LogLevel::Warn: @@ -141,8 +144,6 @@ namespace AZ AZ::Debug::Trace::Output("Logger", buffer); break; } - - m_logEvent.Signal(level, buffer, file, function, line); } void LoggerSystemComponent::SetLevel(const AZ::ConsoleCommandContainer& arguments) diff --git a/Code/Framework/AzFramework/AzFramework/Visibility/EntityBoundsUnionBus.h b/Code/Framework/AzFramework/AzFramework/Visibility/EntityBoundsUnionBus.h index b607759260..e95e25871a 100644 --- a/Code/Framework/AzFramework/AzFramework/Visibility/EntityBoundsUnionBus.h +++ b/Code/Framework/AzFramework/AzFramework/Visibility/EntityBoundsUnionBus.h @@ -45,7 +45,7 @@ namespace AzFramework virtual void OnTransformUpdated(AZ::Entity* entity) = 0; protected: - virtual ~IEntityBoundsUnion() = default; + ~IEntityBoundsUnion() = default; }; // EBus wrapper for ScriptCanvas