Address PR comments

Code/Tools/TestImpactFramework/Runtime/Code/Source/Platform/Windows/platform_windows_files.cmake

@@ -17,4 +17,5 @@ set(FILES
     Process/TestImpactWin32_Pipe.cpp
     Process/TestImpactWin32_Pipe.h
     TestEngine/JobRunner/TestImpactWin32_TestTargetExtension.cpp
+    TestEngine/TestImpactWin32_TestEngineJobFailure.cpp
 )

Code/Tools/TestImpactFramework/Runtime/Code/Source/TestImpactRepoPath.cpp

@@ -32,70 +32,70 @@ namespace TestImpact
         return *this;
     }
 
-    inline RepoPath operator/(const RepoPath& lhs, const AZ::IO::PathView& rhs)
+    RepoPath operator/(const RepoPath& lhs, const AZ::IO::PathView& rhs)
     {
         RepoPath result(lhs);
         result.m_path /= RepoPath(rhs).m_path;
         return result;
     }
 
-    inline RepoPath operator/(const RepoPath& lhs, AZStd::string_view rhs)
+    RepoPath operator/(const RepoPath& lhs, AZStd::string_view rhs)
     {
         RepoPath result(lhs);
         result.m_path /= RepoPath(rhs).m_path;
         return result;
     }
 
-    inline RepoPath operator/(const RepoPath& lhs, const RepoPath::value_type* rhs)
+    RepoPath operator/(const RepoPath& lhs, const RepoPath::value_type* rhs)
     {
         RepoPath result(lhs);
         result.m_path /= RepoPath(rhs).m_path;
         return result;
     }
 
-    inline RepoPath operator/(const RepoPath& lhs, const RepoPath& rhs)
+    RepoPath operator/(const RepoPath& lhs, const RepoPath& rhs)
     {
         RepoPath result(lhs);
         result.m_path /= rhs.m_path;
         return result;
     }
 
-    inline RepoPath& RepoPath::operator/=(const AZ::IO::PathView& rhs)
+    RepoPath& RepoPath::operator/=(const AZ::IO::PathView& rhs)
     {
         m_path /= RepoPath(rhs).m_path;
         return *this;
     }
 
 
-    inline RepoPath& RepoPath::operator/=(AZStd::string_view rhs)
+    RepoPath& RepoPath::operator/=(AZStd::string_view rhs)
     {
         m_path /= RepoPath(rhs).m_path;
         return *this;
     }
 
-    inline RepoPath& RepoPath::operator/=(const RepoPath::value_type* rhs)
+    RepoPath& RepoPath::operator/=(const RepoPath::value_type* rhs)
     {
         m_path /= RepoPath(rhs).m_path;
         return *this;
     }
 
-    inline RepoPath& RepoPath::operator/=(const RepoPath& rhs)
+    RepoPath& RepoPath::operator/=(const RepoPath& rhs)
     {
         m_path /= rhs.m_path;
         return *this;
     }
 
-    inline bool operator==(const RepoPath& lhs, const RepoPath& rhs) noexcept
+    bool operator==(const RepoPath& lhs, const RepoPath& rhs) noexcept
     {
         return lhs.m_path.Compare(rhs.m_path) == 0;
     }
 
-    inline bool operator!=(const RepoPath& lhs, const RepoPath& rhs) noexcept
+    bool operator!=(const RepoPath& lhs, const RepoPath& rhs) noexcept
     {
         return lhs.m_path.Compare(rhs.m_path) != 0;
     }
 
-    inline bool operator<([[maybe_unused]] const RepoPath& lhs, [[maybe_unused]] const RepoPath& rhs) noexcept
+    bool operator<([[maybe_unused]] const RepoPath& lhs, [[maybe_unused]] const RepoPath& rhs) noexcept
     {
         return  lhs.m_path.String() < rhs.m_path.String();
     }

Code/Tools/TestImpactFramework/Runtime/Code/Source/TestImpactRuntime.cpp

@@ -309,7 +309,7 @@ namespace TestImpact
 
         if (testSequenceEndCallback.has_value())
         {
-            (*testSequenceEndCallback)(CreateSequenceFailureReport(testJobs), timer.Elapsed());
+            (*testSequenceEndCallback)(GenerateSequenceFailureReport(testJobs), timer.Elapsed());
         }
 
         return result;
@@ -353,7 +353,7 @@ namespace TestImpact
 
         if (testSequenceEndCallback.has_value())
         {
-            (*testSequenceEndCallback)(CreateSequenceFailureReport(testJobs), timer.Elapsed());
+            (*testSequenceEndCallback)(GenerateSequenceFailureReport(testJobs), timer.Elapsed());
         }
 
         return result;
@@ -419,8 +419,8 @@ namespace TestImpact
         if (testSequenceEndCallback.has_value())
         {
             (*testSequenceEndCallback)(
-                CreateSequenceFailureReport(selectedTestJobs),
-                CreateSequenceFailureReport(discardedTestJobs),
+                GenerateSequenceFailureReport(selectedTestJobs),
+                GenerateSequenceFailureReport(discardedTestJobs),
                 timer.Elapsed());
         }
 
@@ -471,7 +471,7 @@ namespace TestImpact
 
         if (testSequenceEndCallback.has_value())
         {
-            (*testSequenceEndCallback)(CreateSequenceFailureReport(testJobs), timer.Elapsed());
+            (*testSequenceEndCallback)(GenerateSequenceFailureReport(testJobs), timer.Elapsed());
         }
 
         return result;

Code/Tools/TestImpactFramework/Runtime/Code/Source/TestImpactRuntimeUtils.h

@@ -114,7 +114,7 @@ namespace TestImpact
             }
             case Client::TestRunResult::TestFailures:
             {
-                testRunFailures.push_back(ExtractTestRunFailure(testJob));
+                testRunFailures.push_back(GenerateTestRunFailure(testJob));
                 break;
             }
             default: