birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Addressed remaining PR feedback

Browse Source 
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com>
This commit is contained in:
nggieber
2021-12-09 15:30:32 -08:00
parent 5641bcd5f1
commit 9f4895aaea
9 changed files with 22 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Code/Tools/ProjectManager/tests/SettingsTests.cpp
-11
View File
@@ -86,11 +86,6 @@ namespace O3DE::ProjectManager
AZStd::unique_ptr<AZ::JsonRegistrationContext> m_registrationContext;
};
TEST_F(SettingsTests, Settings_IsIntialized_Success)
{
EXPECT_TRUE(m_settings->IsInitialized());
}
TEST_F(SettingsTests, Settings_GetUnsetPathBool_ReturnsFalse)
{
bool settingsResult = false;
@@ -103,7 +98,6 @@ namespace O3DE::ProjectManager
bool settingsResult = false;
EXPECT_FALSE(m_settings->Get(settingsResult, m_settingsPath));
// Don't save to disk in test
EXPECT_TRUE(m_settings->Set(m_settingsPath, true));
settingsResult = false;
@@ -125,7 +119,6 @@ namespace O3DE::ProjectManager
QString settingsValue = "TestValue";
// Don't save to disk in test
EXPECT_TRUE(m_settings->Set(m_settingsPath, settingsValue));
EXPECT_TRUE(m_settings->Get(settingsResult, m_settingsPath));
@@ -139,7 +132,6 @@ namespace O3DE::ProjectManager
QString settingsValue = "TestValue";
// Don't save to disk in test
EXPECT_TRUE(m_settings->Set(m_settingsPath, settingsValue));
EXPECT_TRUE(m_settings->Copy(m_settingsPath, m_newSettingsPath, /*removeOrig*/ true));
@@ -158,7 +150,6 @@ namespace O3DE::ProjectManager
QString settingsValue = "TestValue";
// Don't save to disk in test
EXPECT_TRUE(m_settings->Set(m_settingsPath, settingsValue));
EXPECT_TRUE(m_settings->Get(settingsResult, m_settingsPath));
@@ -175,7 +166,6 @@ namespace O3DE::ProjectManager
TEST_F(SettingsTests, Settings_SetProjectBuiltSuccessfully_ReturnsTrue)
{
// Don't save to disk in test
EXPECT_TRUE(m_settings->SetProjectBuiltSuccessfully(m_projectInfo, true));
bool buildResult = false;
@@ -185,7 +175,6 @@ namespace O3DE::ProjectManager
TEST_F(SettingsTests, Settings_SetProjectBuiltUnsuccessfully_ReturnsFalse)
{
// Don't save to disk in test
EXPECT_TRUE(m_settings->SetProjectBuiltSuccessfully(m_projectInfo, false));
bool buildResult = false;