birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Addressed remaining PR feedback

Browse Source 
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com>
This commit is contained in:
nggieber
2021-12-09 15:30:32 -08:00
parent 5641bcd5f1
commit 9f4895aaea
9 changed files with 22 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Code/Tools/ProjectManager/Source/Settings.cpp
+17 -26
View File
@@ -22,12 +22,6 @@ namespace O3DE::ProjectManager
AZ_Assert(m_settingsRegistry, "Failed to create Settings");
}
bool Settings::IsInitialized()
{
// Settings intialized correctly if it successfuly got the SettingsRegistry
return m_settingsRegistry;
}
bool Settings::Save()
{
AZ::SettingsRegistryMergeUtils::DumperSettings dumperSettings;
@@ -61,6 +55,18 @@ namespace O3DE::ProjectManager
return saved;
}
bool Settings::OnSettingsChanged()
{
if (m_saveToDisk)
{
return Save();
}
else
{
return true;
}
}
bool Settings::Get(QString& result, const QString& settingsKey)
{
bool success = false;
@@ -82,10 +88,7 @@ namespace O3DE::ProjectManager
bool success = false;
success = m_settingsRegistry->Set(settingsKey.toStdString().c_str(), settingsValue.toStdString().c_str());
if (m_saveToDisk)
{
Save();
}
OnSettingsChanged();
return success;
}
@@ -95,10 +98,7 @@ namespace O3DE::ProjectManager
bool success = false;
success = m_settingsRegistry->Set(settingsKey.toStdString().c_str(), settingsValue);
if (m_saveToDisk)
{
Save();
}
OnSettingsChanged();
return success;
}
@@ -108,10 +108,7 @@ namespace O3DE::ProjectManager
bool success = false;
success = m_settingsRegistry->Remove(settingsKey.toStdString().c_str());
if (m_saveToDisk)
{
Save();
}
OnSettingsChanged();
return success;
}
@@ -132,10 +129,7 @@ namespace O3DE::ProjectManager
{
success = m_settingsRegistry->Remove(settingsKeyOrig.toStdString().c_str());
}
if (m_saveToDisk)
{
Save();
}
OnSettingsChanged();
}
}
@@ -190,10 +184,7 @@ namespace O3DE::ProjectManager
}
success = m_settingsRegistry->SetObject<AZStd::set<AZStd::string>>(ProjectsBuiltSuccessfullyKey, builtPathsResult);
if (m_saveToDisk)
{
Save();
}
OnSettingsChanged();
return success;
}