Legacy cleanup, part 2 (#3659)

* Legacy cleanup, part 2

There are still things that can be removed, those will be likely done in part three:
`The Return of the Cleanup` :)

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Fix windows build

Somehow there were some unfixed errors from enabled warnings?
I'm unsure if I've pulled repo in unstable state, or those were somehow
missed.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

Gems/LyShine/Code/Editor/SerializeHelpers.cpp

@@ -243,11 +243,14 @@ namespace SerializeHelpers
                 insertBefore);
         }
 
-        // if a list of entities was passed then add all the entities that we added 
+        // if a list of entities was passed then add all the entities that we added
         // to the list
         if (cumulativeListOfCreatedEntities)
         {
-            cumulativeListOfCreatedEntities->push_back(validatedListOfNewlyCreatedTopLevelElements);
+            cumulativeListOfCreatedEntities->insert(
+                        cumulativeListOfCreatedEntities->end(),
+                        validatedListOfNewlyCreatedTopLevelElements.begin(),
+                        validatedListOfNewlyCreatedTopLevelElements.end());
         }
     }
 
@@ -363,7 +366,7 @@ namespace SerializeHelpers
         entityRestoreInfos.insert(entityRestoreInfos.end(),
             unserializedEntities->m_entityRestoreInfos.begin(), unserializedEntities->m_entityRestoreInfos.end());
         entityRestoreInfos.insert(entityRestoreInfos.end(),
-            unserializedEntities->m_childEntityRestoreInfos.begin(), unserializedEntities->m_childEntityRestoreInfos.end()); 
+            unserializedEntities->m_childEntityRestoreInfos.begin(), unserializedEntities->m_childEntityRestoreInfos.end());
     }
 
 }   // namespace EntityHelpers