Legacy cleanup, part 2 (#3659)

* Legacy cleanup, part 2

There are still things that can be removed, those will be likely done in part three:
`The Return of the Cleanup` :)

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Fix windows build

Somehow there were some unfixed errors from enabled warnings?
I'm unsure if I've pulled repo in unstable state, or those were somehow
missed.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

Code/Editor/ToolsConfigPage.cpp

@@ -59,8 +59,8 @@ public:
         }
         const QString iconsDir = gSettings.searchPaths[EDITOR_PATH_UI_ICONS][0];
         CFileUtil::ScanDirectory(iconsDir, "*.png", pngFiles);
-        m_iconImages.reserve(pngFiles.size());
-        m_iconFiles.reserve(pngFiles.size());
+        m_iconImages.reserve(static_cast<int>(pngFiles.size()));
+        m_iconFiles.reserve(static_cast<int>(pngFiles.size()));
         for (size_t i = 0; i < pngFiles.size(); ++i)
         {
             const QString path = Path::Make(iconsDir, pngFiles[i].filename);