more fixes for Code

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

Code/Framework/AzQtComponents/AzQtComponents/Components/DockBarButton.cpp

@@ -141,7 +141,6 @@ namespace AzQtComponents
         }
 
         QRect buttonRect = style->subControlRect(QStyle::CC_ToolButton, option, QStyle::SC_ToolButton, widget);
-        QRect menuRect = style->subControlRect(QStyle::CC_ToolButton, option, QStyle::SC_ToolButtonMenu, widget);
 
         painter->save();
 

Code/Framework/AzQtComponents/AzQtComponents/Components/FilteredSearchWidget.cpp

@@ -852,7 +852,7 @@ namespace AzQtComponents
         {
             FilterCriteriaButton* button = createCriteriaButton(filter, index);
             connect(button, &FilterCriteriaButton::RequestClose, this, [this, index]() { SetFilterStateByIndex(index, false); });
-            connect(button, &FilterCriteriaButton::ExtraButtonClicked, this, [this, index](FilterCriteriaButton::ExtraButtonType type)
+            connect(button, &FilterCriteriaButton::ExtraButtonClicked, this, [](FilterCriteriaButton::ExtraButtonType type)
             {
                 switch (type)
                 {

Code/Framework/AzQtComponents/AzQtComponents/Components/Widgets/Eyedropper.h

@@ -72,7 +72,7 @@ namespace AzQtComponents
 
         void release(bool selected);
 
-        QToolButton* m_button;
+        [[maybe_unused]] QToolButton* m_button;
 
         int m_contextSize;
         int m_sampleSize;

Code/Framework/AzQtComponents/AzQtComponents/Components/Widgets/GradientSlider.cpp

@@ -30,7 +30,7 @@ GradientSlider::GradientSlider(Qt::Orientation orientation, QWidget* parent)
 
     setMouseTracking(true);
 
-    m_colorFunction = [this](qreal value) {
+    m_colorFunction = [](qreal value) {
         return QColor::fromRgbF(value, value, value);
     };
 
@@ -115,7 +115,6 @@ void GradientSlider::mouseMoveEvent(QMouseEvent* event)
     int intValue = Slider::valueFromPosition(this, event->pos(), width(), height(), rect().bottom());
 
     qreal value = (aznumeric_cast<qreal, int>(intValue - minimum()) / aznumeric_cast<qreal, int>(maximum() - minimum()));
-    QColor rgb = m_colorFunction(value);
 
     const QString toolTipText = m_toolTipFunction(value);
 

Code/Framework/AzQtComponents/AzQtComponents/Components/Widgets/Slider.cpp

@@ -490,11 +490,11 @@ QRect Slider::sliderGrooveRect(const Style* style, const QStyleOptionSlider* opt
     return {};
 }
 
-bool Slider::polish(Style* style, QWidget* widget, const Slider::Config& config)
+bool Slider::polish([[maybe_unused]] Style* style, QWidget* widget, const Slider::Config& config)
 {
     Q_UNUSED(config);
 
-    auto polishSlider = [style](auto slider)
+    auto polishSlider = [](auto slider)
     {
         // Qt's stylesheet parsing doesn't set custom properties on things specified via
         // pseudo-states, such as horizontal/vertical, so we implement our own

Code/Framework/AzQtComponents/AzQtComponents/Components/WindowDecorationWrapper.cpp

@@ -65,7 +65,6 @@ namespace AzQtComponents
                 return false;
             }
 
-            const quint16 currentMajorVersion = 2;
             quint16 majorVersion = 0;
             quint16 minorVersion = 0;
 

Code/Framework/AzQtComponents/AzQtComponents/Utilities/ScreenGrabber.h

@@ -31,7 +31,7 @@ namespace AzQtComponents
 
     private:
         QSize m_size;
-        Eyedropper* m_owner;
+        [[maybe_unused]] Eyedropper* m_owner;
         QScopedPointer<Internal> m_internal;
     };
 

Code/Framework/AzQtComponents/AzQtComponents/Utilities/ScreenGrabber_win.cpp

@@ -217,7 +217,7 @@ namespace AzQtComponents
     }
 
     ScreenGrabber::ScreenGrabber(const QSize size, Eyedropper* parent /* = nullptr */)
-        : QObject(static_cast<QObject*>(parent))
+        : QObject(parent)
         , m_size(size)
         , m_owner(parent)
     {