From 8e34d784e60f0e9489bec5335fa6171af5e3cad5 Mon Sep 17 00:00:00 2001
From: qingtao <qingtao@amazon.com>
Date: Fri, 16 Apr 2021 09:47:03 -0700
Subject: [PATCH] ATOM-15252 [Atom 0.8.5] Track View capture crashes when scene
 contains certain postfx The crash was because the
 "BlendColorGradingLutImageAttachmentId" attachment got imported to attachment
 database twice. This fix avoids import this attachment twice. It also avoid
 crash but only report a warning if an imported attachment wasn't used in any
 scope. Enable both RHI and RPI validation (no visiable performance impact
 observed.

---
 .../PostProcessing/BlendColorGradingLutsPass.cpp     |  9 +++++++--
 Gems/Atom/RHI/Code/Source/RHI.Reflect/Base.cpp       |  2 +-
 .../RHI/DX12/Code/Source/RHI/FrameGraphCompiler.cpp  | 12 ++++++++++++
 Gems/Atom/RPI/Code/Source/RPI.Reflect/Base.cpp       |  2 +-
 4 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/Gems/Atom/Feature/Common/Code/Source/PostProcessing/BlendColorGradingLutsPass.cpp b/Gems/Atom/Feature/Common/Code/Source/PostProcessing/BlendColorGradingLutsPass.cpp
index 206e58d5e6..e0ff253301 100644
--- a/Gems/Atom/Feature/Common/Code/Source/PostProcessing/BlendColorGradingLutsPass.cpp
+++ b/Gems/Atom/Feature/Common/Code/Source/PostProcessing/BlendColorGradingLutsPass.cpp
@@ -131,8 +131,13 @@ namespace AZ
             AZ_Assert(m_blendedLut.m_lutImage != nullptr, "BlendColorGradingLutsPass unable to acquire LUT image");
 
             AZ::RHI::AttachmentId imageAttachmentId = AZ::RHI::AttachmentId("BlendColorGradingLutImageAttachmentId");
-            [[maybe_unused]] RHI::ResultCode result = frameGraph.GetAttachmentDatabase().ImportImage(imageAttachmentId, m_blendedLut.m_lutImage);
-            AZ_Error("BlendColorGradingLutsPass", result == RHI::ResultCode::Success, "Failed to import compute buffer with error %d", result);
+
+            // import this attachment if it wasn't imported
+            if (!frameGraph.GetAttachmentDatabase().IsAttachmentValid(imageAttachmentId))
+            {
+                [[maybe_unused]] RHI::ResultCode result = frameGraph.GetAttachmentDatabase().ImportImage(imageAttachmentId, m_blendedLut.m_lutImage);
+                AZ_Error("BlendColorGradingLutsPass", result == RHI::ResultCode::Success, "Failed to import BlendColorGradingLutImageAttachmentId with error %d", result);
+            }
 
             RHI::ImageScopeAttachmentDescriptor desc;
             desc.m_attachmentId = imageAttachmentId;
diff --git a/Gems/Atom/RHI/Code/Source/RHI.Reflect/Base.cpp b/Gems/Atom/RHI/Code/Source/RHI.Reflect/Base.cpp
index 4d35411e09..21eb634159 100644
--- a/Gems/Atom/RHI/Code/Source/RHI.Reflect/Base.cpp
+++ b/Gems/Atom/RHI/Code/Source/RHI.Reflect/Base.cpp
@@ -16,6 +16,6 @@ namespace AZ
 {
     namespace RHI
     {
-        bool Validation::s_isEnabled = BuildOptions::IsDebugBuild;
+        bool Validation::s_isEnabled = BuildOptions::IsDebugBuild || BuildOptions::IsProfileBuild;
     }
 }
diff --git a/Gems/Atom/RHI/DX12/Code/Source/RHI/FrameGraphCompiler.cpp b/Gems/Atom/RHI/DX12/Code/Source/RHI/FrameGraphCompiler.cpp
index 1ae8a4ae96..7fc1db179a 100644
--- a/Gems/Atom/RHI/DX12/Code/Source/RHI/FrameGraphCompiler.cpp
+++ b/Gems/Atom/RHI/DX12/Code/Source/RHI/FrameGraphCompiler.cpp
@@ -404,6 +404,12 @@ namespace AZ
             Buffer& buffer = static_cast<Buffer&>(*bufferFrameAttachment.GetBuffer());
             RHI::BufferScopeAttachment* scopeAttachment = bufferFrameAttachment.GetFirstScopeAttachment();
 
+            if (scopeAttachment == nullptr)
+            {
+                AZ_WarningOnce("RHI", false, "Imported BufferFrameAttachment isn't used in any Scope");
+                return;
+            }
+
             D3D12_RESOURCE_TRANSITION_BARRIER transition;
             transition.pResource = buffer.GetMemoryView().GetMemory();
             transition.Subresource = D3D12_RESOURCE_BARRIER_ALL_SUBRESOURCES;
@@ -471,6 +477,12 @@ namespace AZ
             Image& image = static_cast<Image&>(*imageFrameAttachment.GetImage());
             RHI::ImageScopeAttachment* scopeAttachment = imageFrameAttachment.GetFirstScopeAttachment();
 
+            if (scopeAttachment == nullptr)
+            {
+                AZ_WarningOnce("RHI", false, "Imported ImageFrameAttachment isn't used in any Scope");
+                return;
+            }
+
             D3D12_RESOURCE_TRANSITION_BARRIER transition;
             transition.pResource = image.GetMemoryView().GetMemory();
 
diff --git a/Gems/Atom/RPI/Code/Source/RPI.Reflect/Base.cpp b/Gems/Atom/RPI/Code/Source/RPI.Reflect/Base.cpp
index 7012a7cf88..8addb16a23 100644
--- a/Gems/Atom/RPI/Code/Source/RPI.Reflect/Base.cpp
+++ b/Gems/Atom/RPI/Code/Source/RPI.Reflect/Base.cpp
@@ -16,6 +16,6 @@ namespace AZ
 {
     namespace RPI
     {
-        bool Validation::s_isEnabled = RHI::BuildOptions::IsDebugBuild;
+        bool Validation::s_isEnabled = RHI::BuildOptions::IsDebugBuild || RHI::BuildOptions::IsProfileBuild;
     }
 }