Removed unneeded comments (#673)

This commit is contained in:
Terry Michaels
2021-05-10 22:02:30 -05:00
committed by GitHub
parent f21637f471
commit 8ddfcabae7
66 changed files with 40 additions and 98 deletions
@@ -11,7 +11,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# Test case ID : C18977329
# Test Case Title : Add cloth simulation to a Mesh
# URL of the test case : https://testrail.agscollab.com/index.php?/cases/view/18977329
# fmt: off
class Tests:
@@ -11,7 +11,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# Test case ID : C18977330
# Test Case Title : Add cloth simulation to an Actor
# URL of the test case : https://testrail.agscollab.com/index.php?/cases/view/18977330
# fmt: off
class Tests:
@@ -12,7 +12,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# Test case ID : C28798177
# Test Case Title : White Box Tool Component can be added to an Entity
# URL of the test case : https://testrail.agscollab.com/index.php?/cases/view/28798177
# fmt:off
@@ -12,7 +12,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# Test case ID : C28798205
# Test Case Title : From the White Box Component Card the White Box Mesh can be set to be invisible in Game View
# URL of the test case : https://testrail.agscollab.com/index.php?/cases/view/28798205
# fmt:off
@@ -12,7 +12,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# Test case ID : C29279329
# Test Case Title : White Box mesh shape can be changed with the Default Shape dropdown on the Component
# URL of the test case : https://testrail.agscollab.com/index.php?/cases/view/29279329
# fmt:off
@@ -68,7 +68,7 @@ def C14976308_ScriptCanvas_SetKinematicTargetTransform():
the script deactivates Signal, Sphere's transform will update to that of Transform_Target.
NOTE: There is a known bug (LY-107723) which causes the rotation to update to a value that is not sufficiently close
to the expected result when using Set Kinematic Target which will cause the test to fail:
https://jira.agscollab.com/browse/LY-107723
LY-107723
Test Steps:
1) Open level and enter game mode
@@ -13,7 +13,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# Test case ID : C3510644
# Test Case Title : Check that the collision layer and collision group of the terrain can be changed
# and the collision behavior of the terrain changes accordingly
# URL of the test case : https://testrail.agscollab.com/index.php?/cases/view/3510644
# fmt: off
@@ -239,7 +239,7 @@ def C6321601_Force_HighValuesDirectionAxes():
force_notification_handler.add_callback("OnCalculateNetForce", on_calc_net_force)
# Wait for 3 secs, because there is a known bug identified and filed in
# JIRA https://jira.agscollab.com/browse/LY-107677
# JIRA LY-107677
# The error "[Error] Huge object being added to a COctreeNode, name: 'MeshComponentRenderNode', objBox:"
# will show (if occured) in about 3 sec into the game mode.
helper.wait_for_condition(has_physx_error, 3.0)
@@ -50,7 +50,7 @@ class TestAutomation(TestAutomationBase):
unexpected_lines = ["Assert"]
self._run_test(request, workspace, editor, test_module, expected_lines, unexpected_lines)
# BUG: https://jira.agscollab.com/browse/LY-107723")
# BUG: LY-107723")
def test_C14976308_ScriptCanvas_SetKinematicTargetTransform(self, request, workspace, editor):
from . import C14976308_ScriptCanvas_SetKinematicTargetTransform as test_module
@@ -12,7 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
'''
This unittest might have to be refactored once changes to Physmaterial_Editor.py are made.
These changes will occur after the but, reverence below is resloved.
Bug: https://jira.agscollab.com/browse/LY-107392
Bug: LY-107392
'''
class Tests:
opening_bad_file = ("Bad file could not be opened", "Bad file was opened")
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92569013
Test Case Title: Script Event file can be created
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569013
"""
@@ -12,7 +12,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92568942
Test Case Title: Clicking the "+" button and selecting "New Script Event" opens the
Asset Editor with a new Script Event asset
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92568942
"""
from PySide2 import QtWidgets
@@ -11,7 +11,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92568856
Test Case Title: Multiple Entities can be targeted in the Debugger tool
URLs of the test case: https://testrail.agscollab.com/index.php?/tests/view/92568856
"""
@@ -11,7 +11,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92569137
Test Case Title: Multiple Graphs can be targeted in the Debugger tool
URLs of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569137
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: C1702824
Test Case Title: Docking
URLs of the test case: https://testrail.agscollab.com/index.php?/cases/view/1702824
"""
@@ -11,10 +11,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92569049
Test Case Title: Edit > Undo undoes the last action
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569049
Test case ID: T92569051
Test Case Title: Edit > Redo redoes the last undone action
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569051
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92562978
Test Case Title: Script Canvas Component can be added to an entity
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92562978
"""
@@ -11,10 +11,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92569037
Test Case Title: File > New Script creates a new script
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569037
Test case ID: T92569039
Test Case Title: File > Open opens the Open... dialog
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569039
"""
import os
@@ -11,11 +11,9 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92563070
Test Case Title: Graphs can be closed by clicking X on the Graph name tab
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92563070
Test case ID: T92563068
Test Case Title: Save Prompt: User is prompted to save a graph on close after
creating a new graph
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92563068
"""
import os
@@ -11,10 +11,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92569079
Test Case Title: View > Zoom In zooms the graph in
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569079
Test case ID: T92569081
Test Case Title: View > Zoom In zooms the graph out
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569081
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92562988
Test Case Title: Left-click/double click expands and collapses node categories
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92562988
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92568982
Test Case Title: Renaming variables in the Node Inspector
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92568982
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92562993
Test Case Title: Clicking the X button on the Search Box clears the currently entered string
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92562993
"""
@@ -11,7 +11,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92568940
Test Case Title: Categories and Nodes can be selected
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92568940
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92569253 // T92569254
Test Case Title: On Entity Activated // On Entity Deactivated
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92569253 // https://testrail.agscollab.com/index.php?/tests/view/92569254
"""
@@ -10,8 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: C1702834 // C1702823
Test Case Title: Opening pane // Closing pane
URLs of the test case: https://testrail.agscollab.com/index.php?/cases/view/1702834 and
https://testrail.agscollab.com/index.php?/cases/view/1702823
"""
@@ -10,8 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: C1702821 // C1702832
Test Case Title: Retain visibility, size and location upon Script Canvas restart
URLs of the test case: https://testrail.agscollab.com/index.php?/cases/view/1702821 and
https://testrail.agscollab.com/index.php?/cases/view/1702832
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: C1702829
Test Case Title: Resizing pane
URLs of the test case: https://testrail.agscollab.com/index.php?/cases/view/1702829
"""
@@ -11,7 +11,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92562986
Test Case Title: Changing the assigned Script Canvas Asset on an entity properly updates
level functionality
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92562986
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92563190
Test Case Title: A single Entity with two Script Canvas components works properly
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92563190
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92563191
Test Case Title: Two Entities can use the same Graph asset successfully at RunTime
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92563191
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92567321
Test Case Title: Script Events: Can send and receive a script event across multiple entities successfully
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92567321
"""
@@ -10,7 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92567320
Test Case Title: Script Events: Can send and receive a script event successfully
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92567320
"""
@@ -13,11 +13,6 @@ Test Case Title: Tools > Node Palette toggles the Node Palette
Tools > Node Inspector toggles the Node Inspector
Tools > Bookmarks toggles the Bookmarks
Tools > Variable Manager toggles the Variable Manager
URLs of the test case: https://testrail.agscollab.com/index.php?/cases/view/92569165
https://testrail.agscollab.com/index.php?/cases/view/92569167
https://testrail.agscollab.com/index.php?/cases/view/92569168
https://testrail.agscollab.com/index.php?/cases/view/92569170
"""
@@ -10,8 +10,6 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: C1702825 // C1702831
Test Case Title: Undocking // Closing script canvas with the pane floating
URLs of the test case: https://testrail.agscollab.com/index.php?/cases/view/1702825 &
https://testrail.agscollab.com/index.php?/cases/view/1702831
"""
@@ -10,10 +10,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Test case ID: T92564789
Test Case Title: Each Variable type can be created
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92564789
Test case ID: T92568873
Test Case Title: Each Variable type can be deleted
URL of the test case: https://testrail.agscollab.com/index.php?/tests/view/92568873
"""
@@ -189,7 +189,7 @@ namespace AZ
if (!WasLoadSuccess(result.GetOutcome()))
{
// This if is a hack around fault in the JSON serialization system
// Jira: https://jira.agscollab.com/browse/LY-106587
// Jira: LY-106587
if (message != "No part of the string could be interpreted as a uuid.")
{
deserializeError.append(message);
@@ -1353,7 +1353,7 @@ namespace AzToolsFramework
// Iterate over the entities left in the instance and if none of them have this
// asset entity as its ancestor, then we want to remove it.
// \todo - Investigate ways to make this non-linear time. Tricky since removed entities
// obviously aren't maintained in any maps. (https://jira.agscollab.com/browse/LY-88218)
// obviously aren't maintained in any maps. (LY-88218)
bool foundAsAncestor = false;
for (const AZ::Entity* instanceEntity : instanceEntities)
{
@@ -514,7 +514,7 @@ void LevelEditorMenuHandler::PopulateEditMenu(ActionManager::MenuWrapper& editMe
/*
* The following block of code is part of the feature "Isolation Mode" and is temporarily
* disabled for 1.10 release.
* Jira: https://jira.agscollab.com/browse/LY-49532
* Jira: LY-49532
// Isolate Selected
QAction* isolateSelectedAction = editMenu->addAction(tr("Isolate Selected"));
@@ -37,8 +37,6 @@ float3 TextureBlend_Overlay(float3 target, float3 blend)
//! @return the resulting blended color
float3 ApplyTextureBlend(float3 color, float3 blendColor, float factor, TextureBlendMode blendMode)
{
// More info to help understand some of these blend modes: https://wiki.agscollab.com/pages/viewpage.action?pageId=15764930
if(blendMode == TextureBlendMode::Multiply)
{
return factor * color * blendColor;
@@ -25,7 +25,7 @@ class LightCullingTileIterator
float viewz = abs(svPosition.w);
// https://jira.agscollab.com/browse/ATOM-4198
// ATOM-4198
// Replace GetDimensions() with a cbuffer uint read. Reading it from a cbuffer should be faster
uint tileWidth, tileHeight;
tileLightDataTex.GetDimensions(tileWidth, tileHeight);
@@ -17,7 +17,7 @@
#include <Atom/RPI/Math.azsli>
#include <Atom/Features/LightCulling/LightCullingShared.azsli>
enum QuadLightFlag // Copied from QuadLight.azsli. See https://jira.agscollab.com/browse/ATOM-3731
enum QuadLightFlag // Copied from QuadLight.azsli. See ATOM-3731
{
None = 0x00,
EmitsBothDirections = 0x01, // 1 << 0, // Quad should emit light from both sides
@@ -33,7 +33,7 @@ ShaderResourceGroup PassSrg : SRG_PerPass
{
// Figure out how to remove duplicate struct definitions.
// These are also defined in View.srg
// https://jira.agscollab.com/browse/ATOM-3731
// ATOM-3731
struct SimplePointLight
{
@@ -372,7 +372,7 @@ void CullDecals(uint groupIndex, TileLightData tileLightData, float3 aabb_center
float3 decalPosition = WorldToView_Point(decal.m_position);
// just wrapping a bounding sphere around a cube for now to get a minor perf boost. i.e. the sphere radius is sqrt(x*x + y*y + z*z)
// https://jira.agscollab.com/browse/ATOM-4224 - try AABB-AABB and implement depth binning for the decals
// ATOM-4224 - try AABB-AABB and implement depth binning for the decals
float maxHalfSize = max(max(decal.m_halfSize.x, decal.m_halfSize.y), decal.m_halfSize.z);
float boundingSphereRadiusSqr = maxHalfSize * maxHalfSize * 3;
@@ -380,7 +380,7 @@ void CullDecals(uint groupIndex, TileLightData tileLightData, float3 aabb_center
if (potentiallyIntersects)
{
// Implement and profile fine-grained light culling testing
// https://jira.agscollab.com/browse/ATOM-3732
// ATOM-3732
MarkLightAsVisibleInSharedMemory(decalIndex, 0xFFFF);
}
}
@@ -393,7 +393,7 @@ void CullPointLight(uint lightIndex, float3 lightPosition, float invLightRadius,
if (potentiallyIntersects)
{
// Implement and profile fine-grained light culling testing
// https://jira.agscollab.com/browse/ATOM-3732
// ATOM-3732
uint inside = 0;
float2 minmax = ComputePointLightMinMaxZ(rsqrt(invLightRadius), lightPosition);
@@ -434,7 +434,7 @@ void CullSimpleSpotLights(uint groupIndex, TileLightData tileLightData, float3 a
if (potentiallyIntersects)
{
// Implement and profile fine-grained light culling testing
// https://jira.agscollab.com/browse/ATOM-3732
// ATOM-3732
uint inside = 0;
float2 minmax = ComputeSimpleSpotLightMinMax(light, lightPosition);
@@ -479,7 +479,7 @@ void CullDiskLights(uint groupIndex, TileLightData tileLightData, float3 aabb_ce
if (potentiallyIntersects)
{
// Implement and profile fine-grained light culling testing
// https://jira.agscollab.com/browse/ATOM-3732
// ATOM-3732
uint inside = 0;
float2 minmax = ComputeDiskLightMinMax(light, lightPosition);
@@ -507,7 +507,7 @@ void CullCapsuleLights(uint groupIndex, TileLightData tileLightData, float3 aabb
if (potentiallyIntersects)
{
// Implement and profile fine-grained light culling testing
// https://jira.agscollab.com/browse/ATOM-3732
// ATOM-3732
uint inside = 0;
float2 minmax = ComputeCapsuleLightMinMax(light, lightMiddleView, lightFalloffRadius);
@@ -522,7 +522,7 @@ void CullCapsuleLights(uint groupIndex, TileLightData tileLightData, float3 aabb
void CullQuadLights(uint groupIndex, TileLightData tileLightData, float3 aabb_center, float3 aabb_extents)
{
// Implement and profile fine-grained light culling testing
// https://jira.agscollab.com/browse/ATOM-3732
// ATOM-3732
for (uint lightIndex = groupIndex ; lightIndex < PassSrg::m_quadLightCount ; lightIndex += TILE_DIM_X * TILE_DIM_Y)
{
@@ -242,7 +242,7 @@ PSOutput MainPS(VSOutput IN)
// Set this value to > 0 to actually see this pass. It is currently always active.
OUT.m_color.w = PassSrg::m_heatmapOpacity;
// https://jira.agscollab.com/browse/ATOM-3682 (improve heatmap integration with the pass system)
// ATOM-3682 (improve heatmap integration with the pass system)
return OUT;
}
@@ -186,7 +186,7 @@ void InitWriteIndices(uint3 groupID, uint baseBin, out uint writeIndices[NVLC_MA
// light indices until it hits an END_OF_X marker
// Note that this code could probably be made faster with wave intrinsics
// https://jira.agscollab.com/browse/ATOM-4104
// ATOM-4104
[numthreads(NUM_THREADS, 1, 1)]
void MainCS(
uint3 dispatchThreadID : SV_DispatchThreadID,
@@ -181,7 +181,7 @@ void WriteTileLightDataToMainMemory(uint groupIndex, uint3 groupID, float2 minma
// Note that Nvidia Light Culling framework has some additional code to better calculate this ratio
// See cb_perFrame.fRangeThreshold in their framework. This code might be something we want to port over.
// https://jira.agscollab.com/browse/ATOM-5554
// ATOM-5554
float ratio = tileZ / 1.0f;
float logMaxBins = clamp(log2(ratio), 0.0, LOG_MAX_BINS);
uint ulogMaxBins = uint(logMaxBins + 0.5);
@@ -41,7 +41,6 @@ ShaderResourceGroup PassSrg : SRG_PerDraw
// The number of points to sample.
// Sample 6 points around center pixel.
// Similarly, sample around it as 12,18,24 points.
// Please refer to “https://wiki.agscollab.com/display/ATOM/Pencil+Map” for details.
option enum class SampleNumber
{
Sample6, // 6
@@ -52,7 +51,6 @@ option enum class SampleNumber
o_sampleNumber = SampleNumber::Sample6;
// Get CocRadius from dofFactor.
// Please refer to https://wiki.agscollab.com/display/ATOM/Pencil+Map for CocRadius.
inline float GetCocRadius(float dofFactor)
{
float cocRadius = dofFactor * ViewSrg::m_dof.m_cocToScreenRatio * 0.5f;
@@ -61,14 +59,12 @@ inline float GetCocRadius(float dofFactor)
}
// Calculate the texcoord U of the pencil map from cocRadius.
// Please refer to https://wiki.agscollab.com/display/ATOM/Pencil+Map for the pencil map.
inline float GetPencilMapTexcoordU(float cocRadius)
{
return cocRadius * ViewSrg::m_dof.m_pencilMapTexcoordToCocRadius + ViewSrg::m_dof.m_pencilMapFocusPointTexcoordU;
}
// Get the color from the coordinate array.
// Please refer to https://wiki.agscollab.com/display/ATOM/Pencil+Map for details of coordinates.
inline float4 SampleColorAndDofFactor(float2 centerTexCoord, float cocRadius, int sampleIndex)
{
float2 sampleTexcoordOffset = PassSrg::m_sampleTexcoordsRadius[sampleIndex].xy * cocRadius;
@@ -78,7 +74,6 @@ inline float4 SampleColorAndDofFactor(float2 centerTexCoord, float cocRadius, in
}
// Load the pencil map. Since the colors are square rooted, they are decoded (linearized). This is for accuracy.
// Please refer to https://wiki.agscollab.com/display/ATOM/Pencil+Map for the pencil map.
inline float4 SamplePencilMap(float lensCoordX, float radius)
{
float2 bokehTexcoord = float2(lensCoordX, radius);
@@ -77,7 +77,6 @@ PSOutput MainPS(VSOutput IN)
float3 colorSum = (float3)0;
// Combine from the back buffer to the front.
// Please refer to https://wiki.agscollab.com/pages/viewpage.action?spaceKey=ATOM&title=Dof+factor+and+Buffer+composition for details
////////////////////////////////////////////////////////////////////////
// Background
@@ -1487,7 +1487,6 @@ namespace AZ
float depthNear,
float depthFar) const
{
// For calculation, refer https://wiki.agscollab.com/display/ATOM/Cascaded+Shadowmaps
// This calculates the center of bounding sphere for a camera view frustum.
// By this, on the camera view (2D), the bounding sphere's center
// shifts to the remarkable point.
@@ -34,7 +34,7 @@ namespace AZ
const size_t NumBins = 8;
const size_t MaxLightsPerTile = 256;
// TODO convert this to R16_UINT. It just needs RHI support
// https://jira.agscollab.com/browse/ATOM-3975
// ATOM-3975
const RHI::Format LightListRemappedFormat = RHI::Format::R32_UINT;
RPI::Ptr<LightCullingRemap> LightCullingRemap::Create(const RPI::PassDescriptor& descriptor)
@@ -50,7 +50,7 @@ namespace AZ
static constexpr Quality QualitySet[DepthOfField::QualityLevelMax] =
{
// It is the radial division count of blur kernel. See "https://wiki.agscollab.com/display/ATOM/Pencil+Map" for details.
// It is the radial division count of blur kernel.
{2, 3, 4},
{4, 4, 4}
};
@@ -205,7 +205,6 @@ namespace AZ
float scaledDiameter = ScreenApertureDiameter * 0.25f;
// This is the conversion factor for calculating the blend ratio from DofFactor.
// Please refer to "https://wiki.agscollab.com/display/ATOM/Dof+factor+and+Buffer+composition" for blending of DofFactor and buffer.
// coc0 : Confusion circle diameter screen ratio
// coc1 : Confusion circle diameter screen ratio of one lower blur level;
@@ -139,7 +139,6 @@ namespace AZ
float m_minBokehRadiusDivision8 = 0.0f;
// Radial division count of bokeh blur kernel.
// See "https://wiki.agscollab.com/display/ATOM/Pencil+Map" for details.
uint32_t m_sampleRadialDivision2 = 0;
uint32_t m_sampleRadialDivision4 = 0;
uint32_t m_sampleRadialDivision8 = 0;
@@ -194,7 +194,6 @@ namespace AZ
// calculate sampling texcoords.
// sample 6 points around center pixel.
// Similarly, sample around it as 12,18,24 points.
// Please refer to "https://wiki.agscollab.com/display/ATOM/Pencil+Map" for details.
AZ_Assert(radialDivisionCount >= 1 && radialDivisionCount <= 4, "DepthOfFieldBokehBlurPass : radialDivisionCount is illegal value.");
@@ -18,8 +18,6 @@ namespace AZ
{
namespace PencilMap
{
// Please refer to "https://wiki.agscollab.com/display/ATOM/Pencil+Map" for details.
// PencilMap 35mm Film
static constexpr unsigned int TextureWidth = 128;
static constexpr unsigned int TextureHeight = 64;
@@ -16,7 +16,7 @@ with Lumberyard. Note: this boostrap is only designed fo be py3 compatible.
If you need DCCsi access in py27 (Autodesk Maya for instance) you may need
to implement your own boostrapper module. Currently this is boostrapped
from add_dccsi.py, as a temporty measure related to this Jira:
https://jira.agscollab.com/browse/SPEC-2581"""
SPEC-2581"""
# standard imports
import sys
import os
@@ -25,7 +25,7 @@ the provided env and launcher bat files.
If you are developing for the DCCsi you can use this launcher to start Maya:
DccScriptingInterface\Launchers\Windows\Launch_Maya_2020.bat"
To Do: https://jira.agscollab.com/browse/ATOM-5861
To Do: ATOM-5861
"""
__project__ = 'DccScriptingInterface'
@@ -43,7 +43,7 @@ Note: to get this to work unfortunatley each user must configure the wingide pre
(there is no shared project / data-driven way that I know of to set this up otherwise)
Note: lumberyard is not currently generating __init__.pyi files in that package structure:
https://jira.agscollab.com/browse/SPEC-3315
SPEC-3315
The workaround is to create them yourself (they can be empty) and needs to be in the root of each package folder, like this:
dev\Cache\AtomTechArt\pc\user\python_symbols\azlmbr\__init__.pyi
@@ -63,4 +63,4 @@ You might need to reboot wing. Then you should have auto-complete for the lumbe
Note: the entirety of azlmbr api does not generate .pyi files currently,
all of the "Behaviour Context" based classes do
non-BC modules such as azlmbr.paths currently do not
https://jira.agscollab.com/browse/SPEC-3316
SPEC-3316
@@ -40,7 +40,7 @@ Module Documentation:
<to do: further document this module>
To Do:
https://jira.agscollab.com/browse/ATOM-5859
ATOM-5859
'''
# -------------------------------------------------------------------------
@@ -22,7 +22,7 @@ Module: <DCCsi>\azpy\shared\common\config_utils.py
<to do: further document this module>
To Do:
https://jira.agscollab.com/browse/ATOM-5859
ATOM-5859
'''
# -------------------------------------------------------------------------
@@ -168,8 +168,8 @@ namespace EMotionFX
// The skin attachment should now receive morph values from the main actor.
const Pose& attachPose = *m_attachmentActorInstance->GetTransformData()->GetCurrentPose();
ASSERT_EQ(attachPose.GetNumMorphWeights(), 4);
EXPECT_FLOAT_EQ(attachPose.GetMorphWeight(0), 0.0f); // Once we auto register missing morphs this should be 0.5. See https://jira.agscollab.com/browse/LY-100212
EXPECT_FLOAT_EQ(attachPose.GetMorphWeight(1), 0.0f); // Once we auto register missing morphs this should be 0.6. See https://jira.agscollab.com/browse/LY-100212
EXPECT_FLOAT_EQ(attachPose.GetMorphWeight(0), 0.0f); // Once we auto register missing morphs this should be 0.5. See LY-100212
EXPECT_FLOAT_EQ(attachPose.GetMorphWeight(1), 0.0f); // Once we auto register missing morphs this should be 0.6. See LY-100212
EXPECT_FLOAT_EQ(attachPose.GetMorphWeight(2), 0.1f);
EXPECT_FLOAT_EQ(attachPose.GetMorphWeight(3), 0.2f);
};
@@ -471,7 +471,7 @@ namespace CopyDependencyBuilder
[[maybe_unused]] const AZStd::string& watchFolderPath) const
{
// Check the existing schema info stored in the asset database
// https://jira.agscollab.com/browse/LY-99056
// LY-99056
return SchemaMatchResult::NoMatchFound;
}
@@ -526,7 +526,7 @@ namespace CopyDependencyBuilder
{
case SchemaMatchResult::MatchFound:
// Update the LastUsedSchema info stored in the asset database
// https://jira.agscollab.com/browse/LY-99056
// LY-99056
AZ_Printf("XmlBuilderWorker", "Schema file %s found for source %s.", schemaFilePath.c_str(), sourceFilePath.c_str());
return matchResult;
case SchemaMatchResult::NoMatchFound:
@@ -943,7 +943,7 @@ void UiEditorEntityContext::InitializeEntities(const AzFramework::EntityList& en
// Because we automatically add the EditorOnlyEntityComponent if it doesn't exist, we can encounter a situation
// where an entity has duplicate EditorOnlyEntityComponents if an old canvas is resaved and an old slice it uses
// is also resaved. See https://jira.agscollab.com/browse/LY-90580
// is also resaved. See LY-90580
// In the main editor this is handled by disabling the duplicate components, but the UI Editor doesn't use that
// method (the world editor allows the user to manually add incompatible components and then disable and enable
// them in the entity, the UI Editor still works how the world editor used to - it doesn't allow users to add
@@ -582,7 +582,7 @@ namespace ScriptCanvas
int SetExecutionOut(lua_State* lua)
{
// \note Return values could become necessary.
// \see https://jira.agscollab.com/browse/LY-99750
// \see LY-99750
AZ_Assert(lua_isuserdata(lua, -3), "Error in compiled lua file, 1st argument to SetExecutionOut is not userdata (Nodeable)");
AZ_Assert(lua_isnumber(lua, -2), "Error in compiled lua file, 2nd argument to SetExecutionOut is not a number");
@@ -605,7 +605,7 @@ namespace ScriptCanvas
int SetExecutionOutResult(lua_State* lua)
{
// \note Return values could become necessary.
// \see https://jira.agscollab.com/browse/LY-99750
// \see LY-99750
AZ_Assert(lua_isuserdata(lua, -3), "Error in compiled lua file, 1st argument to SetExecutionOutResult is not userdata (Nodeable)");
AZ_Assert(lua_isnumber(lua, -2), "Error in compiled lua file, 2nd argument to SetExecutionOutResult is not a number");
@@ -3114,7 +3114,7 @@ namespace ScriptCanvas
/// NOTE: after basic iteration works correctly
/// \todo when subsequent input (from nodes connected to the break slot) looks up the slot from the node with key or the value,
/// it is going to have to find the output of the get/key value functions in BOTH the child outs of break and loop
/// https://jira.agscollab.com/browse/LY-109862 may be required for this
/// LY-109862 may be required for this
ExecutionTreePtr lastExecution = forEachLoopBody;
@@ -86,7 +86,7 @@
# return final_path
# # Commenting out debug due to https://jira.agscollab.com/browse/ATOM-1677
# # Commenting out debug due to ATOM-1677
# @pytest.mark.parametrize("platform,configuration,project,spec,sample", [
# pytest.param("win_x64_vs2017", "profile", "BaseViewer", "all", "RPI/BistroBenchmark",
# marks=pytest.mark.skipif(not WINDOWS, reason="Only supported on Windows hosts")),
@@ -52,8 +52,8 @@ def HeliosProjectFixture(request):
# These tests are run on Jenkins after other tests, to minimize time spent on Jenkins jobs.
# Verify that the correct project has been set before this test starts.
# Temporarily disabling while https://jira.agscollab.com/browse/LY-103017 is not in Helios branch
# Creating a task to revert this change later: https://jira.agscollab.com/browse/LY-103334
# Temporarily disabling while LY-103017 is not in Helios branch
# Creating a task to revert this change later: LY-103334
# Run asset processor once to process all assets, so the tests themselves can run at consistent speeds.
SubprocessUtils.SubprocessWithTimeout([buildInfo.assetProcessorBatch], engineRoot, 120)
+1 -1
View File
@@ -10,7 +10,7 @@
#
"""
This script will be used in https://jenkins.agscollab.com/view/%7ESandbox/job/PACKAGE_COPY_S3/
This script will be used in the Sandobx Jenkins job PACKAGE_COPY_S3
PACKAGE_COPY_S3 is a downstream job of nightly packaging job, it copies the nightly packages from Infra S3 bucket to Lionbridge S3 bucket based on the INCLUDE_FILTER passed from packaging job
"""
import os