birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adressing Code review comments

Browse Source 
Signed-off-by: igarri <igarri@amazon.com>
This commit is contained in:
igarri
2021-07-02 13:38:35 +01:00
parent e9f44863a4
commit 8b016f86a6
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Code/Framework/AzToolsFramework/AzToolsFramework/AssetBrowser/AssetBrowserTableModel.cpp
+6 -8
View File
@@ -14,7 +14,6 @@ namespace AzToolsFramework
{
AssetBrowserTableModel::AssetBrowserTableModel(QObject* parent /* = nullptr */)
: QSortFilterProxyModel(parent)
, m_numberOfItemsDisplayed(200)
{
setDynamicSortFilter(false);
}
@@ -89,21 +88,20 @@ namespace AzToolsFramework
int AssetBrowserTableModel::BuildTableModelMap(
const QAbstractItemModel* model, const QModelIndex& parent /*= QModelIndex()*/, int row /*= 0*/)
{
static int displayedItemsCounter = 0;
int rows = model ? model->rowCount(parent) : 0;
if (parent == QModelIndex())
{
displayedItemsCounter = 0;
m_displayedItemsCounter = 0;
}
for (int i = 0; i < rows; ++i)
for (int currentRow = 0; currentRow < rows; ++currentRow)
{
if (displayedItemsCounter < m_numberOfItemsDisplayed)
if (m_displayedItemsCounter < m_numberOfItemsDisplayed)
{
QModelIndex index = model->index(i, 0, parent);
QModelIndex index = model->index(currentRow, 0, parent);
AssetBrowserEntry* entry = GetAssetEntry(m_filterModel->mapToSource(index));
// We only wanna see the source assets.
// We only want to see the source assets.
if (entry->GetEntryType() == AssetBrowserEntry::AssetEntryType::Source)
{
beginInsertRows(parent, row, row);
@@ -112,7 +110,7 @@ namespace AzToolsFramework
Q_EMIT dataChanged(index, index);
++row;
++displayedItemsCounter;
++m_displayedItemsCounter;
}
if (model->hasChildren(index))
Code/Framework/AzToolsFramework/AzToolsFramework/AssetBrowser/AssetBrowserTableModel.h
+2 -1
View File
@@ -50,7 +50,8 @@ namespace AzToolsFramework
int BuildTableModelMap(const QAbstractItemModel* model, const QModelIndex& parent = QModelIndex(), int row = 0);
private:
int m_numberOfItemsDisplayed;
int m_numberOfItemsDisplayed = 0;
int m_displayedItemsCounter = 0;
QPointer<AssetBrowserFilterModel> m_filterModel;
QMap<int, QModelIndex> m_indexMap;
};