birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix for late compilation errors on untyped input

Browse Source 
Signed-off-by: chcurran <82187351+carlitosan@users.noreply.github.com>
This commit is contained in:
chcurran
2021-10-05 16:48:00 -07:00
parent 977d58e1a8
commit 882e72dab3
4 changed files with 3247 additions and 5229 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Grammar/AbstractCodeModel.cpp
+6
View File
@@ -4320,6 +4320,12 @@ namespace ScriptCanvas
{
AZ_Assert(execution->GetSymbol() != Symbol::FunctionDefinition, "Function definition input is not handled in AbstractCodeModel::ParseInputDatum");
if (!input.GetDataType().IsValid())
{
AddError(nullptr, aznew Internal::ParseError(execution->GetNodeId(), ParseErrors::InvalidDataTypeInInput));
return;
}
auto nodes = execution->GetId().m_node->GetConnectedNodes(input);
if (nodes.empty())
{
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Results/ErrorText.h
+1
View File
@@ -41,6 +41,7 @@ namespace ScriptCanvas
constexpr const char* InactiveGraph = "This graph defines no functions, it is never activated, and will never execute. Add a Start node or connect an event handler or define functions.";
constexpr const char* InfiniteLoopWritingToVariable = "infinite loop when writing to variable";
constexpr const char* InfiniteSelfActivationLoop = "infinite loop when activating the entity that owns this graph";
constexpr const char* InvalidDataTypeInInput = "invalid data type in input slot";
constexpr const char* MetaDataNeedsTupleTypeIdForEventCall = "Meta data needs an AzTypeId for Tuple if an EBus call returns multiple types to ScriptCanvas";
constexpr const char* MetaDataRequiredForEventCall = "Meta data is required for ACM node that is an EBus call";
constexpr const char* MissingFalseExecutionSlotOnIf = "A 'False' Execution output slot is required in an If branch node";
Gems/ScriptCanvasTesting/Assets/ScriptCanvas/UnitTests/LY_SC_UnitTest_MultipleOut.scriptcanvas
+3238 -5227
View File
File diff suppressed because it is too large Load Diff
Gems/ScriptCanvasTesting/Code/Tests/ScriptCanvas_RuntimeInterpreted.cpp
+2 -2
View File
@@ -779,7 +779,7 @@ TEST_F(ScriptCanvasTestFixture, InterpretedPrintConnectedInput)
TEST_F(ScriptCanvasTestFixture, InterpretedPrintFormatEmptyValue)
{
RunUnitTestGraph("LY_SC_UnitTest_PrintFormatEmptyValue", ExecutionMode::Interpreted);
ExpectParseError("LY_SC_UnitTest_PrintFormatEmptyValue");
}
TEST_F(ScriptCanvasTestFixture, InterpretedProperties)
@@ -819,7 +819,7 @@ TEST_F(ScriptCanvasTestFixture, InterpretedStringFormat)
TEST_F(ScriptCanvasTestFixture, InterpretedStringFormatEmptyValue)
{
RunUnitTestGraph("LY_SC_UnitTest_StringFormatEmptyValue", ExecutionMode::Interpreted);
ExpectParseError("LY_SC_UnitTest_StringFormatEmptyValue");
}
TEST_F(ScriptCanvasTestFixture, InterpretedStringFormatWithRepeatedValueName)