Code/Framework fixes

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

Code/Framework/AzCore/AzCore/Console/Console.cpp

@@ -182,7 +182,7 @@ namespace AZ
     ConsoleFunctorBase* Console::FindCommand(const char* command)
     {
         CVarFixedString lowerName(command);
-        AZStd::transform(lowerName.begin(), lowerName.end(), lowerName.begin(), [](char value) { return std::tolower(value); });
+        AZStd::to_lower(lowerName.begin(), lowerName.end());
 
         CommandMap::iterator iter = m_commands.find(lowerName);
         if (iter != m_commands.end())
@@ -270,7 +270,7 @@ namespace AZ
         }
 
         CVarFixedString lowerName = functor->GetName();
-        AZStd::transform(lowerName.begin(), lowerName.end(), lowerName.begin(), [](char value) { return std::tolower(value); });
+        AZStd::to_lower(lowerName.begin(), lowerName.end());
         CommandMap::iterator iter = m_commands.find(lowerName);
         if (iter != m_commands.end())
         {
@@ -313,7 +313,7 @@ namespace AZ
         }
 
         CVarFixedString lowerName = functor->GetName();
-        AZStd::transform(lowerName.begin(), lowerName.end(), lowerName.begin(), [](char value) { return std::tolower(value); });
+        AZStd::to_lower(lowerName.begin(), lowerName.end());
         CommandMap::iterator iter = m_commands.find(lowerName);
         if (iter != m_commands.end())
         {
@@ -389,7 +389,7 @@ namespace AZ
         ConsoleFunctorFlags flags = ConsoleFunctorFlags::Null;
 
         CVarFixedString lowerName(command);
-        AZStd::transform(lowerName.begin(), lowerName.end(), lowerName.begin(), [](char value) { return std::tolower(value); });
+        AZStd::to_lower(lowerName.begin(), lowerName.end());
 
         CommandMap::iterator iter = m_commands.find(lowerName);
         if (iter != m_commands.end())

Code/Framework/AzCore/AzCore/IO/Path/Path.inl

@@ -221,7 +221,7 @@ namespace AZ::IO::Internal
             ? strncmp(left.data(), right.data(), maxCharsToCompare)
             : azstrnicmp(left.data(), right.data(), maxCharsToCompare);
         return charCompareResult == 0
-            ? aznumeric_cast<ptrdiff_t>(left.size()) - aznumeric_cast<ptrdiff_t>(right.size())
+            ? aznumeric_cast<int>(aznumeric_cast<ptrdiff_t>(left.size()) - aznumeric_cast<ptrdiff_t>(right.size()))
             : charCompareResult;
     }
 }

Code/Framework/AzCore/AzCore/IO/Streamer/BlockCache.cpp

@@ -38,7 +38,7 @@ namespace AZ
                 break;
             }
 
-            u32 cacheSize = m_cacheSizeMib * 1_mib;
+            u32 cacheSize = static_cast<AZ::u32>(m_cacheSizeMib * 1_mib);
             if (blockSize * 2 > cacheSize)
             {
                 AZ_Warning("Streamer", false, "Size (%u) for BlockCache isn't big enough to hold at least two cache blocks of size (%zu). "

Code/Framework/AzCore/AzCore/IO/Streamer/DedicatedCache.cpp

@@ -36,7 +36,7 @@ namespace AZ
                 break;
             }
 
-            u32 cacheSize = m_cacheSizeMib * 1_mib;
+            u32 cacheSize = static_cast<AZ::u32>(m_cacheSizeMib * 1_mib);
             if (blockSize > cacheSize)
             {
                 AZ_Warning("Streamer", false, "Size (%u) for DedicatedCache isn't big enough to hold at least one cache blocks of size (%zu). "

Code/Framework/AzCore/AzCore/StringFunc/StringFunc.cpp

@@ -11,6 +11,7 @@
 #include <AzCore/std/string/conversions.h>
 #include <AzCore/std/containers/array.h>
 #include <AzCore/std/containers/fixed_vector.h>
+#include <AzCore/Casting/lossy_cast.h>
 #include <AzCore/Memory/Memory.h>
 #include <AzCore/Memory/OSAllocator.h>
 #include <AzCore/Memory/SystemAllocator.h>
@@ -342,8 +343,8 @@ namespace AZ::StringFunc::Internal
         {
             for (const char stripCharacter : stripCharacters)
             {
-                const char lower = tolower(stripCharacter);
-                const char upper = toupper(stripCharacter);
+                const char lower = azlossy_cast<char>(tolower(stripCharacter));
+                const char upper = azlossy_cast<char>(toupper(stripCharacter));
                 if (lower != upper)
                 {
                     combinedStripCharacters.push_back(lower);

Code/Framework/AzCore/Tests/AZTestShared/Math/MathTestHelpers.cpp

@@ -95,7 +95,7 @@ namespace AZ
         auto printElement = [&os, &mat](int64_t row, int64_t col) -> std::ostream&
         {
             const std::streamsize width = 10;
-            os << std::setw(width) << std::fixed << mat.GetElement(row, col);
+            os << std::setw(width) << std::fixed << mat.GetElement(static_cast<int32_t>(row), static_cast<int32_t>(col));
             return os;
         };
 

Code/Framework/AzCore/Tests/Serialization/Json/IntSerializerTests.cpp

@@ -32,12 +32,12 @@ namespace JsonSerializationTests
 
         AZStd::shared_ptr<NumberType> CreateDefaultInstance() override
         {
-            return AZStd::make_shared<NumberType>(0);
+            return AZStd::make_shared<NumberType>(NumberType(0));
         }
 
         AZStd::shared_ptr<NumberType> CreateFullySetInstance() override
         {
-            return AZStd::make_shared<NumberType>(4);
+            return AZStd::make_shared<NumberType>(NumberType(4));
         }
 
         AZStd::string_view GetJsonForFullySetInstance() override