birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove -Wno-comment warning suppression

Browse Source 
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
This commit is contained in:
Steve Pham
2022-02-01 09:04:32 -08:00
committed by GitHub
parent 3f63cf3546
commit 71cc3a2568
12 changed files with 501 additions and 477 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/Atom/RPI/Code/Tests/Model/ModelTests.cpp
+27 -25
View File
@@ -976,14 +976,14 @@ namespace UnitTest
EXPECT_EQ(uvStreamTangentBitmask.GetFullTangentBitmask(), 0x70000F51);
}
//
// +----+
// / /|
// +----+ |
// | | +
// | |/
// +----+
//
/*
+----+
/ /|
+----+ |
| | +
| |/
+----+
*/
static constexpr AZStd::array CubePositions = { -1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, 1.0f, -1.0f, 1.0f,
-1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f, -1.0f, 1.0f, -1.0f, -1.0f };
static constexpr AZStd::array CubeIndices = {
@@ -993,23 +993,25 @@ namespace UnitTest
static constexpr AZStd::array QuadPositions = { -1.0f, 1.0f, 0.0f, 1.0f, 1.0f, 0.0f, -1.0f, -1.0f, 0.0f, 1.0f, -1.0f, 0.0f };
static constexpr AZStd::array QuadIndices = { uint32_t{ 0 }, 2, 1, 1, 2, 3 };
// This class creates a Model with one LOD, whose mesh contains 2 planes. Plane 1 is in the XY plane at Z=-0.5, and
// plane 2 is in the XY plane at Z=0.5. The two planes each have 9 quads which have been triangulated. It only has
// a position and index buffer.
//
// -0.33
// -1 0.33 1
// 0.5 *---*---*---*
// \ / \ / \ / \
// *---*---*---*
// \ / \ / \ / \
// -0.5 *- *---*---*---*
// \ \ / \ / \ / \
// *- *---*---*---*
// \ \ \ \
// *---*---*---*
// \ / \ / \ / \
// *---*---*---*
/*
This class creates a Model with one LOD, whose mesh contains 2 planes. Plane 1 is in the XY plane at Z=-0.5, and
plane 2 is in the XY plane at Z=0.5. The two planes each have 9 quads which have been triangulated. It only has
a position and index buffer.
-0.33
-1 0.33 1
0.5 *---*---*---*
\ / \ / \ / \
*---*---*---*
\ / \ / \ / \
-0.5 *- *---*---*---*
\ \ / \ / \ / \
*- *---*---*---*
\ \ \ \
*---*---*---*
\ / \ / \ / \
*---*---*---*
*/
static constexpr AZStd::array TwoSeparatedPlanesPositions{
-1.0f, -0.333f, -0.5f, -0.333f, -1.0f, -0.5f, -0.333f, -0.333f, -0.5f, 0.333f, -0.333f, -0.5f, 1.0f, -1.0f, -0.5f,
1.0f, -0.333f, -0.5f, 0.333f, -1.0f, -0.5f, 0.333f, 1.0f, -0.5f, 1.0f, 0.333f, -0.5f, 1.0f, 1.0f, -0.5f,
Gems/Atom/RPI/Code/Tests/Shader/ShaderTests.cpp
+15 -14
View File
@@ -1666,20 +1666,21 @@ namespace UnitTest
EXPECT_FALSE(result7.IsFullyBaked());
EXPECT_EQ(result7.GetStableId().GetIndex(), stableId7);
// All searches so far found exactly the node we were looking for
// The next couple of searches will not find the requested node
// and will instead default to its parent, up the tree to the root
//
// [] [Root]
// / \
// [Color] [Teal] [Fuchsia]
// / \
// [Quality] [Sublime] [Auto]
// /
// [NumberSamples] [50]
// / \
// [Raytracing] [On] [Off]
/*
All searches so far found exactly the node we were looking for
The next couple of searches will not find the requested node
and will instead default to its parent, up the tree to the root
[] [Root]
/ \
[Color] [Teal] [Fuchsia]
/ \
[Quality] [Sublime] [Auto]
/
[NumberSamples] [50]
/ \
[Raytracing] [On] [Off]
*/
// ----------------------------------------
// [Quality::Poor]