Fix function signature of binary +/- operator to not return a reference (#1285)

This function creates a new object on the stack, and was returning it as
a reference. This would trigger Clang 12's `-Wreturn-stack-address`
warning, and cause the build to fail.

This fixes builds with clang 12, so it closes #591
This commit is contained in:
Chris Burel
2021-06-14 08:09:28 -07:00
committed by GitHub
parent fb4cac08a3
commit 6d92f7109f
+2 -2
View File
@@ -1154,13 +1154,13 @@ struct DiskOperationInfo
return *this;
}
DiskOperationInfo& operator - (const DiskOperationInfo& rv)
DiskOperationInfo operator - (const DiskOperationInfo& rv)
{
DiskOperationInfo res(*this);
return res -= rv;
}
DiskOperationInfo& operator + (const DiskOperationInfo& rv)
DiskOperationInfo operator + (const DiskOperationInfo& rv)
{
DiskOperationInfo res(*this);
return res += rv;