Merge branch 'development' into cmake/AddressSanitizer
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
This commit is contained in:
@@ -37,11 +37,6 @@ ly_append_configurations_options(
|
||||
# Disabling some warnings
|
||||
/wd4201 # nonstandard extension used: nameless struct/union. This actually became part of the C++11 std, MS has an open issue: https://developercommunity.visualstudio.com/t/warning-level-4-generates-a-bogus-warning-c4201-no/103064
|
||||
|
||||
# Disabling these warnings while they get fixed
|
||||
/wd4244 # conversion, possible loss of data
|
||||
/wd4245 # conversion, signed/unsigned mismatch
|
||||
/wd4389 # comparison, signed/unsigned mismatch
|
||||
|
||||
# Enabling warnings that are disabled by default from /W4
|
||||
# https://docs.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default?view=vs-2019
|
||||
# /we4296 # 'operator': expression is always false
|
||||
@@ -135,8 +130,6 @@ endif()
|
||||
ly_set(LY_CXX_SYSTEM_INCLUDE_CONFIGURATION_FLAG
|
||||
/experimental:external # Turns on "external" headers feature for MSVC compilers
|
||||
/external:W0 # Set warning level in external headers to 0. This is used to suppress warnings 3rdParty libraries which uses the "system_includes" option in their json configuration
|
||||
/wd4193 # Temporary workaround for the /experiment:external feature generating warning C4193: #pragma warning(pop): no matching '#pragma warning(push)'
|
||||
/wd4702 # Despite we set it to W0, we found that 3rdParty::OpenMesh was issuing these warnings while using some template functions. Disabling it here does the trick
|
||||
)
|
||||
if(NOT CMAKE_INCLUDE_SYSTEM_FLAG_CXX)
|
||||
ly_set(CMAKE_INCLUDE_SYSTEM_FLAG_CXX /external:I)
|
||||
|
||||
Reference in New Issue
Block a user