From 60e14d3a4ca82b9f183a46195d57e555f4937ee9 Mon Sep 17 00:00:00 2001 From: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com> Date: Thu, 28 Oct 2021 18:17:26 -0700 Subject: [PATCH] Fixes PR comments Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com> --- cmake/Platform/Windows/Packaging_windows.cmake | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cmake/Platform/Windows/Packaging_windows.cmake b/cmake/Platform/Windows/Packaging_windows.cmake index e5aeef6209..7b8f5a6c19 100644 --- a/cmake/Platform/Windows/Packaging_windows.cmake +++ b/cmake/Platform/Windows/Packaging_windows.cmake @@ -8,7 +8,6 @@ set(LY_INSTALLER_WIX_ROOT "" CACHE PATH "Path to the WiX install path") -message("LY_INSTALLER_WIX_ROOT ${LY_INSTALLER_WIX_ROOT}") if(LY_INSTALLER_WIX_ROOT) if(NOT EXISTS ${LY_INSTALLER_WIX_ROOT}) message(FATAL_ERROR "Invalid path supplied for LY_INSTALLER_WIX_ROOT argument") @@ -106,9 +105,8 @@ set(_raw_text_license [[ #(loc.InstallEulaAcceptance) ]]) -# if we are doing an offline installer, there is a limit in size the wix tooling can handle and produces -# issues for our current sizes. If the installer is offline, disable the curstom wix generator generating -# a msi instead. +# The offline installer generation will be a single monolithic MSI. The WIX burn tool for the bootstrapper EXE has a size limitation. +# So we will exclude the generation of the boostrapper EXE in the offline case. if(LY_INSTALLER_DOWNLOAD_URL) set(WIX_THEME_WARNING_IMAGE ${CPACK_SOURCE_DIR}/Platform/Windows/Packaging/warning.png)