birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix infinite loop due to thin triangles (#4027)

Browse Source 
* fix infinite loop due to thin triangles

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>

* check exact triangles size

Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
This commit is contained in:
Alex Peterson
2021-09-10 14:10:49 -07:00
committed by GitHub
parent 3535d6b6b3
commit 5bf749dcac
2 changed files with 39 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/LmbrCentral/Code/Source/Shape/ShapeGeometryUtil.cpp
+6 -5
View File
@@ -152,17 +152,18 @@ namespace LmbrCentral
const AZ::Vector2 edgeAfter = next - curr;
const float triangleArea = Wedge(edgeBefore, edgeAfter);
const float tolerance = 0.001f;
const bool interiorVertex = triangleArea <= 0.0f;
// if triangle is not an 'ear', continue.
if (!interiorVertex)
// if triangle is not an 'ear' and we have other vertices, continue.
if (!interiorVertex && vertices.size() > 3)
{
continue;
}
// check no other vertices are inside the triangle formed
// by these three vertices, if so, continue to next vertex.
if (vertices.size() > 3)
// check if this is a large enough triangle, that there are no other vertices
// inside the triangle formed, otherwise, continue to next vertex.
if (vertices.size() > 3 && !AZ::IsClose(triangleArea, 0.f, tolerance))
{
bool pointInside = false;
for (size_t j = (nextIndex + 1) % vertices.size(); j != prevIndex; j = (j + 1) % vertices.size())