From 5b0f3450525f42b24564706f9e51d3f8e44d3171 Mon Sep 17 00:00:00 2001 From: jromnoa <80134229+jromnoa@users.noreply.github.com> Date: Tue, 2 Nov 2021 00:03:50 -0700 Subject: [PATCH] PR fixes to clean up syntax and variable names also to remove a change from another PR Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com> --- .../PythonTests/Atom/atom_utils/atom_component_helper.py | 8 ++++---- .../Gem/PythonTests/Atom/atom_utils/atom_constants.py | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/AutomatedTesting/Gem/PythonTests/Atom/atom_utils/atom_component_helper.py b/AutomatedTesting/Gem/PythonTests/Atom/atom_utils/atom_component_helper.py index 0291b3efba..50cc15f7e8 100644 --- a/AutomatedTesting/Gem/PythonTests/Atom/atom_utils/atom_component_helper.py +++ b/AutomatedTesting/Gem/PythonTests/Atom/atom_utils/atom_component_helper.py @@ -77,20 +77,20 @@ def compare_screenshot_similarity( :return: Error string if compared mean value < similarity threshold or screenshot_directory is missing for .zip, otherwise it returns a "Screenshots match" string. """ - error = "Screenshots match" + result = "Screenshots match" if create_zip_archive and not screenshot_directory: - error = 'You must specify a screenshot_directory in order to create a zip archive.\n' + result = 'You must specify a screenshot_directory in order to create a zip archive.\n' mean_similarity = compare_screenshots(test_screenshot, golden_image) if not mean_similarity > similarity_threshold: if create_zip_archive: create_screenshots_archive(screenshot_directory) - error = ( + result = ( f"When comparing the test_screenshot: '{test_screenshot}' " f"to golden_image: '{golden_image}' the mean similarity of '{mean_similarity}' " f"was lower than the similarity threshold of '{similarity_threshold}'. ") - return error + return result def create_basic_atom_level(level_name): diff --git a/AutomatedTesting/Gem/PythonTests/Atom/atom_utils/atom_constants.py b/AutomatedTesting/Gem/PythonTests/Atom/atom_utils/atom_constants.py index 3578ec9aa4..344a0dbd29 100644 --- a/AutomatedTesting/Gem/PythonTests/Atom/atom_utils/atom_constants.py +++ b/AutomatedTesting/Gem/PythonTests/Atom/atom_utils/atom_constants.py @@ -218,7 +218,6 @@ class AtomComponentProperties: properties = { 'name': 'HDR Color Grading', 'requires': [AtomComponentProperties.postfx_layer()], - 'Enable HDR color grading': 'Controller|Configuration|LUT Generation|Enable HDR color grading', } return properties[property]