From 585caabd950dc7abdee2efe3e29f0dbebb8ac020 Mon Sep 17 00:00:00 2001
From: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com>
Date: Mon, 12 Jul 2021 11:38:05 -0700
Subject: [PATCH] [installer/2106-3p-license-fix] replaced 3rd party license
 url arg with auto generated one from version string

Signed-off-by: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com>
---
 cmake/Packaging.cmake | 55 ++++++++++++++++++++-----------------------
 1 file changed, 25 insertions(+), 30 deletions(-)

diff --git a/cmake/Packaging.cmake b/cmake/Packaging.cmake
index d77b5a30f8..a07e1ec1d3 100644
--- a/cmake/Packaging.cmake
+++ b/cmake/Packaging.cmake
@@ -125,37 +125,32 @@ install(FILES ${_cmake_package_dest}
     DESTINATION ./Tools/Redistributables/CMake
 )
 
-# temporary workaround for acquiring the 3rd party SPDX license manifest, the desired location is from
-# another git repository that's private.  once it's public, only how the URL is formed should change
-set(LY_INSTALLER_3RD_PARTY_LICENSE_URL "" CACHE STRING "URL to the 3rd party SPDX license manifest file for inclusion in packaging.")
-
-if(${LY_VERSION_STRING} VERSION_GREATER "0.0.0.0" AND NOT LY_INSTALLER_3RD_PARTY_LICENSE_URL)
-    message(FATAL_ERROR "Missing required URL for the 3rd party SPDX license manifest file.  "
-        "Please specifiy where to acquire the file via LY_INSTALLER_3RD_PARTY_LICENSE_URL")
-endif()
-
-string(REPLACE "/" ";" _url_components ${LY_INSTALLER_3RD_PARTY_LICENSE_URL})
-list(POP_BACK _url_components _3rd_party_license_filename)
-
-set(_3rd_party_license_dest ${CPACK_BINARY_DIR}/${_3rd_party_license_filename})
-
-# use the plain file downloader as we don't have the file hash available and using a dummy will
-# delete the file once it fails hash verification
-file(DOWNLOAD
-    ${LY_INSTALLER_3RD_PARTY_LICENSE_URL}
-    ${_3rd_party_license_dest}
-    STATUS _status
-    TLS_VERIFY ON
-)
-list(POP_FRONT _status _status_code)
-
-if (${_status_code} EQUAL 0 AND EXISTS ${_3rd_party_license_dest})
-    install(FILES ${_3rd_party_license_dest}
-        DESTINATION .
+# the version string and git tags are intended to be synchronized so it should be safe to use that instead
+# of directly calling into git which could get messy in certain scenarios
+if(${CPACK_PACKAGE_VERSION} VERSION_GREATER "0.0.0.0")
+    set(_3rd_party_license_filename SPDX-Licenses.txt)
+
+    set(_3rd_party_license_url "https://raw.githubusercontent.com/o3de/3p-package-source/${CPACK_PACKAGE_VERSION}/${_3rd_party_license_filename}")
+    set(_3rd_party_license_dest ${CPACK_BINARY_DIR}/${_3rd_party_license_filename})
+
+    # use the plain file downloader as we don't have the file hash available and using a dummy will
+    # delete the file once it fails hash verification
+    file(DOWNLOAD
+        ${_3rd_party_license_url}
+        ${_3rd_party_license_dest}
+        STATUS _status
+        TLS_VERIFY ON
     )
-else()
-    file(REMOVE ${_3rd_party_license_dest})
-    message(FATAL_ERROR "Failed to acquire the 3rd Party license manifest file.  Error: ${_status}")
+    list(POP_FRONT _status _status_code)
+
+    if (${_status_code} EQUAL 0 AND EXISTS ${_3rd_party_license_dest})
+        install(FILES ${_3rd_party_license_dest}
+            DESTINATION .
+        )
+    else()
+        file(REMOVE ${_3rd_party_license_dest})
+        message(FATAL_ERROR "Failed to acquire the 3rd Party license manifest file at ${_3rd_party_license_url}.  Error: ${_status}")
+    endif()
 endif()
 
 # checks for and removes trailing slash