Cry Legacy: the Lessening (#5961)

* Generic Cleanup

Removals:

* Unused cvars,member variables and defines
* Windows media center edition support routines
* CSystem - removed debug_GetCallStackRaw/GetRootWindowMessageHandler/
UnloadDLL/ShutdownModuleLibraries

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Fix CryMessageBox return values in Windows build

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove named selection group and a few smaller unused functionalities

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove ObjectManager export functionality + 2 deprecated functions

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove object legacy freeze/hide support from ObjectManager

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove ObjectManager duplicate name dection, as well as object renaming

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove ObjectManager serialization and selection callbacks

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* ObjectManager - remove MoveObjects/HitTestObject/EndEditParams and related members/functions

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove a bunch of unused clone related functionality + misc

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* ObjectManager - misc removals

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* ObjectManager - more removals

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove unused object selection/retrieval in ObjectManager and LoadObjects in ObjectLoader

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* CBaseObject - remove unused material layers mask support

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* More CBaseObject cleanups.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* CBaseObject - remove SubObj functions and IMouseCreateCallback

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove unused procedural floor management, helper scale and tags.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* CBaseObject - remove more unused methods.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Removals in multiple places.

CBaseObject - unused `OBJTYPE_DUMMY` flag removed, member `IsSameClass`
CObjectArchive removed unused methods/members
CObjectManager removed unused `Update` method

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* More removals

IDisplayViewport - HitTestLine/GetGridStep/setHitcontext/
GetConstructionPlane
Unused Cry_Matrix44 template specializations.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* O3DE.exe Project-Centric "Open Editor" fix (#5852)

* The O3DE.exe Open Editor button now attempts to open the Editor in the
build directory of the project being opened.

If their is no Editor within the build directory of the Project, it uses
the Editor.exe in the current O3DE.exe executable directory if it exists

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Engine .gitignore now ignores the build directory if placed in the
AutomatedTesting project

Previously it was just ignoring a `[Bb]uild` directory if it was
directly within the engine root.
This change matches the behavior of the project templates.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Renamed the ProjectUtils GetEditorDirectory function to
GetEditorExecutablePath

Added a platform specific implementation for retrieving the path to the
Editor executable in the GetEditorExectuablePath function.

It first attempts to locate the Editor via checking the project build
directory for an Editor executable before falling back to checking the
binary directory of the currently running O3DE executable.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Correct the MacOS GetEditorExecutablePath to return the Editor path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Adding missing C++20 std::erase implementations (#5735)

There were already implementations for std::erase_if.
This adds the counterpart AZStd::erase versions

resolves #5734

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* More removals and refactors

`ShowMessage` and `CryMessageBox` return void now
Simplify code in `CSystem::WarningV`
Remove unused `CryGetTicksPerSec`
Remove unused WinBase functionality
Replace `nanosleep` call in WinBase with `std::this_thread::sleep_for`
Remove unused Win32Wrapper routines
Remove unused IFunctorBase.h and IEntityObjectListener.h
Fix VectorAndArray.cpp compilation
Use QMessageBox instead of CryMessageBox in the editor.
Remove empty ArchiveVars platform specific files

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Fix test code.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove an unused  function

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* CBaseObject and undo description removals.

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* A bunch of removals

* Remove IRenderNode
* Remove editor's KDTree
* Remove StatObjBus, InstanceStatObjEventBus::ReleaseData is redundant (
same functionality in the only available handler is triggered by
`OnCryEditorCloseScene`)
* Remove CExportManager::AddStatObj/AddMeshes/AddMesh,
IExportManager::ExportSingleStatObj
* Remove CIconManager/IIconManager::GetObject
* Remove CBaseObject::IntersectRayMesh
* Remove IIndexedMesh and related structs.
* Unused IUndoObject::GetDescription and all derived implementations.
* Unused CUndoBaseLibrary/CUndoBaseLibraryManager
* Unused Matrix34_tpl typedefs
* Legacy Xml classes cleanup

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* Remove unused `Vec3ToVector3D` helper

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

* fix - remove unused static variable

Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com>

Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

Code/Editor/Objects/ObjectManagerLegacyUndo.h

@@ -24,12 +24,11 @@ public:
     CUndoBaseObjectNew(CBaseObject* object);
 
 protected:
-    virtual int GetSize() override { return sizeof(*this); }; // Return size of xml state.
-    virtual QString GetDescription() override { return "New BaseObject"; };
-    virtual QString GetObjectName() override { return m_object->GetName(); };
+    int GetSize() override { return sizeof(*this); } // Return size of xml state.
+    QString GetObjectName() override { return m_object->GetName(); }
 
-    virtual void Undo(bool bUndo) override;
-    virtual void Redo() override;
+    void Undo(bool bUndo) override;
+    void Redo() override;
 
 private:
     CBaseObjectPtr m_object;
@@ -47,12 +46,11 @@ public:
     CUndoBaseObjectDelete(CBaseObject* object);
 
 protected:
-    virtual int GetSize() override { return sizeof(*this); }; // Return size of xml state.
-    virtual QString GetDescription() override { return "Delete BaseObject"; };
-    virtual QString GetObjectName() override { return m_object->GetName(); };
+    int GetSize() override { return sizeof(*this); } // Return size of xml state.
+    QString GetObjectName() override { return m_object->GetName(); }
 
-    virtual void Undo(bool bUndo) override;
-    virtual void Redo() override;
+    void Undo(bool bUndo) override;
+    void Redo() override;
 
 private:
     CBaseObjectPtr m_object;
@@ -73,20 +71,19 @@ public:
     * This Undo command can be used for either Legacy or Component Entities, though for
     * performance reasons Component Entities are typically undone using CUndoBaseObjectBulkSelect
     *
-    * @param pObj The object to perform the undo/redo operation on.
+    * @param object The object to perform the undo/redo operation on.
     * @param isSelect This is true if you are trying to undo a select operation, and false if
     *        trying to undo a deselect operation
     */
     CUndoBaseObjectSelect(CBaseObject* object, bool isSelect);
 
 protected:
-    virtual void Release() override { delete this; };
-    virtual int GetSize() override { return sizeof(*this); }; // Return size of xml state.
-    virtual QString GetDescription() override { return "Select Object"; };
-    virtual QString GetObjectName() override; 
+    void Release() override { delete this; }
+    int GetSize() override { return sizeof(*this); } // Return size of xml state.
+    QString GetObjectName() override; 
 
-    virtual void Undo(bool bUndo) override;
-    virtual void Redo() override;
+    void Undo(bool bUndo) override;
+    void Redo() override;
 
 private:
     GUID m_guid;
@@ -116,7 +113,6 @@ public:
 
 protected:
     int GetSize() override { return sizeof(*this); } // Return size of xml state.
-    QString GetDescription() override { return QObject::tr("Select Objects"); }
 
     /*
     * Deselects the objects
@@ -153,7 +149,6 @@ public:
 
 protected:
     int GetSize() override { return sizeof(*this); } // Return size of xml state.
-    QString GetDescription() override { return QObject::tr("Select Objects"); }
 
     void Undo(bool bUndo) override;