birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ftue_auto_register] use early return in registered engines loop instead of break

Browse Source
This commit is contained in:
scottr
2021-06-02 08:46:57 -07:00
parent 39d1f27021
commit 5554bdf329
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Code/Tools/ProjectManager/Source/PythonBindings.cpp
+3 -9
View File
@@ -320,8 +320,6 @@ namespace O3DE::ProjectManager
bool pythonResult = ExecuteWithLock(
[&]
{
bool registerThis = true;
// check current engine path against all other registered engines
// to see if we are already registered
auto allEngines = m_manifest.attr("get_engines")();
@@ -332,17 +330,13 @@ namespace O3DE::ProjectManager
AZ::IO::FixedMaxPath enginePath(Py_To_String(engine["path"]));
if (enginePath.Compare(m_enginePath) == 0)
{
registerThis = false;
break;
return;
}
}
}
if (registerThis)
{
auto result = m_register.attr("register")(m_enginePath.c_str());
registrationResult = (result.cast<int>() == 0);
}
auto result = m_register.attr("register")(m_enginePath.c_str());
registrationResult = (result.cast<int>() == 0);
});
bool finalResult = (registrationResult && pythonResult);