From 210732334e1c30d82122cd9d73337a24782b7b94 Mon Sep 17 00:00:00 2001 From: mcphedar Date: Wed, 7 Jul 2021 15:10:50 -0500 Subject: [PATCH 1/5] Updating this template with correct labels Signed-off-by: mcphedar --- .github/ISSUE_TEMPLATE/ar_bug_report-md.md | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/ar_bug_report-md.md b/.github/ISSUE_TEMPLATE/ar_bug_report-md.md index e2f64b88b8..0d4aee9397 100644 --- a/.github/ISSUE_TEMPLATE/ar_bug_report-md.md +++ b/.github/ISSUE_TEMPLATE/ar_bug_report-md.md @@ -1,17 +1,8 @@ --- name: ar_bug_report.md about: Create a bug for a an issue found in the Automated Review -title: '' -labels: '' -assignees: '' - ---- - ---- -name: Automated Review Bug report -about: Create a report when a failure occurs in main branch -title: '' -labels: 'Automated_Review' +title: 'AR Bug Report' +labels: 'needs-triage,kind/bug,kind/automation' assignees: '' --- From 93db356fbb60df4dce08a36a9cb75481fe3d9fa2 Mon Sep 17 00:00:00 2001 From: mcphedar Date: Wed, 7 Jul 2021 15:23:25 -0500 Subject: [PATCH 2/5] Updating templates Signed-off-by: mcphedar --- .github/ISSUE_TEMPLATE/{ar_bug_report-md.md => ar_bug_report.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/ISSUE_TEMPLATE/{ar_bug_report-md.md => ar_bug_report.md} (100%) diff --git a/.github/ISSUE_TEMPLATE/ar_bug_report-md.md b/.github/ISSUE_TEMPLATE/ar_bug_report.md similarity index 100% rename from .github/ISSUE_TEMPLATE/ar_bug_report-md.md rename to .github/ISSUE_TEMPLATE/ar_bug_report.md From fa1375d7c67180d40147327b4b7cb8f3ef9aa3e5 Mon Sep 17 00:00:00 2001 From: Royal OBrien Date: Wed, 7 Jul 2021 13:49:27 -0700 Subject: [PATCH 3/5] Adding contributing guide pointer markdown (#1928) Signed-off-by: Royal OBrien --- CONTRIBUTING.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000000..ba7f134922 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,14 @@ +# Contributing + +Welcome to the Open 3D Engine! To learn more about contributing to the [O3DE code repo](README.md), check out the [Contributor's Guide](https://github.com/o3de/community/blob/main/CONTRIBUTING.md). + +The [O3DE community repo](https://github.com/o3de/community) contains information about how to get started, how the community organizes, and more. + +To contribute, please review our [Code of Conduct](https://github.com/o3de/o3de/blob/development/CODE_OF_CONDUCT.md) first. + +## Making contributions with the Developer Certificate of Origin (DCO) + +When contributing, your pull requests will require that you have agreed to our DCO found here: [Devloper Certificate of Origin](https://developercertificate.org/) + +You can do this by using the -s option in git. +Example: ```git commit -s -m 'my commit message'``` \ No newline at end of file From 302fef2ec81c6c0a803a6e9e14172ac45085e565 Mon Sep 17 00:00:00 2001 From: amzn-phist <52085794+amzn-phist@users.noreply.github.com> Date: Wed, 7 Jul 2021 16:22:52 -0500 Subject: [PATCH 4/5] Update Wwise version info in Readme.md (#1910) * Update Wwise version info in Readme.md Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com> * Updates to Wwise readme text Correct capitalization of 'Wwise' and add info about selecting the SDK(C++) component. Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com> --- README.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 9cc816efe9..83acec1313 100644 --- a/README.md +++ b/README.md @@ -85,10 +85,11 @@ If you have the Git credential manager core or other credential helpers installe #### Optional -* WWise - 2019.2.8.7432 minimum: [https://www.audiokinetic.com/download/](https://www.audiokinetic.com/download/) - * Note: This requires registration and installation of a client to download - * You will also need to set a environment variable: `set LY_WWISE_INSTALL_PATH=` - * For example: `set LY_WWISE_INSTALL_PATH="C:\Program Files (x86)\Audiokinetic\Wwise 2019.2.8.7432"` +* Wwise - 2021.1.1.7601 minimum: [https://www.audiokinetic.com/download/](https://www.audiokinetic.com/download/) + * Note: This requires registration and installation of a client application to download + * Make sure to select the SDK(C++) component during installation of Wwise + * You will also need to set an environment variable: `set LY_WWISE_INSTALL_PATH=` + * For example: `set LY_WWISE_INSTALL_PATH="C:\Program Files (x86)\Audiokinetic\Wwise 2021.1.1.7601"` ### Quick Start Build Steps From ec026963b8a6440b755aecd622864e43b0603c48 Mon Sep 17 00:00:00 2001 From: Jeongseok Lee Date: Wed, 7 Jul 2021 18:18:48 -0700 Subject: [PATCH 5/5] Create 3rd-party directory if not exists (#1877) Signed-off-by: Jeongseok Lee --- cmake/3rdParty.cmake | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmake/3rdParty.cmake b/cmake/3rdParty.cmake index 15dde3c3f8..96d59e6105 100644 --- a/cmake/3rdParty.cmake +++ b/cmake/3rdParty.cmake @@ -29,6 +29,9 @@ set(LY_3RDPARTY_PATH "${o3de_default_third_party_path}" CACHE PATH "Path to the if(LY_3RDPARTY_PATH) file(TO_CMAKE_PATH ${LY_3RDPARTY_PATH} LY_3RDPARTY_PATH) + if(NOT EXISTS ${LY_3RDPARTY_PATH}) + file(MAKE_DIRECTORY ${LY_3RDPARTY_PATH}) + endif() endif() if(NOT EXISTS ${LY_3RDPARTY_PATH}) message(FATAL_ERROR "3rdParty folder: ${LY_3RDPARTY_PATH} does not exist, call cmake defining a valid LY_3RDPARTY_PATH or use cmake-gui to configure it")