From 53a6e5ac6becd69d9c76ea63ae5e60b86ae4ad42 Mon Sep 17 00:00:00 2001 From: mbalfour Date: Tue, 4 May 2021 10:08:59 -0500 Subject: [PATCH] Addressed feedback. --- Code/Framework/AzCore/AzCore/Asset/AssetContainer.cpp | 4 ++-- .../AzCore/Tests/Asset/AssetManagerStreamingTests.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Code/Framework/AzCore/AzCore/Asset/AssetContainer.cpp b/Code/Framework/AzCore/AzCore/Asset/AssetContainer.cpp index 50c382d7da..2ff6143912 100644 --- a/Code/Framework/AzCore/AzCore/Asset/AssetContainer.cpp +++ b/Code/Framework/AzCore/AzCore/Asset/AssetContainer.cpp @@ -243,8 +243,8 @@ namespace AZ // *After* setting initComplete to true, check to see if the assets are already ready. // This check needs to wait until after setting initComplete because if they *are* ready, we want the final call to - // RemoveWaitingAsset to trigger the OnAssetContainer* event. If we call CheckReady() *before* setting initComplete, - // if all the assets are ready, the event will never get triggered. + // RemoveWaitingAsset to trigger the OnAssetContainerReady/Canceled event. If we call CheckReady() *before* setting + // initComplete, if all the assets are ready, the event will never get triggered. CheckReady(); } diff --git a/Code/Framework/AzCore/Tests/Asset/AssetManagerStreamingTests.cpp b/Code/Framework/AzCore/Tests/Asset/AssetManagerStreamingTests.cpp index f5e2a880d5..c55a95cf2a 100644 --- a/Code/Framework/AzCore/Tests/Asset/AssetManagerStreamingTests.cpp +++ b/Code/Framework/AzCore/Tests/Asset/AssetManagerStreamingTests.cpp @@ -351,7 +351,7 @@ namespace UnitTest public AZ::Data::AssetCatalog { static inline const AZ::Uuid TestAssetId{"{E970B177-5F45-44EB-A2C4-9F29D9A0B2A2}"}; - static inline const char* TestAssetPath{"test"}; + static inline constexpr AZStd::string_view TestAssetPath = "test"; void SetUp() override {