Remove (almost) all references to pRenderer (#651)

Remove all references to pRenderer, except from the DebugDraw and LyShine Gems that are still being updated.

Code/Sandbox/Editor/Controls/ReflectedPropertyControl/PropertyCtrl.cpp

@@ -28,7 +28,6 @@ void RegisterReflectedVarHandlers()
         registered = true;
         EBUS_EVENT(AzToolsFramework::PropertyTypeRegistrationMessages::Bus, RegisterPropertyType, aznew AnimationPropertyWidgetHandler());
         EBUS_EVENT(AzToolsFramework::PropertyTypeRegistrationMessages::Bus, RegisterPropertyType, aznew FileResourceSelectorWidgetHandler());
-        EBUS_EVENT(AzToolsFramework::PropertyTypeRegistrationMessages::Bus, RegisterPropertyType, aznew ShaderPropertyHandler());
         EBUS_EVENT(AzToolsFramework::PropertyTypeRegistrationMessages::Bus, RegisterPropertyType, aznew ReverbPresetPropertyHandler());
         EBUS_EVENT(AzToolsFramework::PropertyTypeRegistrationMessages::Bus, RegisterPropertyType, aznew SequencePropertyHandler());
         EBUS_EVENT(AzToolsFramework::PropertyTypeRegistrationMessages::Bus, RegisterPropertyType, aznew SequenceIdPropertyHandler());

Code/Sandbox/Editor/Controls/ReflectedPropertyControl/PropertyGenericCtrl.cpp

@@ -26,7 +26,6 @@
 #include <CryCommon/ILocalizationManager.h>
 
 // Editor
-#include "ShadersDialog.h"
 #include "SelectLightAnimationDialog.h"
 #include "SelectSequenceDialog.h"
 #include "SelectEAXPresetDlg.h"
@@ -78,16 +77,6 @@ void GenericPopupPropertyEditor::SetPropertyType(PropertyType type)
     m_propertyType = type;
 }
 
-void ShaderPropertyEditor::onEditClicked()
-{
-    CShadersDialog cShaders(GetValue());
-    if (cShaders.exec() == QDialog::Accepted)
-    {
-        SetValue(cShaders.GetSelection());
-    }
-
-}
-
 void ReverbPresetPropertyEditor::onEditClicked()
 {
     CSelectEAXPresetDlg PresetDlg(this);

Code/Sandbox/Editor/Controls/ReflectedPropertyControl/PropertyGenericCtrl.h

@@ -100,15 +100,6 @@ public:
     }
 };
 
-class ShaderPropertyEditor
-    : public GenericPopupPropertyEditor
-{
-public:
-    ShaderPropertyEditor(QWidget* pParent = nullptr)
-        : GenericPopupPropertyEditor(pParent){}
-    void onEditClicked() override;
-};
-
 class ReverbPresetPropertyEditor
     : public GenericPopupPropertyEditor
 {
@@ -168,7 +159,6 @@ public:
 // So we use our own
 #define CONST_AZ_CRC(name, value) AZ::u32(value)
 
-using ShaderPropertyHandler = GenericPopupWidgetHandler<ShaderPropertyEditor, CONST_AZ_CRC("ePropertyShader", 0xc40932f1)>;
 using ReverbPresetPropertyHandler = GenericPopupWidgetHandler<ReverbPresetPropertyEditor, CONST_AZ_CRC("ePropertyReverbPreset", 0x51469f38)>;
 using MissionObjPropertyHandler = GenericPopupWidgetHandler<MissionObjPropertyEditor, CONST_AZ_CRC("ePropertyMissionObj", 0x4a2d0dc8)>;
 using SequencePropertyHandler = GenericPopupWidgetHandler<SequencePropertyEditor, CONST_AZ_CRC("ePropertySequence", 0xdd1c7d44)>;

Code/Sandbox/Editor/Controls/ReflectedPropertyControl/ReflectedPropertyItem.cpp

@@ -268,7 +268,6 @@ void ReflectedPropertyItem::SetVariable(IVariable *var)
     case ePropertyUser:
         m_reflectedVarAdapter = new ReflectedVarUserAdapter;
         break;
-    case ePropertyShader:
     case ePropertyEquip:
     case ePropertyReverbPreset:
     case ePropertyGameToken: