birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

review changes

Browse Source 
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
This commit is contained in:
sphrose
2021-11-11 12:57:48 +00:00
parent c3093edffe
commit 398decd06e
2 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/Terrain/Code/Tests/TerrainHeightGradientListTests.cpp
-8
View File
@@ -82,8 +82,6 @@ TEST_F(TerrainHeightGradientListComponentTest, MissingRequiredComponentsActivate
const AZ::Entity::DependencySortOutcome sortOutcome = entity->EvaluateDependenciesGetDetails(); const AZ::Entity::DependencySortOutcome sortOutcome = entity->EvaluateDependenciesGetDetails();
EXPECT_FALSE(sortOutcome.IsSuccess()); EXPECT_FALSE(sortOutcome.IsSuccess());
entity.reset();
} }
TEST_F(TerrainHeightGradientListComponentTest, ActivateEntityActivateSuccess) TEST_F(TerrainHeightGradientListComponentTest, ActivateEntityActivateSuccess)
@@ -97,8 +95,6 @@ TEST_F(TerrainHeightGradientListComponentTest, ActivateEntityActivateSuccess)
entity->Activate(); entity->Activate();
EXPECT_EQ(entity->GetState(), AZ::Entity::State::Active); EXPECT_EQ(entity->GetState(), AZ::Entity::State::Active);
entity.reset();
} }
TEST_F(TerrainHeightGradientListComponentTest, TerrainHeightGradientRefreshesTerrainSystem) TEST_F(TerrainHeightGradientListComponentTest, TerrainHeightGradientRefreshesTerrainSystem)
@@ -123,8 +119,6 @@ TEST_F(TerrainHeightGradientListComponentTest, TerrainHeightGradientRefreshesTer
// Stop the EXPECT_CALL check now, as OnCompositionChanged will get called twice again during the reset. // Stop the EXPECT_CALL check now, as OnCompositionChanged will get called twice again during the reset.
Mock::VerifyAndClearExpectations(&terrainSystem); Mock::VerifyAndClearExpectations(&terrainSystem);
entity.reset();
} }
TEST_F(TerrainHeightGradientListComponentTest, TerrainHeightGradientListReturnsHeights) TEST_F(TerrainHeightGradientListComponentTest, TerrainHeightGradientListReturnsHeights)
@@ -169,7 +163,5 @@ TEST_F(TerrainHeightGradientListComponentTest, TerrainHeightGradientListReturnsH
const float height = outPosition.GetZ(); const float height = outPosition.GetZ();
EXPECT_NEAR(height, mockGradientValue * max, 0.01f); EXPECT_NEAR(height, mockGradientValue * max, 0.01f);
entity.reset();
} }
Gems/Terrain/Code/Tests/TerrainSurfaceGradientListTests.cpp
+1 -5
View File
@@ -63,8 +63,6 @@ namespace UnitTest
const AZ::Entity::DependencySortOutcome sortOutcome = entity->EvaluateDependenciesGetDetails(); const AZ::Entity::DependencySortOutcome sortOutcome = entity->EvaluateDependenciesGetDetails();
EXPECT_FALSE(sortOutcome.IsSuccess()); EXPECT_FALSE(sortOutcome.IsSuccess());
entity.reset();
} }
TEST_F(TerrainSurfaceGradientListTest, SurfaceGradientActivateSuccess) TEST_F(TerrainSurfaceGradientListTest, SurfaceGradientActivateSuccess)
@@ -78,9 +76,7 @@ namespace UnitTest
entity->Activate(); entity->Activate();
EXPECT_EQ(entity->GetState(), AZ::Entity::State::Active);
entity.reset();
} }
TEST_F(TerrainSurfaceGradientListTest, SurfaceGradientReturnsSurfaceWeights) TEST_F(TerrainSurfaceGradientListTest, SurfaceGradientReturnsSurfaceWeights)