Removing unused variables and defines and some renaming

Signed-off-by: AMZN-Phil <pconroy@amazon.com>
This commit is contained in:
AMZN-Phil
2021-10-21 09:35:03 -07:00
parent 9aa9ed8c8e
commit 2809c3b7ed
5 changed files with 12 additions and 17 deletions
@@ -8,11 +8,8 @@
#include <DownloadController.h>
#include <DownloadWorker.h>
#include <ProjectButtonWidget.h>
#include <QMessageBox>
#include <QDesktopServices>
#include <QUrl>
namespace O3DE::ProjectManager
@@ -41,7 +41,14 @@ namespace O3DE::ProjectManager
const QString& GetCurrentDownloadingGem() const
{
return m_gemNames[0];
if (!m_gemNames.empty())
{
return m_gemNames[0];
}
else
{
return QString();
}
}
public slots:
void Start();
@@ -10,10 +10,6 @@
#include <DownloadWorker.h>
#include <PythonBindings.h>
#include <QMessageBox>
#include <QDesktopServices>
#include <QUrl>
namespace O3DE::ProjectManager
{
@@ -17,8 +17,6 @@ namespace O3DE::ProjectManager
{
class DownloadWorker : public QObject
{
// QProcess::waitForFinished uses -1 to indicate that the process should not timeout
static constexpr int MaxBuildTimeMSecs = -1;
// Download was cancelled
inline static const QString DownloadCancelled = QObject::tr("Download Cancelled.");
@@ -38,9 +36,6 @@ namespace O3DE::ProjectManager
private:
QProcess* m_configProjectProcess = nullptr;
QProcess* m_buildProjectProcess = nullptr;
QString m_gemName;
int m_downloadProgress;
};
@@ -164,11 +164,11 @@ namespace O3DE::ProjectManager
layout->setAlignment(Qt::AlignTop);
widget->setLayout(layout);
QLabel* label = new QLabel();
label->setObjectName("GemCatalogCartOverlaySectionLabel");
layout->addWidget(label);
QLabel* titleLabel = new QLabel();
titleLabel->setObjectName("GemCatalogCartOverlaySectionLabel");
layout->addWidget(titleLabel);
label->setText(tr("Gems to be installed"));
titleLabel->setText(tr("Gems to be installed"));
// Create header section
QWidget* downloadingGemsWidget = new QWidget();