redcode sc asset files bloodbath

Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>

Gems/ScriptCanvas/Code/Builder/ScriptCanvasBuilder.cpp

@@ -6,15 +6,15 @@
  *
  */
 
+#include <AzCore/Asset/AssetSerializer.h>
 #include <AzToolsFramework/API/EditorAssetSystemAPI.h>
 #include <Builder/ScriptCanvasBuilder.h>
 #include <Builder/ScriptCanvasBuilderWorker.h>
-
+#include <ScriptCanvas/Assets/ScriptCanvasFileHandling.h>
+#include <ScriptCanvas/Components/EditorDeprecationData.h>
+#include <ScriptCanvas/Components/EditorGraph.h>
 #include <ScriptCanvas/Components/EditorGraphVariableManagerComponent.h>
 #include <ScriptCanvas/Grammar/AbstractCodeModel.h>
-#include <AzCore/Asset/AssetSerializer.h>
-#include <ScriptCanvas/Assets/ScriptCanvasFileHandling.h>
-#include <ScriptCanvas/Components/EditorGraph.h>
 
 namespace BuildVariableOverridesCpp
 {
@@ -41,7 +41,7 @@ namespace BuildVariableOverridesCpp
             }
 
             auto& sourceElement = rootElement.GetSubElement(sourceIndex);
-            AZ::Data::Asset<ScriptCanvasEditor::ScriptCanvasAsset> asset;
+            AZ::Data::Asset<ScriptCanvasEditor::Deprecated::ScriptCanvasAsset> asset;
             if (!sourceElement.GetData(asset))
             {
                 AZ_Error("ScriptCanvas", false, "BuildVariableOverrides coversion failed: could not retrieve 'source' data");

Gems/ScriptCanvas/Code/Builder/ScriptCanvasBuilder.h

@@ -15,7 +15,6 @@
 
 namespace ScriptCanvasEditor
 {
-    class ScriptCanvasAsset;
     class EditorAssetTree;
 }
 

Gems/ScriptCanvas/Code/Builder/ScriptCanvasBuilderComponent.cpp

@@ -96,8 +96,6 @@ namespace ScriptCanvasBuilder
             builderDescriptor.m_productsToKeepOnFailure[s_scriptCanvasProcessJobKey] = { AZ_CRC("SubgraphInterface", 0xdfe6dc72) };
             m_scriptCanvasBuilder.BusConnect(builderDescriptor.m_busId);
             AssetBuilderSDK::AssetBuilderBus::Broadcast(&AssetBuilderSDK::AssetBuilderBus::Handler::RegisterBuilderInformation, builderDescriptor);
-
-            AzToolsFramework::ToolsAssetSystemBus::Broadcast(&AzToolsFramework::ToolsAssetSystemRequests::RegisterSourceAssetType, azrtti_typeid<ScriptCanvasEditor::ScriptCanvasAsset>(), ScriptCanvasEditor::ScriptCanvasAsset::Description::GetFileFilter<ScriptCanvasEditor::ScriptCanvasAsset>());
         }
 
         m_sharedHandlers = HandleAssetTypes();
@@ -109,7 +107,6 @@ namespace ScriptCanvasBuilder
     {
         // Finish all queued work
         AZ::Data::AssetBus::ExecuteQueuedEvents();
-        AzToolsFramework::ToolsAssetSystemBus::Broadcast(&AzToolsFramework::ToolsAssetSystemRequests::UnregisterSourceAssetType, azrtti_typeid<ScriptCanvasEditor::ScriptCanvasAsset>());
         m_scriptCanvasBuilder.BusDisconnect();
         m_sharedHandlers.DeleteOwnedHandlers();
     }

Gems/ScriptCanvas/Code/Builder/ScriptCanvasBuilderWorker.cpp

@@ -44,10 +44,8 @@ namespace ScriptCanvasBuilder
         AzFramework::StringFunc::Path::ConstructFull(request.m_watchFolder.data(), request.m_sourceFile.data(), fullPath, false);
         AzFramework::StringFunc::Path::Normalize(fullPath);
 
-        AZ::Data::Asset<ScriptCanvasEditor::ScriptCanvasAsset> asset;
         const ScriptCanvasEditor::Graph* sourceGraph = nullptr;
         const ScriptCanvas::GraphData* graphData = nullptr;
-
         ScriptCanvasEditor::SourceHandle sourceHandle;
 
         auto sourceOutcome = ScriptCanvasEditor::LoadFromFile(fullPath);
@@ -57,7 +55,14 @@ namespace ScriptCanvasBuilder
             sourceGraph = sourceHandle.Get();
             graphData = sourceGraph->GetGraphDataConst();
         }
-        
+        else
+        {
+            AZ_TracePrintf(s_scriptCanvasBuilder, "Failed to load the file: %s", fullPath.c_str());
+            response.m_result = AssetBuilderSDK::CreateJobsResultCode::Failed;
+        }
+
+        // in terms of job creation, assert on anything but smooth sailing from this point
+
         AZ_Assert(sourceGraph, "Graph component is missing from entity.");
         AZ_Assert(graphData, "GraphData is missing from entity");
 

Gems/ScriptCanvas/Code/Builder/ScriptCanvasBuilderWorker.h

@@ -36,7 +36,6 @@ namespace ScriptCanvas
 namespace ScriptCanvasEditor
 {
     class Graph;
-    class ScriptCanvasAsset;
     class SourceHandle;
 }
 
@@ -132,8 +131,6 @@ namespace ScriptCanvasBuilder
 
     int GetBuilderVersion();
 
-    AZ::Outcome<AZ::Data::Asset<ScriptCanvasEditor::ScriptCanvasAsset>, AZStd::string> LoadEditorAsset(AZStd::string_view graphPath, AZ::Data::AssetId assetId, AZ::Data::AssetFilterCB assetFilterCB = {});
-
     AZ::Outcome<ScriptCanvas::Grammar::AbstractCodeModelConstPtr, AZStd::string> ParseGraph(AZ::Entity& buildEntity, AZStd::string_view graphPath);
 
     AZ::Outcome<void, AZStd::string> ProcessTranslationJob(ProcessTranslationJobInput& input);