birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Potential Memory Corruption in Release Build (#3559)

Browse Source 
* Potential Memory Corruption in Release Build

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* @lumberyard-employee-dm suggested code

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* warnings as errors found in VS2022

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* simplifying some strucutres used and fixing a bug

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* some unused fixes for VS2022

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* fix for other platforms

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* fixes check used in unit tests to be case-insensitive
fixes memory leaks/invalid memory operations in AWSCore tests

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
This commit is contained in:
Esteban Papp
2021-08-26 15:59:40 -07:00
committed by GitHub
parent 9f55212a19
commit 1be95a1e76
20 changed files with 93 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/Blast/Code/Source/Actor/BlastActorFactory.cpp
-4
View File
@@ -43,8 +43,6 @@ namespace Blast
const Nv::Blast::ExtPxChunk* pxChunks = blastFamily.GetPxAsset().getChunks();
const NvBlastChunk* chunks = tkAsset->getChunks();
const uint32_t pxChunkCount = blastFamily.GetPxAsset().getChunkCount();
const uint32_t chunkCount = tkAsset->getChunkCount();
const uint32_t nodeCount = tkActor.getGraphNodeCount();
AZ_Assert(pxChunks, "ExtPxAsset asset has a null chunk array.");
AZ_Assert(chunks, "TkActor's asset has a null chunk array.");
@@ -183,8 +181,6 @@ namespace Blast
bool BlastActorFactoryImpl::VisibleChunksHasStaticActor(
const BlastFamily& blastFamily, const AZStd::vector<uint32_t>& chunkIndices) const
{
const uint32_t chunkCount = blastFamily.GetPxAsset().getChunkCount();
const Nv::Blast::ExtPxChunk* pxChunks = blastFamily.GetPxAsset().getChunks();
if (!pxChunks)
{