Addressed review feedback

Signed-off-by: nggieber <nggieber@amazon.com>
This commit is contained in:
nggieber
2021-09-28 18:37:44 -07:00
parent 0b5aaa297e
commit 16e66cfa71
6 changed files with 15 additions and 35 deletions
@@ -75,9 +75,8 @@ namespace O3DE::ProjectManager
void GemRepoScreen::HandleAddRepoButton()
{
GemRepoAddDialog* repoAddDialog = new GemRepoAddDialog(this);
repoAddDialog->exec();
if (repoAddDialog->GetButtonResult() == QDialogButtonBox::ApplyRole)
if (repoAddDialog->exec() == QDialog::DialogCode::Accepted)
{
QString repoUrl = repoAddDialog->GetRepoPath();
if (repoUrl.isEmpty())
@@ -93,7 +92,7 @@ namespace O3DE::ProjectManager
else
{
QMessageBox::critical(this, tr("Operation failed"),
QString("Failed to add gem repo: %1.\nError:\n%2").arg(repoUrl, addGemRepoResult.GetError().c_str()));
QString("Failed to add gem repo: %1.<br>Error:<br>%2").arg(repoUrl, addGemRepoResult.GetError().c_str()));
}
}
}
@@ -112,7 +111,7 @@ namespace O3DE::ProjectManager
}
else
{
QMessageBox::critical(this, tr("Operation failed"), QString("Cannot retrieve gem repos for engine.\n\nError:\n%2").arg(allGemRepoInfosResult.GetError().c_str()));
QMessageBox::critical(this, tr("Operation failed"), QString("Cannot retrieve gem repos for engine.<br>Error:<br>%2").arg(allGemRepoInfosResult.GetError().c_str()));
}
}