From 13188f89580da398c019043510d402bddd4bb9da Mon Sep 17 00:00:00 2001 From: chcurran <82187351+carlitosan@users.noreply.github.com> Date: Mon, 23 Aug 2021 15:56:45 -0700 Subject: [PATCH] Simplify codegen of baseclass Signed-off-by: chcurran <82187351+carlitosan@users.noreply.github.com> --- .../ScriptCanvas/AutoGen/ScriptCanvasGrammar_Header.jinja | 4 +--- .../ScriptCanvas/AutoGen/ScriptCanvasGrammar_Source.jinja | 4 +--- .../ScriptCanvas/Libraries/Logic/Gate.ScriptCanvasGrammar.xml | 1 - 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/Gems/ScriptCanvas/Code/Include/ScriptCanvas/AutoGen/ScriptCanvasGrammar_Header.jinja b/Gems/ScriptCanvas/Code/Include/ScriptCanvas/AutoGen/ScriptCanvasGrammar_Header.jinja index ea87573306..ae531aed3b 100644 --- a/Gems/ScriptCanvas/Code/Include/ScriptCanvas/AutoGen/ScriptCanvasGrammar_Header.jinja +++ b/Gems/ScriptCanvas/Code/Include/ScriptCanvas/AutoGen/ScriptCanvasGrammar_Header.jinja @@ -44,9 +44,7 @@ namespace {{attribute_Namespace}} { {% endif %} {% set className = Class.attrib['Name'] %} -{% set bases = Class.attrib['Base'].split(';') if Class.attrib['Base'] is string else ["ScriptCanvas::Node", "ScriptCanvas::Node"] %} -{% set baseClass = bases[0] %} -{% set baseClasses = bases[1] if bases|length() > 1 else "ScriptCanvas::Node" %} +{% set baseClasses = ", ".join(Class.attrib['Base'].split(';')) if Class.attrib['Base'] is string else "ScriptCanvas::Node" %} ///////////////////////////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////////////////////////// //// diff --git a/Gems/ScriptCanvas/Code/Include/ScriptCanvas/AutoGen/ScriptCanvasGrammar_Source.jinja b/Gems/ScriptCanvas/Code/Include/ScriptCanvas/AutoGen/ScriptCanvasGrammar_Source.jinja index e206b185e0..1db676df84 100644 --- a/Gems/ScriptCanvas/Code/Include/ScriptCanvas/AutoGen/ScriptCanvasGrammar_Source.jinja +++ b/Gems/ScriptCanvas/Code/Include/ScriptCanvas/AutoGen/ScriptCanvasGrammar_Source.jinja @@ -28,9 +28,7 @@ SPDX-License-Identifier: Apache-2.0 OR MIT #include "{{ xml.attrib['Include'] }}" {% for Class in xml.iter('Class') %} -{% set bases = Class.attrib['Base'].split(';') if Class.attrib['Base'] is string else ["ScriptCanvas::Node", "ScriptCanvas::Node"] %} -{% set baseClass = bases[0] %} -{% set baseClasses = bases[1] if bases|length() > 1 else "ScriptCanvas::Node" %} +{% set baseClass = Class.attrib['Base'].split(';')[0] if Class.attrib['Base'] is string else "ScriptCanvas::Node" %} void {{ Class.attrib['QualifiedName'] }}::ConfigureSlots() { {{ baseClass }}::ConfigureSlots(); diff --git a/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Logic/Gate.ScriptCanvasGrammar.xml b/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Logic/Gate.ScriptCanvasGrammar.xml index 53d8623fe8..4e2e89fc7b 100644 --- a/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Logic/Gate.ScriptCanvasGrammar.xml +++ b/Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Logic/Gate.ScriptCanvasGrammar.xml @@ -5,7 +5,6 @@ QualifiedName="ScriptCanvas::Nodes::Logic::Gate" PreferredClassName="If" Uuid="{F19CC10A-02FD-4E75-ADAA-9CFBD8A4E2F8}" - Base="ScriptCanvas::Node" Icon="Icons/ScriptCanvas/Print.png" Version="0" GeneratePropertyFriend="True"